sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(i18n): sweep hardcoded 'en-US' from non-loyalty JS to I18n.locale
Some checks failed
CI / ruff (push) Successful in 16s
Details
CI / docs (push) Has been cancelled
Details
CI / deploy (push) Has been cancelled
Details
CI / validate (push) Has been cancelled
Details
CI / dependency-scanning (push) Has been cancelled
Details
CI / pytest (push) Has been cancelled
Details

Browse Source 
Follow-up to dd1f9af8 which fixed loyalty. The same hardcoded 'en-US'
in toLocaleDateString / toLocaleString / Intl.NumberFormat appeared in
13 files across catalog, marketplace, orders, tenancy, inventory,
monitoring, cms, the storefront layout, and the shared Utils helper
itself. After this sweep, no non-loyalty JS hardcodes 'en-US' anymore;
all use I18n.locale and respect the user's dashboard language.

The highest-leverage one is static/shared/js/utils.js (Utils.formatDate
/ Utils.formatDateTime / Utils.formatCurrency / Utils.formatNumber) —
those four helpers are called from across the frontends so this one
edit fixes most secondary callsites for free.

Codemod scope was conservative: only replaced 'en-US' when it
appeared as the first argument to toLocale* or new Intl.* calls, to
avoid touching unrelated occurrences (none found, but the guard
matters if more get added).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2026-05-24 23:38:35 +02:00
parent a21dbbcddf
commit 06e59f73b3
13 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/modules/catalog/static/admin/js/products.js
View File

@@ -405,7 +405,7 @@ function adminStoreProducts() {
*/
formatPrice(price, currency = 'EUR') {
if (price === null || price === undefined) return '-';
return new Intl.NumberFormat('en-US', {
return new Intl.NumberFormat(I18n.locale, {
style: 'currency',
currency: currency || 'EUR'
}).format(price);

2
app/modules/cms/static/admin/js/content-pages.js
View File

@@ -272,7 +272,7 @@ function contentPagesManager() {
} else if (diffDays < 7) {
return `${diffDays} days ago`;
} else {
return date.toLocaleDateString('en-US', {
return date.toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'

2
app/modules/core/static/storefront/js/storefront-layout.js
View File

@@ -233,7 +233,7 @@ function storefrontLayoutData() {
formatDate(dateString) {
if (!dateString) return '-';
const date = new Date(dateString);
return date.toLocaleDateString('en-US', {
return date.toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'

2
app/modules/inventory/static/admin/js/inventory.js
View File

@@ -489,7 +489,7 @@ function adminInventory() {
*/
formatNumber(num) {
if (num === null || num === undefined) return '0';
return new Intl.NumberFormat('en-US').format(num);
return new Intl.NumberFormat(I18n.locale).format(num);
},
/**

2
app/modules/marketplace/static/admin/js/imports.js
View File

@@ -387,7 +387,7 @@ function adminImports() {
try {
const date = new Date(dateString);
return date.toLocaleString('en-US', {
return date.toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

4
app/modules/marketplace/static/admin/js/marketplace-product-detail.js
View File

@@ -157,7 +157,7 @@ function adminMarketplaceProductDetail() {
*/
formatPrice(price, currency = 'EUR') {
if (price === null || price === undefined) return '-';
return new Intl.NumberFormat('en-US', {
return new Intl.NumberFormat(I18n.locale, {
style: 'currency',
currency: currency || 'EUR'
}).format(price);
@@ -170,7 +170,7 @@ function adminMarketplaceProductDetail() {
if (!dateString) return '-';
try {
const date = new Date(dateString);
return date.toLocaleDateString('en-US', {
return date.toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

2
app/modules/marketplace/static/admin/js/marketplace-products.js
View File

@@ -515,7 +515,7 @@ function adminMarketplaceProducts() {
*/
formatPrice(price, currency = 'EUR') {
if (price === null || price === undefined) return '-';
return new Intl.NumberFormat('en-US', {
return new Intl.NumberFormat(I18n.locale, {
style: 'currency',
currency: currency || 'EUR'
}).format(price);

2
app/modules/marketplace/static/admin/js/marketplace.js
View File

@@ -453,7 +453,7 @@ function adminMarketplace() {
try {
const date = new Date(dateString);
return date.toLocaleString('en-US', {
return date.toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

2
app/modules/monitoring/static/admin/js/imports.js
View File

@@ -387,7 +387,7 @@ function adminImports() {
try {
const date = new Date(dateString);
return date.toLocaleString('en-US', {
return date.toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',

2
app/modules/monitoring/static/admin/js/platform-health.js
View File

@@ -99,7 +99,7 @@ function adminPlatformHealth() {
if (typeof num === 'number' && num % 1 !== 0) {
return num.toFixed(2);
}
return new Intl.NumberFormat('en-US').format(num);
return new Intl.NumberFormat(I18n.locale).format(num);
},
/**

2
app/modules/orders/static/admin/js/orders.js
View File

@@ -540,7 +540,7 @@ function adminOrders() {
*/
formatPrice(price, currency = 'EUR') {
if (price === null || price === undefined) return '-';
return new Intl.NumberFormat('en-US', {
return new Intl.NumberFormat(I18n.locale, {
style: 'currency',
currency: currency || 'EUR'
}).format(price);

2
app/modules/tenancy/static/admin/js/merchants.js
View File

@@ -257,7 +257,7 @@ function adminMerchants() {
if (!dateString) return 'N/A';
try {
const date = new Date(dateString);
return date.toLocaleDateString('en-US', {
return date.toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'

8
static/shared/js/utils.js
View File

@@ -15,7 +15,7 @@ const Utils = {
try {
const date = new Date(dateString);
return date.toLocaleDateString('en-US', {
return date.toLocaleDateString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric'
@@ -36,7 +36,7 @@ const Utils = {
try {
const date = new Date(dateString);
return date.toLocaleString('en-US', {
return date.toLocaleString(I18n.locale, {
year: 'numeric',
month: 'short',
day: 'numeric',
@@ -59,7 +59,7 @@ const Utils = {
if (amount === null || amount === undefined) return '-';
try {
return new Intl.NumberFormat('en-US', {
return new Intl.NumberFormat(I18n.locale, {
style: 'currency',
currency: currency
}).format(amount);
@@ -76,7 +76,7 @@ const Utils = {
*/
formatNumber(num) {
if (num === null || num === undefined) return '0';
return num.toLocaleString('en-US');
return num.toLocaleString(I18n.locale);
},
/**