fix: replace all native confirm() dialogs with styled modal macros
Some checks failed
CI / ruff (push) Successful in 9s
CI / validate (push) Has been cancelled
CI / dependency-scanning (push) Has been cancelled
CI / docs (push) Has been cancelled
CI / deploy (push) Has been cancelled
CI / pytest (push) Has been cancelled

Migrated ~68 native browser confirm() calls across 74 files to use the
project's confirm_modal/confirm_modal_dynamic Jinja2 macros, providing
consistent styled confirmation dialogs instead of plain browser popups.

Modules updated: core, tenancy, cms, marketplace, messaging, billing,
customers, orders, cart. Uses danger/warning/info variants and
double-confirm pattern for destructive delete operations.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-19 16:56:25 +01:00
parent 182610283d
commit 167bb50f4f
74 changed files with 939 additions and 436 deletions

View File

@@ -21,6 +21,12 @@ function contentPagesManager() {
loading: false,
error: null,
// Modal state
showCreateHomepageConfirm: false,
pendingHomepagePlatform: null,
showDeletePageConfirm: false,
pageToDelete: null,
// Tabs and filters
activeTab: 'all', // all, platform_marketing, store_defaults, store_overrides
searchQuery: '',
@@ -188,13 +194,19 @@ function contentPagesManager() {
// Show a toast and offer to create
if (slug === 'home') {
// Offer to create homepage
if (confirm(`No homepage found for ${platformCode}. Would you like to create one?`)) {
window.location.href = `/admin/content-pages/create?platform_code=${platformCode}&slug=home&is_platform_page=true`;
}
this.pendingHomepagePlatform = platformCode;
this.showCreateHomepageConfirm = true;
}
}
},
// Create homepage for a platform (called from confirm modal)
createHomepage() {
if (this.pendingHomepagePlatform) {
window.location.href = `/admin/content-pages/create?platform_code=${this.pendingHomepagePlatform}&slug=home&is_platform_page=true`;
}
},
// Get page tier label (three-tier system)
getPageTierLabel(page) {
if (page.store_id) {
@@ -220,12 +232,14 @@ function contentPagesManager() {
}
},
// Prompt delete page confirmation
promptDeletePage(page) {
this.pageToDelete = page;
this.showDeletePageConfirm = true;
},
// Delete a page
async deletePage(page) {
if (!confirm(`Are you sure you want to delete "${page.title}"?`)) {
return;
}
try {
contentPagesLog.info(`Deleting page: ${page.id}`);

View File

@@ -40,6 +40,9 @@ function storeContentPageEditor(pageId) {
loadingDefault: false,
defaultContent: null,
// Delete confirmation modal state
showDeletePageConfirm: false,
// Initialize
async init() {
// Prevent multiple initializations
@@ -211,14 +214,6 @@ function storeContentPageEditor(pageId) {
// Delete page (revert to default for overrides)
async deletePage() {
const message = this.isOverride
? 'Are you sure you want to revert to the platform default? Your customizations will be lost.'
: 'Are you sure you want to delete this page? This cannot be undone.';
if (!confirm(message)) {
return;
}
try {
contentPageEditLog.info('Deleting page:', this.pageId);

View File

@@ -20,6 +20,10 @@ function storeContentPagesManager() {
activeTab: 'platform',
searchQuery: '',
// Modal state
showDeletePageConfirm: false,
pageToDelete: null,
// Data
platformPages: [], // Platform default pages
customPages: [], // Store's own pages (overrides + custom)
@@ -152,16 +156,14 @@ function storeContentPagesManager() {
}
},
// Prompt delete page confirmation
promptDeletePage(page) {
this.pageToDelete = page;
this.showDeletePageConfirm = true;
},
// Delete a page
async deletePage(page) {
const message = page.is_store_override
? `Are you sure you want to delete your override for "${page.title}"? The platform default will be shown instead.`
: `Are you sure you want to delete "${page.title}"? This cannot be undone.`;
if (!confirm(message)) {
return;
}
try {
contentPagesLog.info('Deleting page:', page.id);

View File

@@ -105,6 +105,7 @@ function storeMedia() {
// Modal states
showUploadModal: false,
showDetailModal: false,
showDeleteMediaConfirm: false,
selectedMedia: null,
editingMedia: {
filename: '',
@@ -253,10 +254,6 @@ function storeMedia() {
async deleteMedia() {
if (!this.selectedMedia) return;
if (!confirm(I18n.t('cms.confirmations.delete_file'))) {
return;
}
this.saving = true;
try {