feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -63,7 +63,7 @@ class ProductAlreadyExistsException(ConflictException):
|
||||
)
|
||||
|
||||
|
||||
class ProductNotInCatalogException(ResourceNotFoundException): # noqa: MOD-025
|
||||
class ProductNotInCatalogException(ResourceNotFoundException): # noqa: MOD025
|
||||
"""Raised when trying to access a product that's not in store's catalog."""
|
||||
|
||||
def __init__(self, product_id: int, store_id: int):
|
||||
@@ -129,7 +129,7 @@ class ProductValidationException(ValidationException):
|
||||
self.error_code = "PRODUCT_VALIDATION_FAILED"
|
||||
|
||||
|
||||
class CannotDeleteProductException(BusinessLogicException): # noqa: MOD-025
|
||||
class CannotDeleteProductException(BusinessLogicException): # noqa: MOD025
|
||||
"""Raised when a product cannot be deleted due to dependencies."""
|
||||
|
||||
def __init__(self, product_id: int, reason: str, details: dict | None = None):
|
||||
@@ -140,7 +140,7 @@ class CannotDeleteProductException(BusinessLogicException): # noqa: MOD-025
|
||||
)
|
||||
|
||||
|
||||
class CannotDeleteProductWithInventoryException(BusinessLogicException): # noqa: MOD-025
|
||||
class CannotDeleteProductWithInventoryException(BusinessLogicException): # noqa: MOD025
|
||||
"""Raised when trying to delete a product that has inventory."""
|
||||
|
||||
def __init__(self, product_id: int, inventory_count: int):
|
||||
@@ -154,7 +154,7 @@ class CannotDeleteProductWithInventoryException(BusinessLogicException): # noqa
|
||||
)
|
||||
|
||||
|
||||
class CannotDeleteProductWithOrdersException(BusinessLogicException): # noqa: MOD-025
|
||||
class CannotDeleteProductWithOrdersException(BusinessLogicException): # noqa: MOD025
|
||||
"""Raised when trying to delete a product that has been ordered."""
|
||||
|
||||
def __init__(self, product_id: int, order_count: int):
|
||||
|
||||
@@ -10,7 +10,7 @@ from datetime import datetime
|
||||
|
||||
from pydantic import BaseModel, ConfigDict
|
||||
|
||||
from app.modules.inventory.schemas import InventoryLocationResponse # noqa: IMPORT-002
|
||||
from app.modules.inventory.schemas import InventoryLocationResponse # noqa: IMPORT002
|
||||
from app.modules.marketplace.schemas import MarketplaceProductResponse # IMPORT-002
|
||||
|
||||
|
||||
|
||||
@@ -10,7 +10,7 @@ from datetime import datetime
|
||||
|
||||
from pydantic import BaseModel, ConfigDict, Field
|
||||
|
||||
from app.modules.inventory.schemas import InventoryLocationResponse # noqa: IMPORT-002
|
||||
from app.modules.inventory.schemas import InventoryLocationResponse # noqa: IMPORT002
|
||||
from app.modules.marketplace.schemas import MarketplaceProductResponse # IMPORT-002
|
||||
|
||||
|
||||
|
||||
@@ -306,7 +306,7 @@ class TestProductInventoryProperties:
|
||||
|
||||
def test_physical_product_with_inventory(self, db, test_store):
|
||||
"""Test physical product calculates inventory from entries."""
|
||||
from app.modules.inventory.models import Inventory # noqa: IMPORT-002
|
||||
from app.modules.inventory.models import Inventory # noqa: IMPORT002
|
||||
|
||||
product = Product(
|
||||
store_id=test_store.id,
|
||||
@@ -364,7 +364,7 @@ class TestProductInventoryProperties:
|
||||
|
||||
def test_digital_product_ignores_inventory_entries(self, db, test_store):
|
||||
"""Test digital product returns unlimited even with inventory entries."""
|
||||
from app.modules.inventory.models import Inventory # noqa: IMPORT-002
|
||||
from app.modules.inventory.models import Inventory # noqa: IMPORT002
|
||||
|
||||
product = Product(
|
||||
store_id=test_store.id,
|
||||
|
||||
Reference in New Issue
Block a user