feat(validators): add noqa suppression support to security and performance validators
All checks were successful
CI / dependency-scanning (push) Successful in 27s
CI / docs (push) Successful in 35s
CI / ruff (push) Successful in 8s
CI / pytest (push) Successful in 34m22s
CI / validate (push) Successful in 19s
CI / deploy (push) Successful in 2m25s

- Add centralized _is_noqa_suppressed() to BaseValidator with normalization
  (accepts both SEC001 and SEC-001 formats for ruff compatibility)
- Wire noqa support into all 21 security and 18 performance check functions
- Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml
- Convert all 280 Python noqa comments to dashless format (ruff-compatible)
- Add site/ to IGNORE_PATTERNS (excludes mkdocs build output)
- Suppress 152 false positive findings (test passwords, seed data, validator
  self-references, Apple Wallet SHA1, etc.)
- Security: 79 errors → 0, 60 warnings → 0
- Performance: 80 warnings → 77 (3 test script suppressions)
- Add proposal doc with noqa inventory and remaining findings recommendations

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-14 22:56:56 +01:00
parent f84c5d903e
commit 1b8a40f1ff
75 changed files with 404 additions and 310 deletions

View File

@@ -63,7 +63,7 @@ class ProductAlreadyExistsException(ConflictException):
)
class ProductNotInCatalogException(ResourceNotFoundException): # noqa: MOD-025
class ProductNotInCatalogException(ResourceNotFoundException): # noqa: MOD025
"""Raised when trying to access a product that's not in store's catalog."""
def __init__(self, product_id: int, store_id: int):
@@ -129,7 +129,7 @@ class ProductValidationException(ValidationException):
self.error_code = "PRODUCT_VALIDATION_FAILED"
class CannotDeleteProductException(BusinessLogicException): # noqa: MOD-025
class CannotDeleteProductException(BusinessLogicException): # noqa: MOD025
"""Raised when a product cannot be deleted due to dependencies."""
def __init__(self, product_id: int, reason: str, details: dict | None = None):
@@ -140,7 +140,7 @@ class CannotDeleteProductException(BusinessLogicException): # noqa: MOD-025
)
class CannotDeleteProductWithInventoryException(BusinessLogicException): # noqa: MOD-025
class CannotDeleteProductWithInventoryException(BusinessLogicException): # noqa: MOD025
"""Raised when trying to delete a product that has inventory."""
def __init__(self, product_id: int, inventory_count: int):
@@ -154,7 +154,7 @@ class CannotDeleteProductWithInventoryException(BusinessLogicException): # noqa
)
class CannotDeleteProductWithOrdersException(BusinessLogicException): # noqa: MOD-025
class CannotDeleteProductWithOrdersException(BusinessLogicException): # noqa: MOD025
"""Raised when trying to delete a product that has been ordered."""
def __init__(self, product_id: int, order_count: int):