feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -24,7 +24,7 @@ class TestCustomerRegisterSchema:
|
||||
"""Test valid registration data."""
|
||||
customer = CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="Password123", # noqa: SEC-001
|
||||
password="Password123", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -36,7 +36,7 @@ class TestCustomerRegisterSchema:
|
||||
"""Test email is normalized to lowercase."""
|
||||
customer = CustomerRegister(
|
||||
email="Customer@Example.COM",
|
||||
password="Password123", # noqa: SEC-001
|
||||
password="Password123", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -47,7 +47,7 @@ class TestCustomerRegisterSchema:
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
CustomerRegister(
|
||||
email="not-an-email",
|
||||
password="Password123", # noqa: SEC-001
|
||||
password="Password123", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -58,7 +58,7 @@ class TestCustomerRegisterSchema:
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="Pass1", # noqa: SEC-001
|
||||
password="Pass1", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -69,7 +69,7 @@ class TestCustomerRegisterSchema:
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="Password", # noqa: SEC-001
|
||||
password="Password", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -80,7 +80,7 @@ class TestCustomerRegisterSchema:
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="12345678", # noqa: SEC-001
|
||||
password="12345678", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -91,7 +91,7 @@ class TestCustomerRegisterSchema:
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="Password123", # noqa: SEC-001
|
||||
password="Password123", # noqa: SEC001
|
||||
last_name="Doe",
|
||||
)
|
||||
assert "first_name" in str(exc_info.value).lower()
|
||||
@@ -100,7 +100,7 @@ class TestCustomerRegisterSchema:
|
||||
"""Test marketing_consent defaults to False."""
|
||||
customer = CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="Password123", # noqa: SEC-001
|
||||
password="Password123", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
@@ -110,7 +110,7 @@ class TestCustomerRegisterSchema:
|
||||
"""Test optional phone field."""
|
||||
customer = CustomerRegister(
|
||||
email="customer@example.com",
|
||||
password="Password123", # noqa: SEC-001
|
||||
password="Password123", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
phone="+352 123 456",
|
||||
|
||||
Reference in New Issue
Block a user