feat(validators): add noqa suppression support to security and performance validators
All checks were successful
CI / dependency-scanning (push) Successful in 27s
CI / docs (push) Successful in 35s
CI / ruff (push) Successful in 8s
CI / pytest (push) Successful in 34m22s
CI / validate (push) Successful in 19s
CI / deploy (push) Successful in 2m25s

- Add centralized _is_noqa_suppressed() to BaseValidator with normalization
  (accepts both SEC001 and SEC-001 formats for ruff compatibility)
- Wire noqa support into all 21 security and 18 performance check functions
- Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml
- Convert all 280 Python noqa comments to dashless format (ruff-compatible)
- Add site/ to IGNORE_PATTERNS (excludes mkdocs build output)
- Suppress 152 false positive findings (test passwords, seed data, validator
  self-references, Apple Wallet SHA1, etc.)
- Security: 79 errors → 0, 60 warnings → 0
- Performance: 80 warnings → 77 (3 test script suppressions)
- Add proposal doc with noqa inventory and remaining findings recommendations

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-14 22:56:56 +01:00
parent f84c5d903e
commit 1b8a40f1ff
75 changed files with 404 additions and 310 deletions

View File

@@ -28,7 +28,7 @@ from app.modules.monitoring.exceptions import (
# =============================================================================
class TestRunNotFoundException(ResourceNotFoundException): # noqa: MOD-025
class TestRunNotFoundException(ResourceNotFoundException): # noqa: MOD025
"""Raised when a test run is not found."""
def __init__(self, run_id: int):
@@ -39,7 +39,7 @@ class TestRunNotFoundException(ResourceNotFoundException): # noqa: MOD-025
)
class TestExecutionException(ExternalServiceException): # noqa: MOD-025
class TestExecutionException(ExternalServiceException): # noqa: MOD025
"""Raised when test execution fails."""
def __init__(self, reason: str):
@@ -50,7 +50,7 @@ class TestExecutionException(ExternalServiceException): # noqa: MOD-025
)
class TestTimeoutException(ExternalServiceException): # noqa: MOD-025
class TestTimeoutException(ExternalServiceException): # noqa: MOD025
"""Raised when test execution times out."""
def __init__(self, timeout_seconds: int = 3600):

View File

@@ -186,7 +186,7 @@ class CodeQualityService:
try:
scan = self.run_scan(db, triggered_by, validator_type)
results.append(scan)
except Exception as e: # noqa: EXC-003
except Exception as e: # noqa: EXC003
logger.error(f"Failed to run {validator_type} scan: {e}")
# Continue with other validators even if one fails
return results