feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -167,7 +167,7 @@ class AppleWalletService:
|
||||
"""
|
||||
try:
|
||||
self.register_device(db, card, device_id, push_token)
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Failed to register device: {e}")
|
||||
raise DeviceRegistrationException(device_id, "register")
|
||||
|
||||
@@ -190,7 +190,7 @@ class AppleWalletService:
|
||||
"""
|
||||
try:
|
||||
self.unregister_device(db, card, device_id)
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Failed to unregister device: {e}")
|
||||
raise DeviceRegistrationException(device_id, "unregister")
|
||||
|
||||
@@ -244,7 +244,7 @@ class AppleWalletService:
|
||||
# Create manifest
|
||||
manifest = {}
|
||||
for filename, content in pass_files.items():
|
||||
manifest[filename] = hashlib.sha1(content).hexdigest()
|
||||
manifest[filename] = hashlib.sha1(content).hexdigest() # noqa: SEC041
|
||||
pass_files["manifest.json"] = json.dumps(manifest).encode("utf-8")
|
||||
|
||||
# Sign the manifest
|
||||
@@ -521,7 +521,7 @@ class AppleWalletService:
|
||||
for registration in registrations:
|
||||
try:
|
||||
self._send_push(registration.push_token)
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.warning(
|
||||
f"Failed to send push to device {registration.device_library_identifier[:8]}...: {e}"
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user