feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -218,7 +218,7 @@ class SendGridProvider(EmailProvider):
|
||||
|
||||
except ImportError:
|
||||
return False, None, "SendGrid library not installed. Run: pip install sendgrid"
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"SendGrid send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -267,7 +267,7 @@ class MailgunProvider(EmailProvider):
|
||||
return True, result.get("id"), None
|
||||
return False, None, f"Mailgun error: {response.status_code} - {response.text}"
|
||||
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Mailgun send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -319,7 +319,7 @@ class SESProvider(EmailProvider):
|
||||
|
||||
except ImportError:
|
||||
return False, None, "boto3 library not installed. Run: pip install boto3"
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"SES send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -545,7 +545,7 @@ class ConfigurableSendGridProvider(EmailProvider):
|
||||
|
||||
except ImportError:
|
||||
return False, None, "SendGrid library not installed"
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Configurable SendGrid send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -597,7 +597,7 @@ class ConfigurableMailgunProvider(EmailProvider):
|
||||
return True, result.get("id"), None
|
||||
return False, None, f"Mailgun error: {response.status_code} - {response.text}"
|
||||
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Configurable Mailgun send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -652,7 +652,7 @@ class ConfigurableSESProvider(EmailProvider):
|
||||
|
||||
except ImportError:
|
||||
return False, None, "boto3 library not installed"
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Configurable SES send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -789,7 +789,7 @@ class StoreSendGridProvider(EmailProvider):
|
||||
|
||||
except ImportError:
|
||||
return False, None, "SendGrid library not installed"
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Store SendGrid send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -841,7 +841,7 @@ class StoreMailgunProvider(EmailProvider):
|
||||
return True, result.get("id"), None
|
||||
return False, None, f"Mailgun error: {response.status_code} - {response.text}"
|
||||
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Store Mailgun send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -896,7 +896,7 @@ class StoreSESProvider(EmailProvider):
|
||||
|
||||
except ImportError:
|
||||
return False, None, "boto3 library not installed"
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
logger.error(f"Store SES send error: {e}")
|
||||
return False, None, str(e)
|
||||
|
||||
@@ -1015,7 +1015,7 @@ class EmailService:
|
||||
features = feature_service.get_store_features(self.db, store_id)
|
||||
# Convert to set of feature codes
|
||||
self._feature_cache[store_id] = {f.code for f in features.features}
|
||||
except Exception: # noqa: EXC-003
|
||||
except Exception: # noqa: EXC003
|
||||
self._feature_cache[store_id] = set()
|
||||
|
||||
return feature_code in self._feature_cache[store_id]
|
||||
|
||||
@@ -269,7 +269,7 @@ class StoreEmailSettingsService:
|
||||
|
||||
except (ValidationException, ExternalServiceException):
|
||||
raise # Re-raise domain exceptions
|
||||
except Exception as e: # noqa: EXC-003
|
||||
except Exception as e: # noqa: EXC003
|
||||
error_msg = str(e)
|
||||
settings.mark_verification_failed(error_msg)
|
||||
db.flush()
|
||||
|
||||
Reference in New Issue
Block a user