feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -38,7 +38,7 @@ __all__ = [
|
||||
# =============================================================================
|
||||
|
||||
|
||||
class TaskNotFoundException(ResourceNotFoundException): # noqa: MOD-025
|
||||
class TaskNotFoundException(ResourceNotFoundException): # noqa: MOD025
|
||||
"""Raised when a background task is not found."""
|
||||
|
||||
def __init__(self, task_id: str):
|
||||
@@ -54,7 +54,7 @@ class TaskNotFoundException(ResourceNotFoundException): # noqa: MOD-025
|
||||
# =============================================================================
|
||||
|
||||
|
||||
class CapacitySnapshotNotFoundException(ResourceNotFoundException): # noqa: MOD-025
|
||||
class CapacitySnapshotNotFoundException(ResourceNotFoundException): # noqa: MOD025
|
||||
"""Raised when a capacity snapshot is not found."""
|
||||
|
||||
def __init__(self, snapshot_id: int):
|
||||
@@ -70,7 +70,7 @@ class CapacitySnapshotNotFoundException(ResourceNotFoundException): # noqa: MOD
|
||||
# =============================================================================
|
||||
|
||||
|
||||
class MonitoringServiceException(BusinessLogicException): # noqa: MOD-025
|
||||
class MonitoringServiceException(BusinessLogicException): # noqa: MOD025
|
||||
"""Raised when a monitoring operation fails."""
|
||||
|
||||
def __init__(self, operation: str, reason: str):
|
||||
@@ -108,7 +108,7 @@ class ScanNotFoundException(ResourceNotFoundException):
|
||||
)
|
||||
|
||||
|
||||
class ScanExecutionException(ExternalServiceException): # noqa: MOD-025
|
||||
class ScanExecutionException(ExternalServiceException): # noqa: MOD025
|
||||
"""Raised when architecture scan execution fails."""
|
||||
|
||||
def __init__(self, reason: str):
|
||||
@@ -142,7 +142,7 @@ class ScanParseException(BusinessLogicException):
|
||||
)
|
||||
|
||||
|
||||
class ViolationOperationException(BusinessLogicException): # noqa: MOD-025
|
||||
class ViolationOperationException(BusinessLogicException): # noqa: MOD025
|
||||
"""Raised when a violation operation fails."""
|
||||
|
||||
def __init__(self, operation: str, violation_id: int, reason: str):
|
||||
@@ -157,7 +157,7 @@ class ViolationOperationException(BusinessLogicException): # noqa: MOD-025
|
||||
)
|
||||
|
||||
|
||||
class InvalidViolationStatusException(ValidationException): # noqa: MOD-025
|
||||
class InvalidViolationStatusException(ValidationException): # noqa: MOD025
|
||||
"""Raised when a violation status transition is invalid."""
|
||||
|
||||
def __init__(self, violation_id: int, current_status: str, target_status: str):
|
||||
|
||||
Reference in New Issue
Block a user