feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -17,7 +17,7 @@ class TestUserModel:
|
||||
user = User(
|
||||
email="db_test@example.com",
|
||||
username="dbtest",
|
||||
hashed_password="hashed_password_123", # noqa: SEC-001
|
||||
hashed_password="hashed_password_123", # noqa: SEC001
|
||||
role="user",
|
||||
is_active=True,
|
||||
)
|
||||
@@ -39,7 +39,7 @@ class TestUserModel:
|
||||
user1 = User(
|
||||
email="unique@example.com",
|
||||
username="user1",
|
||||
hashed_password="hash1", # noqa: SEC-001
|
||||
hashed_password="hash1", # noqa: SEC001
|
||||
)
|
||||
db.add(user1)
|
||||
db.commit()
|
||||
@@ -49,7 +49,7 @@ class TestUserModel:
|
||||
user2 = User(
|
||||
email="unique@example.com",
|
||||
username="user2",
|
||||
hashed_password="hash2", # noqa: SEC-001
|
||||
hashed_password="hash2", # noqa: SEC001
|
||||
)
|
||||
db.add(user2)
|
||||
db.commit()
|
||||
@@ -59,7 +59,7 @@ class TestUserModel:
|
||||
user1 = User(
|
||||
email="user1@example.com",
|
||||
username="sameusername",
|
||||
hashed_password="hash1", # noqa: SEC-001
|
||||
hashed_password="hash1", # noqa: SEC001
|
||||
)
|
||||
db.add(user1)
|
||||
db.commit()
|
||||
@@ -69,7 +69,7 @@ class TestUserModel:
|
||||
user2 = User(
|
||||
email="user2@example.com",
|
||||
username="sameusername",
|
||||
hashed_password="hash2", # noqa: SEC-001
|
||||
hashed_password="hash2", # noqa: SEC001
|
||||
)
|
||||
db.add(user2)
|
||||
db.commit()
|
||||
@@ -79,7 +79,7 @@ class TestUserModel:
|
||||
user = User(
|
||||
email="defaults@example.com",
|
||||
username="defaultuser",
|
||||
hashed_password="hash", # noqa: SEC-001
|
||||
hashed_password="hash", # noqa: SEC001
|
||||
)
|
||||
db.add(user)
|
||||
db.commit()
|
||||
@@ -93,7 +93,7 @@ class TestUserModel:
|
||||
user = User(
|
||||
email="optional@example.com",
|
||||
username="optionaluser",
|
||||
hashed_password="hash", # noqa: SEC-001
|
||||
hashed_password="hash", # noqa: SEC001
|
||||
first_name="John",
|
||||
last_name="Doe",
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user