feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1747,7 +1747,7 @@ class ArchitectureValidator:
|
||||
line_number=i,
|
||||
message="Raw number input found - use number_stepper macro for consistent styling",
|
||||
context=stripped[:70],
|
||||
suggestion="{% from 'shared/macros/inputs.html' import number_stepper %}\n{{ number_stepper(model='fieldName', min=1, max=100) }}\nOr add {# noqa: FE-008 #} if this is intentional (e.g., ID field)",
|
||||
suggestion="{% from 'shared/macros/inputs.html' import number_stepper %}\n{{ number_stepper(model='fieldName', min=1, max=100) }}\nOr add {# noqa: FE008 #} if this is intentional (e.g., ID field)",
|
||||
)
|
||||
return # Only report once per file
|
||||
|
||||
@@ -2618,7 +2618,7 @@ class ArchitectureValidator:
|
||||
continue
|
||||
for i, line in enumerate(lines, 1):
|
||||
if re.match(r"\s*except\s+Exception\s*(as\s+\w+)?\s*:", line):
|
||||
if "noqa: EXC-003" in line or "noqa: exc-003" in line:
|
||||
if "noqa: EXC003" in line or "noqa: EXC-003" in line:
|
||||
continue
|
||||
self._add_violation(
|
||||
rule_id="EXC-003",
|
||||
@@ -2628,7 +2628,7 @@ class ArchitectureValidator:
|
||||
line_number=i,
|
||||
message="Broad 'except Exception' catches too many error types",
|
||||
context=line.strip(),
|
||||
suggestion="Catch specific exceptions instead, or add '# noqa: EXC-003' to suppress",
|
||||
suggestion="Catch specific exceptions instead, or add '# noqa: EXC003' to suppress",
|
||||
)
|
||||
|
||||
# EXC-004: Check exception inheritance in exceptions module
|
||||
@@ -4901,7 +4901,7 @@ class ArchitectureValidator:
|
||||
match = exception_class_pattern.match(line)
|
||||
if match:
|
||||
# Check for noqa suppression
|
||||
if "noqa: MOD-025" in line or "noqa: mod-025" in line:
|
||||
if "noqa: MOD025" in line or "noqa: MOD-025" in line:
|
||||
continue
|
||||
exception_classes.append((match.group(1), exc_file, i))
|
||||
|
||||
|
||||
Reference in New Issue
Block a user