feat(validators): add noqa suppression support to security and performance validators
All checks were successful
All checks were successful
- Add centralized _is_noqa_suppressed() to BaseValidator with normalization (accepts both SEC001 and SEC-001 formats for ruff compatibility) - Wire noqa support into all 21 security and 18 performance check functions - Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml - Convert all 280 Python noqa comments to dashless format (ruff-compatible) - Add site/ to IGNORE_PATTERNS (excludes mkdocs build output) - Suppress 152 false positive findings (test passwords, seed data, validator self-references, Apple Wallet SHA1, etc.) - Security: 79 errors → 0, 60 warnings → 0 - Performance: 80 warnings → 77 (3 test script suppressions) - Add proposal doc with noqa inventory and remaining findings recommendations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -357,9 +357,9 @@ class SecurityValidator(BaseValidator):
|
||||
def _check_command_injection(self, file_path: Path, content: str, lines: list[str]):
|
||||
"""SEC-012: Check for command injection vulnerabilities"""
|
||||
patterns = [
|
||||
(r"subprocess.*shell\s*=\s*True", "shell=True in subprocess"), # noqa: SEC-012
|
||||
(r"os\.system\s*\(", "os.system()"), # noqa: SEC-012
|
||||
(r"os\.popen\s*\(", "os.popen()"), # noqa: SEC-012
|
||||
(r"subprocess.*shell\s*=\s*True", "shell=True in subprocess"), # noqa: SEC012
|
||||
(r"os\.system\s*\(", "os.system()"), # noqa: SEC012
|
||||
(r"os\.popen\s*\(", "os.popen()"), # noqa: SEC012
|
||||
]
|
||||
|
||||
for i, line in enumerate(lines, 1):
|
||||
@@ -514,7 +514,7 @@ class SecurityValidator(BaseValidator):
|
||||
def _check_https_enforcement(self, file_path: Path, content: str, lines: list[str]):
|
||||
"""SEC-034: Check for HTTP instead of HTTPS"""
|
||||
for i, line in enumerate(lines, 1):
|
||||
if re.search(r"http://(?!localhost|127\.0\.0\.1|0\.0\.0\.0|\$)", line):
|
||||
if re.search(r"http://(?!localhost|127\.0\.0\.1|0\.0\.0\.0|\$)", line): # noqa: SEC034
|
||||
if self._is_noqa_suppressed(line, "SEC-034") or "example.com" in line or "schemas" in line:
|
||||
continue
|
||||
if "http://www.w3.org" in line:
|
||||
@@ -527,7 +527,7 @@ class SecurityValidator(BaseValidator):
|
||||
line_number=i,
|
||||
message="HTTP URL found - use HTTPS for security",
|
||||
context=line.strip()[:80],
|
||||
suggestion="Replace http:// with https://",
|
||||
suggestion="Replace http:// with https://", # noqa: SEC034
|
||||
)
|
||||
|
||||
def _check_timeout_configuration(self, file_path: Path, content: str, lines: list[str]):
|
||||
@@ -648,7 +648,7 @@ class SecurityValidator(BaseValidator):
|
||||
"""SEC-047: Check for disabled certificate verification"""
|
||||
patterns = [
|
||||
(r"verify\s*=\s*False", "SSL verification disabled"),
|
||||
(r"CERT_NONE", "Certificate verification disabled"),
|
||||
(r"CERT_NONE", "Certificate verification disabled"), # noqa: SEC047
|
||||
(r"check_hostname\s*=\s*False", "Hostname verification disabled"),
|
||||
]
|
||||
|
||||
|
||||
Reference in New Issue
Block a user