feat(validators): add noqa suppression support to security and performance validators
All checks were successful
CI / dependency-scanning (push) Successful in 27s
CI / docs (push) Successful in 35s
CI / ruff (push) Successful in 8s
CI / pytest (push) Successful in 34m22s
CI / validate (push) Successful in 19s
CI / deploy (push) Successful in 2m25s

- Add centralized _is_noqa_suppressed() to BaseValidator with normalization
  (accepts both SEC001 and SEC-001 formats for ruff compatibility)
- Wire noqa support into all 21 security and 18 performance check functions
- Add ruff external config for SEC/PERF/MOD/EXC codes in pyproject.toml
- Convert all 280 Python noqa comments to dashless format (ruff-compatible)
- Add site/ to IGNORE_PATTERNS (excludes mkdocs build output)
- Suppress 152 false positive findings (test passwords, seed data, validator
  self-references, Apple Wallet SHA1, etc.)
- Security: 79 errors → 0, 60 warnings → 0
- Performance: 80 warnings → 77 (3 test script suppressions)
- Add proposal doc with noqa inventory and remaining findings recommendations

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-14 22:56:56 +01:00
parent f84c5d903e
commit 1b8a40f1ff
75 changed files with 404 additions and 310 deletions

View File

@@ -21,16 +21,16 @@ class TestUserLoginSchema:
"""Test valid login data."""
login = UserLogin(
email_or_username="testuser",
password="password123", # noqa: SEC-001
password="password123", # noqa: SEC001
)
assert login.email_or_username == "testuser"
assert login.password == "password123" # noqa: SEC-001
assert login.password == "password123" # noqa: SEC001
def test_login_with_email(self):
"""Test login with email."""
login = UserLogin(
email_or_username="test@example.com",
password="password123", # noqa: SEC-001
password="password123", # noqa: SEC001
)
assert login.email_or_username == "test@example.com"
@@ -38,7 +38,7 @@ class TestUserLoginSchema:
"""Test login with optional store code."""
login = UserLogin(
email_or_username="testuser",
password="password123", # noqa: SEC-001
password="password123", # noqa: SEC001
store_code="STORE001",
)
assert login.store_code == "STORE001"
@@ -47,7 +47,7 @@ class TestUserLoginSchema:
"""Test email_or_username is stripped of whitespace."""
login = UserLogin(
email_or_username=" testuser ",
password="password123", # noqa: SEC-001
password="password123", # noqa: SEC001
)
assert login.email_or_username == "testuser"
@@ -62,7 +62,7 @@ class TestUserCreateSchema:
user = UserCreate(
email="admin@example.com",
username="adminuser",
password="securepass", # noqa: SEC-001
password="securepass", # noqa: SEC001
first_name="Admin",
last_name="User",
role="admin",
@@ -75,7 +75,7 @@ class TestUserCreateSchema:
user = UserCreate(
email="store@example.com",
username="storeuser",
password="securepass", # noqa: SEC-001
password="securepass", # noqa: SEC001
)
assert user.role == "store"
@@ -85,7 +85,7 @@ class TestUserCreateSchema:
UserCreate(
email="test@example.com",
username="testuser",
password="securepass", # noqa: SEC-001
password="securepass", # noqa: SEC001
role="superadmin",
)
assert "role" in str(exc_info.value).lower()
@@ -96,7 +96,7 @@ class TestUserCreateSchema:
UserCreate(
email="test@example.com",
username="ab",
password="securepass", # noqa: SEC-001
password="securepass", # noqa: SEC001
)
assert "username" in str(exc_info.value).lower()
@@ -106,7 +106,7 @@ class TestUserCreateSchema:
UserCreate(
email="test@example.com",
username="testuser",
password="12345", # noqa: SEC-001
password="12345", # noqa: SEC001
)
assert "password" in str(exc_info.value).lower()