perf: fix all 77 performance validator warnings
All checks were successful
CI / ruff (push) Successful in 10s
CI / pytest (push) Successful in 37m52s
CI / validate (push) Successful in 25s
CI / dependency-scanning (push) Successful in 33s
CI / docs (push) Successful in 43s
CI / deploy (push) Successful in 56s

Refactor 10 db.add() loops to db.add_all() in services (menu, admin,
orders, dev_tools), suppress 65 in tests/seeds/complex patterns with
noqa: PERF006, suppress 2 polling interval warnings with noqa: PERF062,
and add JS comment noqa support to base validator.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-15 20:00:06 +01:00
parent 3ec58c1524
commit 1cb659e3a5
39 changed files with 154 additions and 127 deletions

View File

@@ -95,7 +95,7 @@ def test_customer_multiple_addresses(db, test_store, test_customer):
country_iso="LU",
is_default=(i == 0),
)
db.add(address)
db.add(address) # noqa: PERF006
addresses.append(address)
db.commit()
for addr in addresses:

View File

@@ -221,18 +221,18 @@ def multiple_conversations(db, test_admin, test_store_user, test_customer, test_
subject=f"Admin-Store Conversation {i+1}",
store_id=test_store.id,
)
db.add(conv)
db.add(conv) # noqa: PERF006
db.commit()
db.refresh(conv)
db.add(
db.add( # noqa: PERF006
ConversationParticipant(
conversation_id=conv.id,
participant_type=ParticipantType.ADMIN,
participant_id=test_admin.id,
)
)
db.add(
db.add( # noqa: PERF006
ConversationParticipant(
conversation_id=conv.id,
participant_type=ParticipantType.STORE,
@@ -249,11 +249,11 @@ def multiple_conversations(db, test_admin, test_store_user, test_customer, test_
subject=f"Store-Customer Conversation {i+1}",
store_id=test_store.id,
)
db.add(conv)
db.add(conv) # noqa: PERF006
db.commit()
db.refresh(conv)
db.add(
db.add( # noqa: PERF006
ConversationParticipant(
conversation_id=conv.id,
participant_type=ParticipantType.STORE,
@@ -261,7 +261,7 @@ def multiple_conversations(db, test_admin, test_store_user, test_customer, test_
store_id=test_store.id,
)
)
db.add(
db.add( # noqa: PERF006
ConversationParticipant(
conversation_id=conv.id,
participant_type=ParticipantType.CUSTOMER,

View File

@@ -42,7 +42,7 @@ def platform_with_modules(db, test_super_admin):
enabled_by_user_id=test_super_admin.id,
config={},
)
db.add(pm)
db.add(pm) # noqa: PERF006
# Add a disabled module
pm_disabled = PlatformModule(

View File

@@ -235,7 +235,7 @@ class TestMarketplaceImportJobService:
total_processed=0,
error_count=0,
)
db.add(job)
db.add(job) # noqa: PERF006
db.commit()
jobs = self.service.get_import_jobs(db, test_store, test_user, skip=2, limit=2)

View File

@@ -130,7 +130,7 @@ class TestOrderItemExceptionServiceGet:
unit_price=10.00,
total_price=10.00,
)
db.add(order_item)
db.add(order_item) # noqa: PERF006
db.commit()
exception_service.create_exception(
@@ -173,7 +173,7 @@ class TestOrderItemExceptionServiceGet:
unit_price=10.00,
total_price=10.00,
)
db.add(order_item)
db.add(order_item) # noqa: PERF006
order_items.append(order_item)
db.commit()
@@ -423,7 +423,7 @@ class TestOrderItemExceptionServiceAutoMatch:
total_price=10.00,
needs_product_match=True,
)
db.add(order_item)
db.add(order_item) # noqa: PERF006
db.commit()
exception_service.create_exception(
@@ -500,7 +500,7 @@ class TestOrderItemExceptionServiceConfirmation:
unit_price=10.00,
total_price=10.00,
)
db.add(order_item)
db.add(order_item) # noqa: PERF006
db.commit()
exception_service.create_exception(
@@ -538,7 +538,7 @@ class TestOrderItemExceptionServiceBulkResolve:
unit_price=10.00,
total_price=10.00,
)
db.add(order_item)
db.add(order_item) # noqa: PERF006
db.commit()
exception_service.create_exception(

View File

@@ -303,7 +303,7 @@ class TestOrderServiceStats:
order_date=datetime.now(UTC),
**DEFAULT_ADDRESS,
)
db.add(order)
db.add(order) # noqa: PERF006
db.commit()
service = OrderService()