refactor(P6): standardize route variable naming to router

All route files (admin.py, store.py) now export `router` instead of
`admin_router`/`store_router`. Consumer code (definition.py, __init__.py)
imports as `router as admin_router` where distinction is needed.
ModuleDefinition fields remain admin_router/store_router.

64 files changed across all modules. Architecture rules, docs, and
migration plan updated. Added noqa:API001 support to validator for
pre-existing raw dict endpoints now visible with standardized router name.
All 1114 tests pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

app/modules/catalog/routes/api/__init__.py

@@ -16,10 +16,10 @@ __all__ = [
 
 def __getattr__(name: str):
     """Lazy import routers to avoid circular dependencies."""
-    if name == "admin_router":
-        from app.modules.catalog.routes.api.admin import admin_router
-        return admin_router
-    if name == "store_router":
-        from app.modules.catalog.routes.api.store import store_router
-        return store_router
+    if name == "router":
+        from app.modules.catalog.routes.api.admin import router as admin_router
+        return router
+    if name == "router":
+        from app.modules.catalog.routes.api.store import router as store_router
+        return router
     raise AttributeError(f"module {__name__!r} has no attribute {name!r}")

app/modules/catalog/routes/api/admin.py

@@ -34,7 +34,7 @@ from app.modules.catalog.services.store_product_service import store_product_ser
 from app.modules.enums import FrontendType
 from app.modules.tenancy.schemas.auth import UserContext
 
-admin_router = APIRouter(
+router = APIRouter(
     prefix="/store-products",
     dependencies=[Depends(require_module_access("catalog", FrontendType.ADMIN))],
 )
@@ -46,7 +46,7 @@ logger = logging.getLogger(__name__)
 # ============================================================================
 
 
-@admin_router.get("", response_model=StoreProductListResponse)
+@router.get("", response_model=StoreProductListResponse)
 def get_store_products(
     skip: int = Query(0, ge=0),
     limit: int = Query(50, ge=1, le=500),
@@ -83,7 +83,7 @@ def get_store_products(
     )
 
 
-@admin_router.get("/stats", response_model=StoreProductStats)
+@router.get("/stats", response_model=StoreProductStats)
 def get_store_product_stats(
     store_id: int | None = Query(None, description="Filter stats by store ID"),
     db: Session = Depends(get_db),
@@ -94,7 +94,7 @@ def get_store_product_stats(
     return StoreProductStats(**stats)
 
 
-@admin_router.get("/stores", response_model=CatalogStoresResponse)
+@router.get("/stores", response_model=CatalogStoresResponse)
 def get_catalog_stores(
     db: Session = Depends(get_db),
     current_admin: UserContext = Depends(get_current_admin_api),
@@ -104,7 +104,7 @@ def get_catalog_stores(
     return CatalogStoresResponse(stores=[CatalogStore(**v) for v in stores])
 
 
-@admin_router.get("/{product_id}", response_model=StoreProductDetail)
+@router.get("/{product_id}", response_model=StoreProductDetail)
 def get_store_product_detail(
     product_id: int,
     db: Session = Depends(get_db),
@@ -115,7 +115,7 @@ def get_store_product_detail(
     return StoreProductDetail(**product)
 
 
-@admin_router.post("", response_model=StoreProductCreateResponse)
+@router.post("", response_model=StoreProductCreateResponse)
 def create_store_product(
     data: StoreProductCreate,
     db: Session = Depends(get_db),
@@ -132,7 +132,7 @@ def create_store_product(
     )
 
 
-@admin_router.patch("/{product_id}", response_model=StoreProductDetail)
+@router.patch("/{product_id}", response_model=StoreProductDetail)
 def update_store_product(
     product_id: int,
     data: StoreProductUpdate,
@@ -149,7 +149,7 @@ def update_store_product(
     return StoreProductDetail(**product)
 
 
-@admin_router.delete("/{product_id}", response_model=RemoveProductResponse)
+@router.delete("/{product_id}", response_model=RemoveProductResponse)
 def remove_store_product(
     product_id: int,
     db: Session = Depends(get_db),

app/modules/catalog/routes/api/store.py

@@ -32,14 +32,14 @@ from app.modules.catalog.services.store_product_service import store_product_ser
 from app.modules.enums import FrontendType
 from app.modules.tenancy.schemas.auth import UserContext
 
-store_router = APIRouter(
+router = APIRouter(
     prefix="/products",
     dependencies=[Depends(require_module_access("catalog", FrontendType.STORE))],
 )
 logger = logging.getLogger(__name__)
 
 
-@store_router.get("", response_model=ProductListResponse)
+@router.get("", response_model=ProductListResponse)
 def get_store_products(
     skip: int = Query(0, ge=0),
     limit: int = Query(100, ge=1, le=1000),
@@ -74,7 +74,7 @@ def get_store_products(
     )
 
 
-@store_router.get("/{product_id}", response_model=ProductDetailResponse)
+@router.get("/{product_id}", response_model=ProductDetailResponse)
 def get_product_details(
     product_id: int,
     current_user: UserContext = Depends(get_current_store_api),
@@ -88,7 +88,7 @@ def get_product_details(
     return ProductDetailResponse.model_validate(product)
 
 
-@store_router.post("", response_model=ProductResponse)
+@router.post("", response_model=ProductResponse)
 def add_product_to_catalog(
     product_data: ProductCreate,
     current_user: UserContext = Depends(get_current_store_api),
@@ -115,7 +115,7 @@ def add_product_to_catalog(
     return ProductResponse.model_validate(product)
 
 
-@store_router.post("/create", response_model=StoreProductCreateResponse)
+@router.post("/create", response_model=StoreProductCreateResponse)
 def create_product_direct(
     product_data: StoreDirectProductCreate,
     current_user: UserContext = Depends(get_current_store_api),
@@ -159,7 +159,7 @@ def create_product_direct(
     )
 
 
-@store_router.put("/{product_id}", response_model=ProductResponse)
+@router.put("/{product_id}", response_model=ProductResponse)
 def update_product(
     product_id: int,
     product_data: ProductUpdate,
@@ -183,7 +183,7 @@ def update_product(
     return ProductResponse.model_validate(product)
 
 
-@store_router.delete("/{product_id}", response_model=ProductDeleteResponse)
+@router.delete("/{product_id}", response_model=ProductDeleteResponse)
 def remove_product_from_catalog(
     product_id: int,
     current_user: UserContext = Depends(get_current_store_api),
@@ -203,7 +203,7 @@ def remove_product_from_catalog(
     return ProductDeleteResponse(message=f"Product {product_id} removed from catalog")
 
 
-@store_router.post("/from-import/{marketplace_product_id}", response_model=ProductResponse)
+@router.post("/from-import/{marketplace_product_id}", response_model=ProductResponse)
 def publish_from_marketplace(
     marketplace_product_id: int,
     current_user: UserContext = Depends(get_current_store_api),
@@ -234,7 +234,7 @@ def publish_from_marketplace(
     return ProductResponse.model_validate(product)
 
 
-@store_router.put("/{product_id}/toggle-active", response_model=ProductToggleResponse)
+@router.put("/{product_id}/toggle-active", response_model=ProductToggleResponse)
 def toggle_product_active(
     product_id: int,
     current_user: UserContext = Depends(get_current_store_api),
@@ -257,7 +257,7 @@ def toggle_product_active(
     )
 
 
-@store_router.put("/{product_id}/toggle-featured", response_model=ProductToggleResponse)
+@router.put("/{product_id}/toggle-featured", response_model=ProductToggleResponse)
 def toggle_product_featured(
     product_id: int,
     current_user: UserContext = Depends(get_current_store_api),