sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(loyalty): use card_id instead of id in terminal JS

Browse Source 
The terminal's selectedCard comes from CardLookupResponse which uses
card_id field, but the JS was referencing selectedCard.id (undefined).
This caused all terminal transactions to fail with "LoyaltyCard with
identifier 'unknown' not found" instead of processing the transaction
or showing proper PIN validation errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2026-03-23 20:50:20 +01:00
parent 894832c62b
commit 316ec42566
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/modules/loyalty/static/store/js/loyalty-terminal.js
View File

@@ -225,7 +225,7 @@ function storeLoyaltyTerminal() {
loyaltyTerminalLog.info('Adding stamp...'); loyaltyTerminalLog.info('Adding stamp...');
await apiClient.post('/store/loyalty/stamp', { await apiClient.post('/store/loyalty/stamp', {
card_id: this.selectedCard.id, card_id: this.selectedCard.card_id,
staff_pin: this.pinDigits staff_pin: this.pinDigits
}); });
@@ -237,7 +237,7 @@ function storeLoyaltyTerminal() {
loyaltyTerminalLog.info('Redeeming stamps...'); loyaltyTerminalLog.info('Redeeming stamps...');
await apiClient.post('/store/loyalty/stamp/redeem', { await apiClient.post('/store/loyalty/stamp/redeem', {
card_id: this.selectedCard.id, card_id: this.selectedCard.card_id,
staff_pin: this.pinDigits staff_pin: this.pinDigits
}); });
@@ -249,7 +249,7 @@ function storeLoyaltyTerminal() {
loyaltyTerminalLog.info('Earning points...', { amount: this.earnAmount }); loyaltyTerminalLog.info('Earning points...', { amount: this.earnAmount });
const response = await apiClient.post('/store/loyalty/points/earn', { const response = await apiClient.post('/store/loyalty/points/earn', {
card_id: this.selectedCard.id, card_id: this.selectedCard.card_id,
purchase_amount_cents: Math.round(this.earnAmount * 100), purchase_amount_cents: Math.round(this.earnAmount * 100),
staff_pin: this.pinDigits staff_pin: this.pinDigits
}); });
@@ -268,7 +268,7 @@ function storeLoyaltyTerminal() {
loyaltyTerminalLog.info('Redeeming reward...', { reward: reward.name }); loyaltyTerminalLog.info('Redeeming reward...', { reward: reward.name });
await apiClient.post('/store/loyalty/points/redeem', { await apiClient.post('/store/loyalty/points/redeem', {
card_id: this.selectedCard.id, card_id: this.selectedCard.card_id,
reward_id: this.selectedReward, reward_id: this.selectedReward,
staff_pin: this.pinDigits staff_pin: this.pinDigits
}); });
@@ -281,7 +281,7 @@ function storeLoyaltyTerminal() {
// Refresh card data // Refresh card data
async refreshCard() { async refreshCard() {
try { try {
const response = await apiClient.get(`/store/loyalty/cards/${this.selectedCard.id}`); const response = await apiClient.get(`/store/loyalty/cards/${this.selectedCard.card_id}`);
if (response) { if (response) {
this.selectedCard = response; this.selectedCard = response;
} }