sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve all architecture validation warnings

Browse Source 
Service layer:
- Remove db.commit() calls from credentials_service.py (SVC-006)
- Move transaction control to API endpoint level
- Rename client.py -> client_service.py (NAM-002)
- Rename credentials.py -> credentials_service.py (NAM-002)

JavaScript:
- Use centralized logger in admin letzshop.js (JS-001)
- Replace console.log/error with LogConfig logger

Frontend templates:
- Use page_header_flex macro for page header (FE-007)
- Use error_state macro for error display (FE-003)
- Use table_wrapper macro for vendors table (FE-005)
- Use modal macro for configuration and orders modals (FE-004)

All 31 Letzshop tests pass. Architecture validation: 0 errors, 0 warnings.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2025-12-13 12:57:26 +01:00
parent 5bcbd14391
commit 3316894c27
7 changed files with 300 additions and 385 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
static/admin/js/letzshop.js
View File

@@ -3,10 +3,15 @@
* Admin Letzshop management page logic
*/
console.log('[ADMIN LETZSHOP] Loading...');
// Use centralized logger (with fallback)
const letzshopLog = window.LogConfig?.createLogger?.('letzshop') ||
window.LogConfig?.loggers?.letzshop ||
{ info: () => {}, warn: () => {}, error: () => {}, debug: () => {} };
letzshopLog.info('Loading...');
function adminLetzshop() {
console.log('[ADMIN LETZSHOP] adminLetzshop() called');
letzshopLog.info('adminLetzshop() called');
return {
// Inherit base layout state
@@ -65,7 +70,7 @@ function adminLetzshop() {
}
window._adminLetzshopInitialized = true;
console.log('[ADMIN LETZSHOP] Initializing...');
letzshopLog.info('Initializing...');
await this.loadVendors();
},
@@ -93,9 +98,9 @@ function adminLetzshop() {
this.stats.autoSync = this.vendors.filter(v => v.auto_sync_enabled).length;
this.stats.pendingOrders = this.vendors.reduce((sum, v) => sum + (v.pending_orders || 0), 0);
console.log('[ADMIN LETZSHOP] Loaded vendors:', this.vendors.length);
letzshopLog.info('Loaded vendors:', this.vendors.length);
} catch (error) {
console.error('[ADMIN LETZSHOP] Failed to load vendors:', error);
letzshopLog.error('Failed to load vendors:', error);
this.error = error.message || 'Failed to load vendors';
} finally {
this.loading = false;
@@ -134,7 +139,7 @@ function adminLetzshop() {
this.configForm.sync_interval_minutes = response.sync_interval_minutes || 15;
} catch (error) {
if (error.status !== 404) {
console.error('[ADMIN LETZSHOP] Failed to load credentials:', error);
letzshopLog.error('Failed to load credentials:', error);
}
}
}
@@ -171,7 +176,7 @@ function adminLetzshop() {
this.successMessage = 'Configuration saved successfully';
await this.loadVendors();
} catch (error) {
console.error('[ADMIN LETZSHOP] Failed to save config:', error);
letzshopLog.error('Failed to save config:', error);
this.error = error.message || 'Failed to save configuration';
} finally {
this.savingConfig = false;
@@ -193,7 +198,7 @@ function adminLetzshop() {
this.successMessage = 'Configuration removed';
await this.loadVendors();
} catch (error) {
console.error('[ADMIN LETZSHOP] Failed to delete config:', error);
letzshopLog.error('Failed to delete config:', error);
this.error = error.message || 'Failed to remove configuration';
}
setTimeout(() => this.successMessage = '', 5000);
@@ -214,7 +219,7 @@ function adminLetzshop() {
this.error = response.error_details || 'Connection failed';
}
} catch (error) {
console.error('[ADMIN LETZSHOP] Connection test failed:', error);
letzshopLog.error('Connection test failed:', error);
this.error = error.message || 'Connection test failed';
}
setTimeout(() => this.successMessage = '', 5000);
@@ -236,7 +241,7 @@ function adminLetzshop() {
this.error = response.message || 'Sync failed';
}
} catch (error) {
console.error('[ADMIN LETZSHOP] Sync failed:', error);
letzshopLog.error('Sync failed:', error);
this.error = error.message || 'Sync failed';
}
setTimeout(() => this.successMessage = '', 5000);
@@ -255,7 +260,7 @@ function adminLetzshop() {
const response = await apiClient.get(`/admin/letzshop/vendors/${vendor.vendor_id}/orders?limit=100`);
this.vendorOrders = response.orders || [];
} catch (error) {
console.error('[ADMIN LETZSHOP] Failed to load orders:', error);
letzshopLog.error('Failed to load orders:', error);
this.error = error.message || 'Failed to load orders';
} finally {
this.loadingOrders = false;
@@ -273,4 +278,4 @@ function adminLetzshop() {
};
}
console.log('[ADMIN LETZSHOP] Module loaded');
letzshopLog.info('Module loaded');