fix: resolve all 19 architecture validator warnings
- API-004: Add noqa for factory-pattern auth in user_account routes and payments admin - MDL-003: Add from_attributes to MerchantStoreDetailResponse schema - EXC-003: Suppress broad except in merchant_store_service and admin_subscription_service (intentional fallbacks for optional billing module) - NAM-002: Rename onboarding files to *_service.py suffix and update all imports - JS-001: Add file-level noqa for dev-toolbar.js (console interceptor by design) - JS-005: Add init guards to dashboard.js and customer-detail.js - IMPORT-004: Break circular deps by removing orders from inventory requires and marketplace from orders requires; add IMPORT-002 suppression for lazy cross-imports - MOD-025: Remove unused OnboardingAlreadyCompletedException Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -56,7 +56,7 @@ inventory_module = ModuleDefinition(
|
||||
"transaction history, and bulk imports."
|
||||
),
|
||||
version="1.0.0",
|
||||
requires=["catalog", "orders"], # Depends on catalog module for Product model and orders module
|
||||
requires=["catalog"], # Depends on catalog module for Product model
|
||||
# Module-driven permissions
|
||||
permissions=[
|
||||
PermissionDefinition(
|
||||
|
||||
@@ -15,7 +15,7 @@ from sqlalchemy.orm import Session
|
||||
from app.modules.catalog.exceptions import ProductNotFoundException
|
||||
from app.modules.inventory.models.inventory import Inventory
|
||||
from app.modules.inventory.models.inventory_transaction import InventoryTransaction
|
||||
from app.modules.orders.exceptions import OrderNotFoundException
|
||||
from app.modules.orders.exceptions import OrderNotFoundException # IMPORT-002
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
@@ -230,7 +230,9 @@ class InventoryTransactionService:
|
||||
OrderNotFoundException: If order not found or doesn't belong to store
|
||||
"""
|
||||
# Verify order belongs to store
|
||||
from app.modules.orders.services.order_service import order_service
|
||||
from app.modules.orders.services.order_service import (
|
||||
order_service, # IMPORT-002
|
||||
)
|
||||
|
||||
order = order_service.get_order_by_id(db, order_id, store_id=store_id)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user