refactor: move transaction management from services to API endpoints

- Services now use db.flush() instead of db.commit() for database operations
- API endpoints handle transaction commit after service calls
- Remove db.rollback() from services (let exception handlers manage this)
- Ensures consistent transaction boundaries at API layer

This pattern gives API endpoints full control over when to commit,
allowing for better error handling and potential multi-operation transactions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

app/api/v1/admin/code_quality.py

@@ -142,6 +142,7 @@ async def trigger_scan(
     scan = code_quality_service.run_scan(
         db, triggered_by=f"manual:{current_user.username}"
     )
+    db.commit()
 
     return ScanResponse(
         id=scan.id,
@@ -338,6 +339,7 @@ async def assign_violation(
         due_date=request.due_date,
         priority=request.priority,
     )
+    db.commit()
 
     return {
         "id": assignment.id,
@@ -371,6 +373,7 @@ async def resolve_violation(
         resolved_by=current_user.id,
         resolution_note=request.resolution_note,
     )
+    db.commit()
 
     return {
         "id": violation.id,
@@ -402,6 +405,7 @@ async def ignore_violation(
         ignored_by=current_user.id,
         reason=request.reason,
     )
+    db.commit()
 
     return {
         "id": violation.id,
@@ -432,6 +436,7 @@ async def add_comment(
         user_id=current_user.id,
         comment=request.comment,
     )
+    db.commit()
 
     return {
         "id": comment.id,

app/api/v1/admin/content_pages.py

@@ -149,6 +149,7 @@ def create_platform_page(
         display_order=page_data.display_order,
         created_by=current_user.id,
     )
+    db.commit()
 
     return page.to_dict()
 
@@ -211,6 +212,7 @@ def update_page(
         display_order=page_data.display_order,
         updated_by=current_user.id,
     )
+    db.commit()
     return page.to_dict()
 
 
@@ -222,3 +224,4 @@ def delete_page(
 ):
     """Delete a content page."""
     content_page_service.delete_page_or_raise(db, page_id)
+    db.commit()

app/api/v1/admin/marketplace.py

@@ -83,6 +83,7 @@ async def create_marketplace_import_job(
         vendor=vendor,
         user=current_admin,
     )
+    db.commit()
 
     logger.info(
         f"Admin {current_admin.username} created import job {job.id} "

app/api/v1/admin/settings.py

@@ -113,6 +113,7 @@ def create_setting(
             "value_type": setting_data.value_type,
         },
     )
+    db.commit()
 
     return result
 
@@ -140,6 +141,7 @@ def update_setting(
         target_id=key,
         details={"old_value": str(old_value), "new_value": update_data.value},
     )
+    db.commit()
 
     return result
 
@@ -168,6 +170,7 @@ def upsert_setting(
         target_id=setting_data.key,
         details={"category": setting_data.category},
     )
+    db.commit()
 
     return result
 
@@ -204,5 +207,6 @@ def delete_setting(
         target_id=key,
         details={},
     )
+    db.commit()
 
     return {"message": message}

app/api/v1/admin/users.py

@@ -83,6 +83,7 @@ def create_user(
         role=user_data.role,
         current_admin_id=current_admin.id,
     )
+    db.commit()
 
     return UserDetailResponse(
         id=user.id,
@@ -175,6 +176,7 @@ def update_user(
         role=update_data.get("role"),
         is_active=update_data.get("is_active"),
     )
+    db.commit()
 
     return UserDetailResponse(
         id=user.id,
@@ -206,6 +208,7 @@ def toggle_user_status(
         user_id=user_id,
         current_admin_id=current_admin.id,
     )
+    db.commit()
 
     return UserStatusToggleResponse(message=message, is_active=user.is_active)
 
@@ -222,5 +225,6 @@ def delete_user(
         user_id=user_id,
         current_admin_id=current_admin.id,
     )
+    db.commit()
 
     return UserDeleteResponse(message=message)

app/api/v1/admin/vendor_domains.py

@@ -68,6 +68,7 @@ def add_vendor_domain(
     domain = vendor_domain_service.add_domain(
         db=db, vendor_id=vendor_id, domain_data=domain_data
     )
+    db.commit()
 
     return VendorDomainResponse(
         id=domain.id,
@@ -186,6 +187,7 @@ def update_vendor_domain(
     domain = vendor_domain_service.update_domain(
         db=db, domain_id=domain_id, domain_update=domain_update
     )
+    db.commit()
 
     return VendorDomainResponse(
         id=domain.id,
@@ -224,6 +226,7 @@ def delete_vendor_domain(
 
     # Delete domain
     message = vendor_domain_service.delete_domain(db, domain_id)
+    db.commit()
 
     return DomainDeletionResponse(
         message=message, domain=domain_name, vendor_id=vendor_id
@@ -259,6 +262,7 @@ def verify_domain_ownership(
     - 502: DNS query failed
     """
     domain, message = vendor_domain_service.verify_domain(db, domain_id)
+    db.commit()
 
     return DomainVerificationResponse(
         message=message,

app/api/v1/admin/vendor_themes.py

@@ -136,6 +136,7 @@ async def update_vendor_theme(
     # Service handles all validation and raises appropriate exceptions
     # Global exception handler converts them to proper HTTP responses
     theme = vendor_theme_service.update_theme(db, vendor_code, theme_data)
+    db.commit()
     return VendorThemeResponse(**theme.to_dict())
 
 
@@ -185,6 +186,7 @@ async def apply_theme_preset(
     # Raises ThemePresetNotFoundException if preset doesn't exist
     # Global exception handler converts to HTTP 404
     theme = vendor_theme_service.apply_theme_preset(db, vendor_code, preset_name)
+    db.commit()
 
     return ThemePresetResponse(
         message=f"Applied {preset_name} preset successfully",
@@ -226,4 +228,5 @@ async def delete_vendor_theme(
     # Service handles deletion and raises exceptions if needed
     # Global exception handler converts them to proper HTTP responses
     result = vendor_theme_service.delete_theme(db, vendor_code)
+    db.commit()
     return ThemeDeleteResponse(message=result.get("message", "Theme deleted successfully"))

app/api/v1/admin/vendors.py

@@ -50,6 +50,7 @@ def create_vendor(
     The vendor inherits owner and contact information from its parent company.
     """
     vendor = admin_service.create_vendor(db=db, vendor_data=vendor_data)
+    db.commit()
 
     return VendorCreateResponse(
         # Vendor fields
@@ -204,6 +205,7 @@ def update_vendor(
     """
     vendor = vendor_service.get_vendor_by_identifier(db, vendor_identifier)
     vendor = admin_service.update_vendor(db, vendor.id, vendor_update)
+    db.commit()
     return _build_vendor_detail_response(vendor)
 
 
@@ -303,4 +305,5 @@ def delete_vendor(
 
     vendor = vendor_service.get_vendor_by_identifier(db, vendor_identifier)
     message = admin_service.delete_vendor(db, vendor.id)
+    db.commit()
     return {"message": message}