refactor: move transaction management from services to API endpoints

- Services now use db.flush() instead of db.commit() for database operations
- API endpoints handle transaction commit after service calls
- Remove db.rollback() from services (let exception handlers manage this)
- Ensures consistent transaction boundaries at API layer

This pattern gives API endpoints full control over when to commit,
allowing for better error handling and potential multi-operation transactions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

app/api/v1/vendor/content_pages.py

@@ -191,6 +191,7 @@ def create_vendor_page(
         display_order=page_data.display_order,
         created_by=current_user.id,
     )
+    db.commit()
 
     return page.to_dict()
 
@@ -226,6 +227,7 @@ def update_vendor_page(
         display_order=page_data.display_order,
         updated_by=current_user.id,
     )
+    db.commit()
 
     return page.to_dict()
 
@@ -247,3 +249,4 @@ def delete_vendor_page(
 
     # Delete with ownership check in service layer
     content_page_service.delete_vendor_page(db, page_id, current_user.vendor_id)
+    db.commit()

app/api/v1/vendor/inventory.py

@@ -36,7 +36,9 @@ def set_inventory(
     db: Session = Depends(get_db),
 ):
     """Set exact inventory quantity (replaces existing)."""
-    return inventory_service.set_inventory(db, current_user.token_vendor_id, inventory)
+    result = inventory_service.set_inventory(db, current_user.token_vendor_id, inventory)
+    db.commit()
+    return result
 
 
 @router.post("/inventory/adjust", response_model=InventoryResponse)
@@ -46,7 +48,9 @@ def adjust_inventory(
     db: Session = Depends(get_db),
 ):
     """Adjust inventory (positive to add, negative to remove)."""
-    return inventory_service.adjust_inventory(db, current_user.token_vendor_id, adjustment)
+    result = inventory_service.adjust_inventory(db, current_user.token_vendor_id, adjustment)
+    db.commit()
+    return result
 
 
 @router.post("/inventory/reserve", response_model=InventoryResponse)
@@ -56,7 +60,9 @@ def reserve_inventory(
     db: Session = Depends(get_db),
 ):
     """Reserve inventory for an order."""
-    return inventory_service.reserve_inventory(db, current_user.token_vendor_id, reservation)
+    result = inventory_service.reserve_inventory(db, current_user.token_vendor_id, reservation)
+    db.commit()
+    return result
 
 
 @router.post("/inventory/release", response_model=InventoryResponse)
@@ -66,7 +72,9 @@ def release_reservation(
     db: Session = Depends(get_db),
 ):
     """Release reserved inventory (cancel order)."""
-    return inventory_service.release_reservation(db, current_user.token_vendor_id, reservation)
+    result = inventory_service.release_reservation(db, current_user.token_vendor_id, reservation)
+    db.commit()
+    return result
 
 
 @router.post("/inventory/fulfill", response_model=InventoryResponse)
@@ -76,7 +84,9 @@ def fulfill_reservation(
     db: Session = Depends(get_db),
 ):
     """Fulfill reservation (complete order, remove from stock)."""
-    return inventory_service.fulfill_reservation(db, current_user.token_vendor_id, reservation)
+    result = inventory_service.fulfill_reservation(db, current_user.token_vendor_id, reservation)
+    db.commit()
+    return result
 
 
 @router.get("/inventory/product/{product_id}", response_model=ProductInventorySummary)
@@ -119,9 +129,11 @@ def update_inventory(
     db: Session = Depends(get_db),
 ):
     """Update inventory entry."""
-    return inventory_service.update_inventory(
+    result = inventory_service.update_inventory(
         db, current_user.token_vendor_id, inventory_id, inventory_update
     )
+    db.commit()
+    return result
 
 
 @router.delete("/inventory/{inventory_id}", response_model=InventoryMessageResponse)
@@ -132,4 +144,5 @@ def delete_inventory(
 ):
     """Delete inventory entry."""
     inventory_service.delete_inventory(db, current_user.token_vendor_id, inventory_id)
+    db.commit()
     return InventoryMessageResponse(message="Inventory deleted successfully")

app/api/v1/vendor/marketplace.py

@@ -47,6 +47,7 @@ async def import_products_from_marketplace(
     import_job = marketplace_import_job_service.create_import_job(
         db, request, vendor, current_user
     )
+    db.commit()
 
     # Process in background
     background_tasks.add_task(

app/api/v1/vendor/orders.py

@@ -106,6 +106,7 @@ def update_order_status(
         order_id=order_id,
         order_update=order_update,
     )
+    db.commit()
 
     logger.info(
         f"Order {order.order_number} status updated to {order.status} "

app/api/v1/vendor/products.py

@@ -92,6 +92,7 @@ def add_product_to_catalog(
     product = product_service.create_product(
         db=db, vendor_id=current_user.token_vendor_id, product_data=product_data
     )
+    db.commit()
 
     logger.info(
         f"Product {product.id} added to catalog by user {current_user.username} "
@@ -115,6 +116,7 @@ def update_product(
         product_id=product_id,
         product_update=product_data,
     )
+    db.commit()
 
     logger.info(
         f"Product {product_id} updated by user {current_user.username} "
@@ -134,6 +136,7 @@ def remove_product_from_catalog(
     product_service.delete_product(
         db=db, vendor_id=current_user.token_vendor_id, product_id=product_id
     )
+    db.commit()
 
     logger.info(
         f"Product {product_id} removed from catalog by user {current_user.username} "
@@ -161,6 +164,7 @@ def publish_from_marketplace(
     product = product_service.create_product(
         db=db, vendor_id=current_user.token_vendor_id, product_data=product_data
     )
+    db.commit()
 
     logger.info(
         f"Marketplace product {marketplace_product_id} published to catalog "

app/api/v1/vendor/team.py

@@ -150,6 +150,7 @@ def invite_team_member(
             email=invitation.email,
             role_name="staff",
         )
+    db.commit()
 
     logger.info(
         f"Invitation sent: {invitation.email} to {vendor.vendor_code} "
@@ -189,6 +190,7 @@ def accept_invitation(acceptance: InvitationAccept, db: Session = Depends(get_db
         first_name=acceptance.first_name,
         last_name=acceptance.last_name,
     )
+    db.commit()
 
     logger.info(
         f"Invitation accepted: {result['user'].email} "
@@ -272,6 +274,7 @@ def update_team_member(
         new_role_id=update_data.role_id,
         is_active=update_data.is_active,
     )
+    db.commit()
 
     logger.info(
         f"Team member updated: {user_id} in {vendor.vendor_code} "
@@ -307,6 +310,7 @@ def remove_team_member(
     vendor = request.state.vendor
 
     vendor_team_service.remove_team_member(db=db, vendor=vendor, user_id=user_id)
+    db.commit()
 
     logger.info(
         f"Team member removed: {user_id} from {vendor.vendor_code} "
@@ -344,6 +348,8 @@ def bulk_remove_team_members(
             failed_count += 1
             errors.append({"user_id": user_id, "error": str(e)})
 
+    db.commit()
+
     logger.info(
         f"Bulk remove completed: {success_count} removed, {failed_count} failed "
         f"in {vendor.vendor_code}"