sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: PostgreSQL migration compatibility and infrastructure improvements

Browse Source 
Database & Migrations:
- Update all Alembic migrations for PostgreSQL compatibility
- Remove SQLite-specific syntax (AUTOINCREMENT, etc.)
- Add database utility helpers for PostgreSQL operations
- Fix services to use PostgreSQL-compatible queries

Documentation:
- Add comprehensive Docker deployment guide
- Add production deployment documentation
- Add infrastructure architecture documentation
- Update database setup guide for PostgreSQL-only
- Expand troubleshooting guide

Architecture & Validation:
- Add migration.yaml rules for SQL compatibility checking
- Enhance validate_architecture.py with migration validation
- Update architecture rules to validate Alembic migrations

Development:
- Fix duplicate install-all target in Makefile
- Add Celery/Redis validation to install.py script
- Add docker-compose.test.yml for CI testing
- Add squash_migrations.py utility script
- Update tests for PostgreSQL compatibility
- Improve test fixtures in conftest.py

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2026-01-11 17:52:28 +01:00
parent 2792414395
commit 3614d448e4
45 changed files with 3179 additions and 507 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
tests/unit/services/test_email_service.py
View File

@@ -211,20 +211,23 @@ class TestEmailService:
class TestEmailSending:
"""Test suite for email sending functionality."""
@patch("app.services.email_service.get_provider")
@patch("app.services.email_service.settings")
def test_send_raw_success(self, mock_settings, mock_get_provider, db):
@patch("app.services.email_service.get_platform_provider")
@patch("app.services.email_service.get_platform_email_config")
def test_send_raw_success(self, mock_get_config, mock_get_platform_provider, db):
"""Test successful raw email sending."""
# Setup mocks
mock_settings.email_enabled = True
mock_settings.email_from_address = "noreply@test.com"
mock_settings.email_from_name = "Test"
mock_settings.email_reply_to = ""
mock_settings.email_provider = "smtp"
mock_get_config.return_value = {
"enabled": True,
"debug": False,
"provider": "smtp",
"from_email": "noreply@test.com",
"from_name": "Test",
"reply_to": "",
}
mock_provider = MagicMock()
mock_provider.send.return_value = (True, "msg-123", None)
mock_get_provider.return_value = mock_provider
mock_get_platform_provider.return_value = mock_provider
service = EmailService(db)
@@ -240,20 +243,23 @@ class TestEmailSending:
assert log.subject == "Test Subject"
assert log.provider_message_id == "msg-123"
@patch("app.services.email_service.get_provider")
@patch("app.services.email_service.settings")
def test_send_raw_failure(self, mock_settings, mock_get_provider, db):
@patch("app.services.email_service.get_platform_provider")
@patch("app.services.email_service.get_platform_email_config")
def test_send_raw_failure(self, mock_get_config, mock_get_platform_provider, db):
"""Test failed raw email sending."""
# Setup mocks
mock_settings.email_enabled = True
mock_settings.email_from_address = "noreply@test.com"
mock_settings.email_from_name = "Test"
mock_settings.email_reply_to = ""
mock_settings.email_provider = "smtp"
mock_get_config.return_value = {
"enabled": True,
"debug": False,
"provider": "smtp",
"from_email": "noreply@test.com",
"from_name": "Test",
"reply_to": "",
}
mock_provider = MagicMock()
mock_provider.send.return_value = (False, None, "Connection refused")
mock_get_provider.return_value = mock_provider
mock_get_platform_provider.return_value = mock_provider
service = EmailService(db)
@@ -287,9 +293,9 @@ class TestEmailSending:
assert log.status == EmailStatus.FAILED.value
assert "disabled" in log.error_message.lower()
@patch("app.services.email_service.get_provider")
@patch("app.services.email_service.settings")
def test_send_template_success(self, mock_settings, mock_get_provider, db):
@patch("app.services.email_service.get_platform_provider")
@patch("app.services.email_service.get_platform_email_config")
def test_send_template_success(self, mock_get_config, mock_get_platform_provider, db):
"""Test successful template email sending."""
# Create test template
template = EmailTemplate(
@@ -305,15 +311,18 @@ class TestEmailSending:
db.commit()
# Setup mocks
mock_settings.email_enabled = True
mock_settings.email_from_address = "noreply@test.com"
mock_settings.email_from_name = "Test"
mock_settings.email_reply_to = ""
mock_settings.email_provider = "smtp"
mock_get_config.return_value = {
"enabled": True,
"debug": False,
"provider": "smtp",
"from_email": "noreply@test.com",
"from_name": "Test",
"reply_to": "",
}
mock_provider = MagicMock()
mock_provider.send.return_value = (True, "msg-456", None)
mock_get_provider.return_value = mock_provider
mock_get_platform_provider.return_value = mock_provider
service = EmailService(db)
@@ -331,7 +340,8 @@ class TestEmailSending:
assert log.template_code == "test_send_template"
assert log.subject == "Hello John"
# Cleanup
# Cleanup - delete log first due to FK constraint
db.delete(log)
db.delete(template)
db.commit()
@@ -531,7 +541,8 @@ class TestSignupWelcomeEmail:
yield template
# Cleanup
# Cleanup - delete email logs referencing this template first
db.query(EmailLog).filter(EmailLog.template_id == template.id).delete()
db.delete(template)
db.commit()
@@ -575,20 +586,23 @@ class TestSignupWelcomeEmail:
for var in required_vars:
assert var in template.variables_list, f"Missing variable: {var}"
@patch("app.services.email_service.get_provider")
@patch("app.services.email_service.settings")
def test_welcome_email_send(self, mock_settings, mock_get_provider, db, welcome_template):
@patch("app.services.email_service.get_platform_provider")
@patch("app.services.email_service.get_platform_email_config")
def test_welcome_email_send(self, mock_get_config, mock_get_platform_provider, db, welcome_template, test_vendor, test_user):
"""Test sending welcome email."""
# Setup mocks
mock_settings.email_enabled = True
mock_settings.email_from_address = "noreply@test.com"
mock_settings.email_from_name = "Test"
mock_settings.email_reply_to = ""
mock_settings.email_provider = "smtp"
mock_get_config.return_value = {
"enabled": True,
"debug": False,
"provider": "smtp",
"from_email": "noreply@test.com",
"from_name": "Test",
"reply_to": "",
}
mock_provider = MagicMock()
mock_provider.send.return_value = (True, "welcome-msg-123", None)
mock_get_provider.return_value = mock_provider
mock_get_platform_provider.return_value = mock_provider
service = EmailService(db)
@@ -606,8 +620,8 @@ class TestSignupWelcomeEmail:
"trial_days": 30,
"tier_name": "Essential",
},
vendor_id=1,
user_id=1,
vendor_id=test_vendor.id,
user_id=test_user.id,
related_type="signup",
)

12
tests/unit/services/test_onboarding_service.py
View File

@@ -218,17 +218,13 @@ class TestOnboardingServiceStep1:
service = OnboardingService(db)
# First create the onboarding record
onboarding = VendorOnboarding(
vendor_id=99999,
status=OnboardingStatus.NOT_STARTED.value,
)
db.add(onboarding)
db.flush()
# Use a vendor_id that doesn't exist
# The service should check vendor exists before doing anything
non_existent_vendor_id = 999999
with pytest.raises(VendorNotFoundException):
service.complete_company_profile(
vendor_id=99999,
vendor_id=non_existent_vendor_id,
default_language="en",
dashboard_language="en",
)