fix(lint): restore noqa directives and register custom codes with ruff
Some checks failed
CI / ruff (push) Failing after 7s
CI / pytest (push) Failing after 1s
CI / architecture (push) Failing after 8s
CI / dependency-scanning (push) Successful in 26s
CI / audit (push) Successful in 9s
CI / docs (push) Has been skipped

Reverts the noqa: removal — the architecture validators (SVC-006,
SEC-034, MOD-004, API-007) use these to skip known-safe violations.
Added ruff lint.external config so ruff treats them as valid codes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-12 23:21:27 +01:00
parent 1b24269ef1
commit 3a264c0a39
27 changed files with 41 additions and 37 deletions

View File

@@ -1336,7 +1336,7 @@ class EmailService:
related_id=related_id,
)
self.db.add(log)
self.db.commit() # SVC-006 - Email logs are side effects, commit immediately
self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately
return log
# Inject branding variables if requested
@@ -1471,7 +1471,7 @@ class EmailService:
if not email_enabled:
log.status = EmailStatus.FAILED.value
log.error_message = "Email sending is disabled"
self.db.commit() # SVC-006 - Email logs are side effects, commit immediately
self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately
logger.info(f"Email sending disabled, skipping: {to_email}")
return log
@@ -1497,7 +1497,7 @@ class EmailService:
log.mark_failed(error or "Unknown error")
logger.error(f"Email failed to {to_email}: {error}")
self.db.commit() # SVC-006 - Email logs are side effects, commit immediately
self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately
return log