chore: add module exceptions, locales, and fix architecture warnings
- Create module-specific exceptions for cart, catalog, checkout - Add locales (en, de, fr, lb) for cart, catalog, checkout modules - Add missing lb.json for existing module locales - Add noqa comments for legitimate MOD-004 violations (core services) - Fix validator to use correct lb.json locale code (was lu.json) - Add noqa support for MOD-004 rule in validator Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
139
app/modules/checkout/exceptions.py
Normal file
139
app/modules/checkout/exceptions.py
Normal file
@@ -0,0 +1,139 @@
|
||||
# app/modules/checkout/exceptions.py
|
||||
"""
|
||||
Checkout module exceptions.
|
||||
|
||||
Module-specific exceptions for the checkout process.
|
||||
"""
|
||||
|
||||
from app.exceptions.base import (
|
||||
BusinessLogicException,
|
||||
ResourceNotFoundException,
|
||||
ValidationException,
|
||||
)
|
||||
|
||||
|
||||
class CheckoutValidationException(ValidationException):
|
||||
"""Raised when checkout data validation fails."""
|
||||
|
||||
def __init__(
|
||||
self,
|
||||
message: str = "Checkout validation failed",
|
||||
field: str | None = None,
|
||||
details: dict | None = None,
|
||||
):
|
||||
super().__init__(
|
||||
message=message,
|
||||
field=field,
|
||||
details=details,
|
||||
)
|
||||
self.error_code = "CHECKOUT_VALIDATION_FAILED"
|
||||
|
||||
|
||||
class CheckoutSessionNotFoundException(ResourceNotFoundException):
|
||||
"""Raised when checkout session is not found."""
|
||||
|
||||
def __init__(self, session_id: str):
|
||||
super().__init__(
|
||||
resource_type="CheckoutSession",
|
||||
identifier=session_id,
|
||||
message=f"Checkout session '{session_id}' not found",
|
||||
error_code="CHECKOUT_SESSION_NOT_FOUND",
|
||||
)
|
||||
|
||||
|
||||
class CheckoutSessionExpiredException(BusinessLogicException):
|
||||
"""Raised when checkout session has expired."""
|
||||
|
||||
def __init__(self, session_id: str):
|
||||
super().__init__(
|
||||
message="Checkout session has expired",
|
||||
error_code="CHECKOUT_SESSION_EXPIRED",
|
||||
details={"session_id": session_id},
|
||||
)
|
||||
|
||||
|
||||
class EmptyCheckoutException(ValidationException):
|
||||
"""Raised when trying to checkout with empty cart."""
|
||||
|
||||
def __init__(self):
|
||||
super().__init__(
|
||||
message="Cannot checkout with an empty cart",
|
||||
details={},
|
||||
)
|
||||
self.error_code = "EMPTY_CHECKOUT"
|
||||
|
||||
|
||||
class PaymentRequiredException(BusinessLogicException):
|
||||
"""Raised when payment is required but not provided."""
|
||||
|
||||
def __init__(self, order_total: float):
|
||||
super().__init__(
|
||||
message="Payment is required to complete this order",
|
||||
error_code="PAYMENT_REQUIRED",
|
||||
details={"order_total": order_total},
|
||||
)
|
||||
|
||||
|
||||
class PaymentFailedException(BusinessLogicException):
|
||||
"""Raised when payment processing fails."""
|
||||
|
||||
def __init__(self, reason: str, details: dict | None = None):
|
||||
super().__init__(
|
||||
message=f"Payment failed: {reason}",
|
||||
error_code="PAYMENT_FAILED",
|
||||
details={"reason": reason, **(details or {})},
|
||||
)
|
||||
|
||||
|
||||
class InvalidShippingAddressException(ValidationException):
|
||||
"""Raised when shipping address is invalid or missing."""
|
||||
|
||||
def __init__(self, message: str = "Invalid shipping address", details: dict | None = None):
|
||||
super().__init__(
|
||||
message=message,
|
||||
field="shipping_address",
|
||||
details=details,
|
||||
)
|
||||
self.error_code = "INVALID_SHIPPING_ADDRESS"
|
||||
|
||||
|
||||
class ShippingMethodNotAvailableException(BusinessLogicException):
|
||||
"""Raised when selected shipping method is not available."""
|
||||
|
||||
def __init__(self, shipping_method: str, reason: str | None = None):
|
||||
message = f"Shipping method '{shipping_method}' is not available"
|
||||
if reason:
|
||||
message += f": {reason}"
|
||||
super().__init__(
|
||||
message=message,
|
||||
error_code="SHIPPING_METHOD_NOT_AVAILABLE",
|
||||
details={"shipping_method": shipping_method, "reason": reason},
|
||||
)
|
||||
|
||||
|
||||
class CheckoutInventoryException(BusinessLogicException):
|
||||
"""Raised when inventory check fails during checkout."""
|
||||
|
||||
def __init__(self, product_id: int, available: int, requested: int):
|
||||
super().__init__(
|
||||
message=f"Insufficient inventory for product {product_id}",
|
||||
error_code="CHECKOUT_INVENTORY_ERROR",
|
||||
details={
|
||||
"product_id": product_id,
|
||||
"available_quantity": available,
|
||||
"requested_quantity": requested,
|
||||
},
|
||||
)
|
||||
|
||||
|
||||
__all__ = [
|
||||
"CheckoutInventoryException",
|
||||
"CheckoutSessionExpiredException",
|
||||
"CheckoutSessionNotFoundException",
|
||||
"CheckoutValidationException",
|
||||
"EmptyCheckoutException",
|
||||
"InvalidShippingAddressException",
|
||||
"PaymentFailedException",
|
||||
"PaymentRequiredException",
|
||||
"ShippingMethodNotAvailableException",
|
||||
]
|
||||
42
app/modules/checkout/locales/de.json
Normal file
42
app/modules/checkout/locales/de.json
Normal file
@@ -0,0 +1,42 @@
|
||||
{
|
||||
"title": "Kasse",
|
||||
"description": "Bestellabwicklung und Zahlungsabwicklung",
|
||||
"session": {
|
||||
"title": "Checkout-Sitzung",
|
||||
"expired": "Sitzung abgelaufen",
|
||||
"invalid": "Ungültige Sitzung"
|
||||
},
|
||||
"shipping": {
|
||||
"title": "Lieferadresse",
|
||||
"select_address": "Adresse auswählen",
|
||||
"add_new": "Neue Adresse hinzufügen",
|
||||
"method": "Versandart",
|
||||
"select_method": "Versandart auswählen",
|
||||
"not_available": "Für diese Adresse nicht verfügbar"
|
||||
},
|
||||
"payment": {
|
||||
"title": "Zahlung",
|
||||
"method": "Zahlungsmethode",
|
||||
"required": "Zahlung erforderlich",
|
||||
"failed": "Zahlung fehlgeschlagen"
|
||||
},
|
||||
"order": {
|
||||
"summary": "Bestellübersicht",
|
||||
"subtotal": "Zwischensumme",
|
||||
"shipping": "Versand",
|
||||
"tax": "MwSt.",
|
||||
"total": "Gesamtsumme",
|
||||
"place_order": "Bestellung aufgeben"
|
||||
},
|
||||
"validation": {
|
||||
"empty_cart": "Warenkorb ist leer",
|
||||
"invalid_address": "Ungültige Lieferadresse",
|
||||
"insufficient_inventory": "Unzureichender Bestand"
|
||||
},
|
||||
"messages": {
|
||||
"order_placed": "Bestellung erfolgreich aufgegeben",
|
||||
"checkout_failed": "Checkout fehlgeschlagen",
|
||||
"session_expired": "Ihre Sitzung ist abgelaufen",
|
||||
"inventory_error": "Einige Artikel sind nicht mehr verfügbar"
|
||||
}
|
||||
}
|
||||
42
app/modules/checkout/locales/en.json
Normal file
42
app/modules/checkout/locales/en.json
Normal file
@@ -0,0 +1,42 @@
|
||||
{
|
||||
"title": "Checkout",
|
||||
"description": "Order checkout and payment processing",
|
||||
"session": {
|
||||
"title": "Checkout Session",
|
||||
"expired": "Session expired",
|
||||
"invalid": "Invalid session"
|
||||
},
|
||||
"shipping": {
|
||||
"title": "Shipping Address",
|
||||
"select_address": "Select Address",
|
||||
"add_new": "Add New Address",
|
||||
"method": "Shipping Method",
|
||||
"select_method": "Select Shipping Method",
|
||||
"not_available": "Not available for this address"
|
||||
},
|
||||
"payment": {
|
||||
"title": "Payment",
|
||||
"method": "Payment Method",
|
||||
"required": "Payment required",
|
||||
"failed": "Payment failed"
|
||||
},
|
||||
"order": {
|
||||
"summary": "Order Summary",
|
||||
"subtotal": "Subtotal",
|
||||
"shipping": "Shipping",
|
||||
"tax": "Tax",
|
||||
"total": "Total",
|
||||
"place_order": "Place Order"
|
||||
},
|
||||
"validation": {
|
||||
"empty_cart": "Cart is empty",
|
||||
"invalid_address": "Invalid shipping address",
|
||||
"insufficient_inventory": "Insufficient inventory"
|
||||
},
|
||||
"messages": {
|
||||
"order_placed": "Order placed successfully",
|
||||
"checkout_failed": "Checkout failed",
|
||||
"session_expired": "Your session has expired",
|
||||
"inventory_error": "Some items are no longer available"
|
||||
}
|
||||
}
|
||||
42
app/modules/checkout/locales/fr.json
Normal file
42
app/modules/checkout/locales/fr.json
Normal file
@@ -0,0 +1,42 @@
|
||||
{
|
||||
"title": "Caisse",
|
||||
"description": "Traitement des commandes et des paiements",
|
||||
"session": {
|
||||
"title": "Session de paiement",
|
||||
"expired": "Session expirée",
|
||||
"invalid": "Session invalide"
|
||||
},
|
||||
"shipping": {
|
||||
"title": "Adresse de livraison",
|
||||
"select_address": "Sélectionner une adresse",
|
||||
"add_new": "Ajouter une nouvelle adresse",
|
||||
"method": "Mode de livraison",
|
||||
"select_method": "Sélectionner un mode de livraison",
|
||||
"not_available": "Non disponible pour cette adresse"
|
||||
},
|
||||
"payment": {
|
||||
"title": "Paiement",
|
||||
"method": "Mode de paiement",
|
||||
"required": "Paiement requis",
|
||||
"failed": "Paiement échoué"
|
||||
},
|
||||
"order": {
|
||||
"summary": "Récapitulatif de commande",
|
||||
"subtotal": "Sous-total",
|
||||
"shipping": "Livraison",
|
||||
"tax": "TVA",
|
||||
"total": "Total",
|
||||
"place_order": "Passer la commande"
|
||||
},
|
||||
"validation": {
|
||||
"empty_cart": "Le panier est vide",
|
||||
"invalid_address": "Adresse de livraison invalide",
|
||||
"insufficient_inventory": "Stock insuffisant"
|
||||
},
|
||||
"messages": {
|
||||
"order_placed": "Commande passée avec succès",
|
||||
"checkout_failed": "Échec du paiement",
|
||||
"session_expired": "Votre session a expiré",
|
||||
"inventory_error": "Certains articles ne sont plus disponibles"
|
||||
}
|
||||
}
|
||||
42
app/modules/checkout/locales/lb.json
Normal file
42
app/modules/checkout/locales/lb.json
Normal file
@@ -0,0 +1,42 @@
|
||||
{
|
||||
"title": "Keess",
|
||||
"description": "Bestellungsofwécklung a Bezuelung",
|
||||
"session": {
|
||||
"title": "Checkout-Sëtzung",
|
||||
"expired": "Sëtzung ofgelaf",
|
||||
"invalid": "Ongëlteg Sëtzung"
|
||||
},
|
||||
"shipping": {
|
||||
"title": "Liwweradress",
|
||||
"select_address": "Adress auswielen",
|
||||
"add_new": "Nei Adress derbäisetzen",
|
||||
"method": "Liwwermethod",
|
||||
"select_method": "Liwwermethod auswielen",
|
||||
"not_available": "Net verfügbar fir dës Adress"
|
||||
},
|
||||
"payment": {
|
||||
"title": "Bezuelung",
|
||||
"method": "Bezuelungsmethod",
|
||||
"required": "Bezuelung erfuerderlech",
|
||||
"failed": "Bezuelung feelgeschloen"
|
||||
},
|
||||
"order": {
|
||||
"summary": "Bestelliwwersiicht",
|
||||
"subtotal": "Zwëschesumm",
|
||||
"shipping": "Liwwerung",
|
||||
"tax": "MwSt.",
|
||||
"total": "Gesamtsumm",
|
||||
"place_order": "Bestellung opginn"
|
||||
},
|
||||
"validation": {
|
||||
"empty_cart": "Kuerf ass eidel",
|
||||
"invalid_address": "Ongëlteg Liwweradress",
|
||||
"insufficient_inventory": "Net genuch Bestand"
|
||||
},
|
||||
"messages": {
|
||||
"order_placed": "Bestellung erfollegräich opginn",
|
||||
"checkout_failed": "Checkout feelgeschloen",
|
||||
"session_expired": "Är Sëtzung ass ofgelaf",
|
||||
"inventory_error": "E puer Artikelen sinn net méi verfügbar"
|
||||
}
|
||||
}
|
||||
@@ -28,7 +28,7 @@ from app.modules.checkout.schemas import (
|
||||
from app.modules.checkout.services import checkout_service
|
||||
from app.modules.customers.schemas import CustomerContext
|
||||
from app.modules.orders.services import order_service
|
||||
from app.services.email_service import EmailService
|
||||
from app.services.email_service import EmailService # noqa: MOD-004 - Core email service
|
||||
from middleware.vendor_context import require_vendor_context
|
||||
from models.database.vendor import Vendor
|
||||
from app.modules.orders.schemas import OrderCreate, OrderResponse
|
||||
|
||||
Reference in New Issue
Block a user