fix(loyalty): resolve critical production readiness issues
Some checks failed
Some checks failed
- Add pessimistic locking (SELECT FOR UPDATE) on card write operations to prevent race conditions in stamp_service and points_service - Replace 16 console.log/error/warn calls with LogConfig.createLogger() in 3 storefront JS files (dashboard, history, enroll) - Delete all stale lu.json locale files across 8 modules (lb is the correct ISO 639-1 code for Luxembourgish) - Update architecture rules and docs to reference lb.json not lu.json - Add production-readiness.md report for loyalty module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -140,6 +140,9 @@ class PointsService:
|
||||
"total_points_earned": card.total_points_earned,
|
||||
}
|
||||
|
||||
# Re-fetch with row lock to prevent concurrent modification
|
||||
card = card_service.get_card_for_update(db, card.id)
|
||||
|
||||
# Add points
|
||||
now = datetime.now(UTC)
|
||||
card.points_balance += points_earned
|
||||
@@ -271,6 +274,9 @@ class PointsService:
|
||||
raise StaffPinRequiredException()
|
||||
verified_pin = pin_service.verify_pin(db, program.id, staff_pin, store_id=store_id)
|
||||
|
||||
# Re-fetch with row lock to prevent concurrent modification
|
||||
card = card_service.get_card_for_update(db, card.id)
|
||||
|
||||
# Redeem points
|
||||
now = datetime.now(UTC)
|
||||
card.points_balance -= points_required
|
||||
@@ -419,6 +425,9 @@ class PointsService:
|
||||
"points_balance": card.points_balance,
|
||||
}
|
||||
|
||||
# Re-fetch with row lock to prevent concurrent modification
|
||||
card = card_service.get_card_for_update(db, card.id)
|
||||
|
||||
# Void the points (can reduce balance below what was earned)
|
||||
now = datetime.now(UTC)
|
||||
actual_voided = min(points_to_void, card.points_balance)
|
||||
@@ -503,6 +512,9 @@ class PointsService:
|
||||
if program.require_staff_pin and staff_pin and store_id:
|
||||
verified_pin = pin_service.verify_pin(db, program.id, staff_pin, store_id=store_id)
|
||||
|
||||
# Re-fetch with row lock to prevent concurrent modification
|
||||
card = card_service.get_card_for_update(db, card.id)
|
||||
|
||||
# Apply adjustment
|
||||
now = datetime.now(UTC)
|
||||
card.points_balance += points_delta
|
||||
|
||||
Reference in New Issue
Block a user