fix: redirect to login on authorization errors for HTML pages

When a session times out or user accesses pages with wrong role,
redirect to login instead of showing error page.

Changes:
- Extend exception handler to redirect on 403 errors with auth codes
- Add tests for HTML page auth redirect behavior

Error codes that trigger redirect:
- ADMIN_REQUIRED, INSUFFICIENT_PERMISSIONS, USER_NOT_ACTIVE
- VENDOR_ACCESS_DENIED, UNAUTHORIZED_VENDOR_ACCESS
- VENDOR_OWNER_ONLY, INSUFFICIENT_VENDOR_PERMISSIONS
- CUSTOMER_NOT_AUTHORIZED

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2025-12-24 22:19:43 +01:00
parent e456ae3c73
commit 4ba911e263
2 changed files with 94 additions and 3 deletions

View File

@@ -31,12 +31,41 @@ def setup_exception_handlers(app):
async def custom_exception_handler(request: Request, exc: WizamartException):
"""Handle custom exceptions with context-aware rendering."""
# Special handling for 401 on HTML page requests (redirect to login)
if exc.status_code == 401 and _is_html_page_request(request):
# Special handling for auth errors on HTML page requests (redirect to login)
# This includes both:
# - 401 errors: Not authenticated (expired/invalid token)
# - 403 errors with specific auth codes: Authenticated but wrong context
# (e.g., vendor token on admin page, role mismatch)
# These codes indicate the user should re-authenticate with correct credentials
auth_redirect_error_codes = {
# Auth-level errors
"ADMIN_REQUIRED",
"INSUFFICIENT_PERMISSIONS",
"USER_NOT_ACTIVE",
# Vendor-level auth errors
"VENDOR_ACCESS_DENIED",
"UNAUTHORIZED_VENDOR_ACCESS",
"VENDOR_OWNER_ONLY",
"INSUFFICIENT_VENDOR_PERMISSIONS",
# Customer-level auth errors
"CUSTOMER_NOT_AUTHORIZED",
}
should_redirect = (
_is_html_page_request(request)
and (
exc.status_code == 401
or (exc.status_code == 403 and exc.error_code in auth_redirect_error_codes)
)
)
if should_redirect:
logger.info(
f"401 on HTML page request - redirecting to login: {request.url.path}",
f"Auth error on HTML page request - redirecting to login: {request.url.path}",
extra={
"path": request.url.path,
"status_code": exc.status_code,
"error_code": exc.error_code,
"accept": request.headers.get("accept", ""),
"method": request.method,
},