shop product refactoring

app/exceptions/__init__.py

@@ -55,12 +55,15 @@ from .shop import (
     ShopNotVerifiedException,
     UnauthorizedShopAccessException,
     InvalidShopDataException,
-    ShopProductAlreadyExistsException,
-    ShopProductNotFoundException,
     MaxShopsReachedException,
     ShopValidationException,
 )
 
+from .product import (
+    ProductNotFoundException,
+    ProductAlreadyExistsException,
+)
+
 from .marketplace_import_job import (
     MarketplaceImportException,
     ImportJobNotFoundException,
@@ -131,11 +134,13 @@ __all__ = [
     "ShopNotVerifiedException",
     "UnauthorizedShopAccessException",
     "InvalidShopDataException",
-    "ShopProductAlreadyExistsException",
-    "ShopProductNotFoundException",
     "MaxShopsReachedException",
     "ShopValidationException",
 
+    # Product exceptions
+    "ProductAlreadyExistsException",
+    "ProductNotFoundException",
+
     # Marketplace import exceptions
     "MarketplaceImportException",
     "ImportJobNotFoundException",

app/exceptions/product.py

@@ -0,0 +1,34 @@
+# app/exceptions/shop.py
+"""
+Shop management specific exceptions.
+"""
+
+from .base import (
+    ResourceNotFoundException,
+    ConflictException
+)
+
+class ProductAlreadyExistsException(ConflictException):
+    """Raised when trying to add a product that already exists in shop."""
+
+    def __init__(self, shop_code: str, marketplace_product_id: str):
+        super().__init__(
+            message=f"MarketplaceProduct '{marketplace_product_id}' already exists in shop '{shop_code}'",
+            error_code="PRODUCT_ALREADY_EXISTS",
+            details={
+                "shop_code": shop_code,
+                "marketplace_product_id": marketplace_product_id,
+            },
+        )
+
+
+class ProductNotFoundException(ResourceNotFoundException):
+    """Raised when a shop product relationship is not found."""
+
+    def __init__(self, shop_code: str, marketplace_product_id: str):
+        super().__init__(
+            resource_type="ShopProduct",
+            identifier=f"{shop_code}/{marketplace_product_id}",
+            message=f"MarketplaceProduct '{marketplace_product_id}' not found in shop '{shop_code}'",
+            error_code="PRODUCT_NOT_FOUND",
+        )

app/exceptions/shop.py

@@ -95,32 +95,6 @@ class InvalidShopDataException(ValidationException):
         self.error_code = "INVALID_SHOP_DATA"
 
 
-class ShopProductAlreadyExistsException(ConflictException):
-    """Raised when trying to add a product that already exists in shop."""
-
-    def __init__(self, shop_code: str, marketplace_product_id: str):
-        super().__init__(
-            message=f"MarketplaceProduct '{marketplace_product_id}' already exists in shop '{shop_code}'",
-            error_code="SHOP_PRODUCT_ALREADY_EXISTS",
-            details={
-                "shop_code": shop_code,
-                "marketplace_product_id": marketplace_product_id,
-            },
-        )
-
-
-class ShopProductNotFoundException(ResourceNotFoundException):
-    """Raised when a shop product relationship is not found."""
-
-    def __init__(self, shop_code: str, marketplace_product_id: str):
-        super().__init__(
-            resource_type="ShopProduct",
-            identifier=f"{shop_code}/{marketplace_product_id}",
-            message=f"MarketplaceProduct '{marketplace_product_id}' not found in shop '{shop_code}'",
-            error_code="SHOP_PRODUCT_NOT_FOUND",
-        )
-
-
 class MaxShopsReachedException(BusinessLogicException):
     """Raised when user tries to create more shops than allowed."""