sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: admin sidebar missing on /admin/my-menu page
Some checks failed
CI / ruff (push) Successful in 9s
Details
CI / pytest (push) Failing after 46m46s
Details
CI / validate (push) Successful in 23s
Details
CI / dependency-scanning (push) Successful in 29s
Details
CI / docs (push) Has been skipped
Details
CI / deploy (push) Has been skipped
Details

Browse Source 
Rename loadMenuConfig() → loadUserMenuConfig() in adminMyMenuConfig()
to avoid shadowing the sidebar's loadMenuConfig() inherited from data()
via the spread operator. The name collision caused the sidebar to never
populate its menuData, showing only the fallback "Dashboard" link.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2026-02-27 12:40:46 +01:00
parent 2b29867093
commit 4ebd419987
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/modules/core/static/admin/js/my-menu-config.js
View File

@@ -1,16 +1,10 @@
// static/admin/js/my-menu-config.js // static/admin/js/my-menu-config.js
// Personal menu configuration for super admins // Personal menu configuration for super admins
// //
// TODO: BUG - Sidebar menu doesn't update immediately after changes. // NOTE: The page method for loading user menu config is named loadUserMenuConfig()
// User must navigate to another page to see the updated menu. // (not loadMenuConfig()) to avoid shadowing the sidebar's loadMenuConfig() inherited
// The issue is that Alpine.js doesn't properly track reactivity for the // from data() via the spread operator. Shadowing caused the sidebar to never populate
// visibleMenuItems Set in init-alpine.js. Attempted fixes with reloadSidebarMenu() // its menuData, resulting in a blank sidebar on this page.
// and window.location.reload() didn't work reliably.
// Possible solutions:
// 1. Convert visibleMenuItems from Set to plain object for better Alpine reactivity
// 2. Use Alpine.store() for shared state between components
// 3. Dispatch a custom event that the sidebar listens for
// 4. Force re-render of sidebar component after changes
const myMenuConfigLog = window.LogConfig?.loggers?.myMenuConfig || window.LogConfig?.createLogger?.('myMenuConfig') || console; const myMenuConfigLog = window.LogConfig?.loggers?.myMenuConfig || window.LogConfig?.createLogger?.('myMenuConfig') || console;
@@ -71,7 +65,7 @@ function adminMyMenuConfig() {
try { try {
// Load core translations for confirmations // Load core translations for confirmations
await I18n.loadModule('core'); await I18n.loadModule('core');
await this.loadMenuConfig(); await this.loadUserMenuConfig();
myMenuConfigLog.info('=== MY MENU CONFIG PAGE INITIALIZED ==='); myMenuConfigLog.info('=== MY MENU CONFIG PAGE INITIALIZED ===');
} catch (error) { } catch (error) {
myMenuConfigLog.error('Failed to initialize my menu config page:', error); myMenuConfigLog.error('Failed to initialize my menu config page:', error);
@@ -82,10 +76,10 @@ function adminMyMenuConfig() {
async refresh() { async refresh() {
this.error = null; this.error = null;
this.successMessage = null; this.successMessage = null;
await this.loadMenuConfig(); await this.loadUserMenuConfig();
}, },
async loadMenuConfig() { async loadUserMenuConfig() {
this.loading = true; this.loading = true;
this.error = null; this.error = null;