sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add explicit type annotations to service methods

Browse Source 
Add Optional type annotations to nullable parameters in service methods
to fix architecture validation warnings.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2025-12-13 14:51:10 +01:00
parent 2f770709fd
commit 5778bdaa69
4 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
models/schema/product.py
View File

@@ -11,7 +11,7 @@ class ProductCreate(BaseModel):
marketplace_product_id: int = Field(
..., description="MarketplaceProduct ID to add to vendor catalog"
)
product_id: str | None = Field(None, description="Vendor's internal SKU/product ID")
vendor_sku: str | None = Field(None, description="Vendor's internal SKU")
price: float | None = Field(None, ge=0)
sale_price: float | None = Field(None, ge=0)
currency: str | None = None
@@ -23,7 +23,7 @@ class ProductCreate(BaseModel):
class ProductUpdate(BaseModel):
product_id: str | None = None
vendor_sku: str | None = None
price: float | None = Field(None, ge=0)
sale_price: float | None = Field(None, ge=0)
currency: str | None = None
@@ -41,7 +41,7 @@ class ProductResponse(BaseModel):
id: int
vendor_id: int
marketplace_product: MarketplaceProductResponse
product_id: str | None
vendor_sku: str | None
price: float | None
sale_price: float | None
currency: str | None