feat(loyalty): restructure program CRUD by interface
Some checks failed
CI / ruff (push) Successful in 10s
CI / pytest (push) Failing after 45m49s
CI / validate (push) Successful in 23s
CI / dependency-scanning (push) Successful in 29s
CI / docs (push) Has been skipped
CI / deploy (push) Has been skipped

Move program CRUD from store to merchant/admin interfaces.
Store becomes view-only for program config while merchant gets
full CRUD and admin gets override capabilities.

Merchant portal:
- New API endpoints (GET/POST/PATCH/DELETE /program)
- New settings page with create/edit/delete form
- Overview page now has Create/Edit Program buttons
- Settings menu item added to sidebar

Admin portal:
- New CRUD endpoints (create for merchant, update, delete)
- New activate/deactivate program endpoints
- Programs list has edit and toggle buttons per row
- Merchant detail has create/delete/toggle program actions

Store portal:
- Removed POST/PATCH /program endpoints (now read-only)
- Removed settings page route and template
- Terminal, cards, stats, enroll unchanged

Tests: 112 passed (58 new) covering merchant API, admin CRUD,
store endpoint removal, and program service unit tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-25 13:32:20 +01:00
parent d648c921b7
commit 6b46a78e72
22 changed files with 1616 additions and 113 deletions

View File

@@ -36,6 +36,7 @@ function adminLoyaltyMerchantDetail() {
// State
loading: false,
error: null,
showDeleteModal: false,
// Initialize
async init() {
@@ -176,6 +177,67 @@ function adminLoyaltyMerchantDetail() {
}
},
// Create a default program for this merchant
async createProgram() {
try {
const data = {
loyalty_type: 'points',
points_per_euro: 1,
welcome_bonus_points: 0,
minimum_redemption_points: 100,
card_name: this.merchant?.name ? this.merchant.name + ' Loyalty' : 'Loyalty Program',
is_active: true
};
const response = await apiClient.post(`/admin/loyalty/merchants/${this.merchantId}/program`, data);
this.program = response;
Utils.showToast('Loyalty program created', 'success');
loyaltyMerchantDetailLog.info('Program created for merchant', this.merchantId);
// Reload stats
await this.loadStats();
} catch (error) {
Utils.showToast(`Failed to create program: ${error.message}`, 'error');
loyaltyMerchantDetailLog.error('Failed to create program:', error);
}
},
// Toggle program active/inactive
async toggleActive() {
if (!this.program) return;
const action = this.program.is_active ? 'deactivate' : 'activate';
try {
const response = await apiClient.post(`/admin/loyalty/programs/${this.program.id}/${action}`);
this.program.is_active = response.is_active;
Utils.showToast(`Program ${action}d successfully`, 'success');
loyaltyMerchantDetailLog.info(`Program ${action}d`);
} catch (error) {
Utils.showToast(`Failed to ${action} program: ${error.message}`, 'error');
loyaltyMerchantDetailLog.error(`Failed to ${action} program:`, error);
}
},
// Show delete confirmation
confirmDeleteProgram() {
this.showDeleteModal = true;
},
// Delete the program
async deleteProgram() {
if (!this.program) return;
try {
await apiClient.delete(`/admin/loyalty/programs/${this.program.id}`);
this.program = null;
this.showDeleteModal = false;
Utils.showToast('Loyalty program deleted', 'success');
loyaltyMerchantDetailLog.info('Program deleted');
// Reload stats
await this.loadStats();
} catch (error) {
Utils.showToast(`Failed to delete program: ${error.message}`, 'error');
loyaltyMerchantDetailLog.error('Failed to delete program:', error);
this.showDeleteModal = false;
}
},
// Format date for display
formatDate(dateString) {
if (!dateString) return 'N/A';

View File

@@ -232,6 +232,20 @@ function adminLoyaltyPrograms() {
}
},
// Toggle program active/inactive
async toggleProgramActive(program) {
const action = program.is_active ? 'deactivate' : 'activate';
try {
const response = await apiClient.post(`/admin/loyalty/programs/${program.id}/${action}`);
program.is_active = response.is_active;
Utils.showToast(`Program ${action}d successfully`, 'success');
loyaltyProgramsLog.info(`Program ${program.id} ${action}d`);
} catch (error) {
Utils.showToast(`Failed to ${action} program: ${error.message}`, 'error');
loyaltyProgramsLog.error(`Failed to ${action} program:`, error);
}
},
// Format date for display
formatDate(dateString) {
if (!dateString) return 'N/A';

View File

@@ -1,9 +1,9 @@
// app/modules/loyalty/static/store/js/loyalty-settings.js
// app/modules/loyalty/static/merchant/js/loyalty-settings.js
// noqa: js-006 - async init pattern is safe, loadData has try/catch
const loyaltySettingsLog = window.LogConfig.loggers.loyaltySettings || window.LogConfig.createLogger('loyaltySettings');
function storeLoyaltySettings() {
function merchantLoyaltySettings() {
return {
...data(),
currentPage: 'loyalty-settings',
@@ -22,22 +22,18 @@ function storeLoyaltySettings() {
loading: false,
saving: false,
deleting: false,
error: null,
isNewProgram: false,
showDeleteModal: false,
async init() {
loyaltySettingsLog.info('=== LOYALTY SETTINGS PAGE INITIALIZING ===');
if (window._loyaltySettingsInitialized) return;
window._loyaltySettingsInitialized = true;
// IMPORTANT: Call parent init first to set storeCode from URL
const parentInit = data().init;
if (parentInit) {
await parentInit.call(this);
}
loyaltySettingsLog.info('=== MERCHANT LOYALTY SETTINGS PAGE INITIALIZING ===');
if (window._merchantLoyaltySettingsInitialized) return;
window._merchantLoyaltySettingsInitialized = true;
await this.loadSettings();
loyaltySettingsLog.info('=== LOYALTY SETTINGS PAGE INITIALIZATION COMPLETE ===');
loyaltySettingsLog.info('=== MERCHANT LOYALTY SETTINGS PAGE INITIALIZATION COMPLETE ===');
},
async loadSettings() {
@@ -45,7 +41,7 @@ function storeLoyaltySettings() {
this.error = null;
try {
const response = await apiClient.get('/store/loyalty/program');
const response = await apiClient.get('/merchants/loyalty/program');
if (response) {
this.settings = {
loyalty_type: response.loyalty_type || 'points',
@@ -86,10 +82,10 @@ function storeLoyaltySettings() {
let response;
if (this.isNewProgram) {
response = await apiClient.post('/store/loyalty/program', this.settings);
response = await apiClient.post('/merchants/loyalty/program', this.settings);
this.isNewProgram = false;
} else {
response = await apiClient.patch('/store/loyalty/program', this.settings);
response = await apiClient.patch('/merchants/loyalty/program', this.settings);
}
Utils.showToast('Settings saved successfully', 'success');
@@ -102,6 +98,28 @@ function storeLoyaltySettings() {
}
},
confirmDelete() {
this.showDeleteModal = true;
},
async deleteProgram() {
this.deleting = true;
try {
await apiClient.delete('/merchants/loyalty/program');
Utils.showToast('Loyalty program deleted', 'success');
loyaltySettingsLog.info('Program deleted');
// Redirect to overview
window.location.href = '/merchants/loyalty/overview';
} catch (error) {
Utils.showToast(`Failed to delete: ${error.message}`, 'error');
loyaltySettingsLog.error('Delete failed:', error);
} finally {
this.deleting = false;
this.showDeleteModal = false;
}
},
addReward() {
this.settings.points_rewards.push({
id: `reward_${Date.now()}`,
@@ -121,4 +139,4 @@ function storeLoyaltySettings() {
if (!window.LogConfig.loggers.loyaltySettings) {
window.LogConfig.loggers.loyaltySettings = window.LogConfig.createLogger('loyaltySettings');
}
loyaltySettingsLog.info('Loyalty settings module loaded');
loyaltySettingsLog.info('Merchant loyalty settings module loaded');