From 78e098d4daaa0af2fecb4c2cd128601a73432081 Mon Sep 17 00:00:00 2001
From: Samir Boulahtit <samir.boulahtit@wizard.lu>
Date: Mon, 18 May 2026 23:37:41 +0200
Subject: [PATCH] fix(static-assets): also cache-bust raw /static/ refs (fonts
 CSS, store JS)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The initial codemod only converted url_for('*_static', path='*.js'|'*.css')
patterns and missed 19 raw /static/... references — most importantly the
shared/fonts/inter.css link in all four base.html files, plus a handful
of <script src="/static/modules/..."> tags in marketplace/billing/orders
templates and the storefront login/register/forgot/reset pages.

Result: deploys now flip ?v=<sha> on every JS/CSS asset that reaches the
browser, not just the ones loaded via url_for().

FE-024 rule extended to flag src="/static/...*.(js|css)" patterns too.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .architecture-rules/frontend.yaml                        | 9 ++++++---
 app/modules/billing/templates/billing/store/billing.html | 2 +-
 .../templates/customers/storefront/forgot-password.html  | 2 +-
 .../customers/templates/customers/storefront/login.html  | 2 +-
 .../templates/customers/storefront/register.html         | 2 +-
 .../templates/customers/storefront/reset-password.html   | 2 +-
 .../templates/marketplace/store/letzshop.html            | 2 +-
 .../templates/marketplace/store/marketplace.html         | 2 +-
 .../templates/marketplace/store/onboarding.html          | 2 +-
 app/modules/orders/templates/orders/store/invoices.html  | 2 +-
 app/modules/tenancy/templates/tenancy/admin/login.html   | 2 +-
 .../tenancy/templates/tenancy/admin/select-platform.html | 2 +-
 .../tenancy/templates/tenancy/merchant/login.html        | 2 +-
 .../templates/tenancy/store/invitation-accept.html       | 2 +-
 app/modules/tenancy/templates/tenancy/store/login.html   | 2 +-
 app/templates/admin/base.html                            | 2 +-
 app/templates/merchant/base.html                         | 2 +-
 app/templates/platform/base.html                         | 2 +-
 app/templates/shared/macros/richtext.html                | 2 +-
 app/templates/store/base.html                            | 2 +-
 scripts/validate/validate_architecture.py                | 3 ++-
 21 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/.architecture-rules/frontend.yaml b/.architecture-rules/frontend.yaml
index 48e64cf8..a31b3a7a 100644
--- a/.architecture-rules/frontend.yaml
+++ b/.architecture-rules/frontend.yaml
@@ -937,7 +937,7 @@ frontend_component_rules:
         - "{% from 'shared/macros/shop/trust-badges.html' import"
 
   - id: "FE-024"
-    name: "Use static_v() for JS/CSS, not raw url_for()"
+    name: "Use static_v() for JS/CSS, not raw url_for() or /static/ paths"
     severity: "warning"
     description: |
       Static .js and .css URLs must use the cache-busting `static_v()` helper
@@ -948,17 +948,20 @@ frontend_component_rules:
       WRONG (browser keeps cached file after deploy):
         <script src="{{ url_for('foo_static', path='admin/js/app.js') }}"></script>
         <link href="{{ url_for('foo_static', path='admin/css/site.css') }}" rel="stylesheet">
+        <link href="/static/shared/fonts/inter.css" rel="stylesheet">
 
       RIGHT:
         <script src="{{ static_v(request, 'foo_static', path='admin/js/app.js') }}"></script>
         <link href="{{ static_v(request, 'foo_static', path='admin/css/site.css') }}" rel="stylesheet">
+        <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet">
 
-      Images, fonts, and JSON locale files are intentionally out of scope —
-      keep using `url_for()` for those.
+      Images, fonts (other than .css), and JSON locale files are intentionally
+      out of scope — keep using `url_for()` for those.
     pattern:
       file_pattern: "app/**/templates/**/*.html"
       anti_patterns:
         - "url_for\\(\\s*['\"]\\w+_static['\"]\\s*,\\s*path=['\"][^'\"]+\\.(?:js|css)['\"]"
+        - "(?:src|href)=['\"]/static/[^'\"]+\\.(?:js|css)['\"]"
       exceptions:
         - "base.html"
         - "partials/"
diff --git a/app/modules/billing/templates/billing/store/billing.html b/app/modules/billing/templates/billing/store/billing.html
index 6760ba2d..3e1bca8b 100644
--- a/app/modules/billing/templates/billing/store/billing.html
+++ b/app/modules/billing/templates/billing/store/billing.html
@@ -405,5 +405,5 @@
 {% endblock %}
 
 {% block extra_scripts %}
-<script defer src="/static/modules/billing/store/js/billing.js"></script>
+<script defer src="{{ static_v(request, 'billing_static', path='store/js/billing.js') }}"></script>
 {% endblock %}
diff --git a/app/modules/customers/templates/customers/storefront/forgot-password.html b/app/modules/customers/templates/customers/storefront/forgot-password.html
index 7856da98..b059351a 100644
--- a/app/modules/customers/templates/customers/storefront/forgot-password.html
+++ b/app/modules/customers/templates/customers/storefront/forgot-password.html
@@ -7,7 +7,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>{{ _("auth.forgot_password") }} - {{ store.name }}</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     {# CRITICAL: Inject theme CSS variables #}
diff --git a/app/modules/customers/templates/customers/storefront/login.html b/app/modules/customers/templates/customers/storefront/login.html
index ca7d7435..b927ba92 100644
--- a/app/modules/customers/templates/customers/storefront/login.html
+++ b/app/modules/customers/templates/customers/storefront/login.html
@@ -6,7 +6,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Customer Login - {{ store.name }}</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     {# CRITICAL: Inject theme CSS variables #}
diff --git a/app/modules/customers/templates/customers/storefront/register.html b/app/modules/customers/templates/customers/storefront/register.html
index 47187e06..06caebab 100644
--- a/app/modules/customers/templates/customers/storefront/register.html
+++ b/app/modules/customers/templates/customers/storefront/register.html
@@ -7,7 +7,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Create Account - {{ store.name }}</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     {# CRITICAL: Inject theme CSS variables #}
diff --git a/app/modules/customers/templates/customers/storefront/reset-password.html b/app/modules/customers/templates/customers/storefront/reset-password.html
index 8fac428a..15bab870 100644
--- a/app/modules/customers/templates/customers/storefront/reset-password.html
+++ b/app/modules/customers/templates/customers/storefront/reset-password.html
@@ -7,7 +7,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Reset Password - {{ store.name }}</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     {# CRITICAL: Inject theme CSS variables #}
diff --git a/app/modules/marketplace/templates/marketplace/store/letzshop.html b/app/modules/marketplace/templates/marketplace/store/letzshop.html
index 90230849..e8eb6f62 100644
--- a/app/modules/marketplace/templates/marketplace/store/letzshop.html
+++ b/app/modules/marketplace/templates/marketplace/store/letzshop.html
@@ -9,7 +9,7 @@
 {% block alpine_data %}storeLetzshop(){% endblock %}
 
 {% block extra_scripts %}
-<script defer src="/static/modules/marketplace/store/js/letzshop.js"></script>
+<script defer src="{{ static_v(request, 'marketplace_static', path='store/js/letzshop.js') }}"></script>
 {% endblock %}
 
 {% block content %}
diff --git a/app/modules/marketplace/templates/marketplace/store/marketplace.html b/app/modules/marketplace/templates/marketplace/store/marketplace.html
index b1258e98..31eb1239 100644
--- a/app/modules/marketplace/templates/marketplace/store/marketplace.html
+++ b/app/modules/marketplace/templates/marketplace/store/marketplace.html
@@ -11,7 +11,7 @@
 {% block alpine_data %}storeMarketplace(){% endblock %}
 
 {% block extra_scripts %}
-<script defer src="/static/modules/marketplace/store/js/marketplace.js"></script>
+<script defer src="{{ static_v(request, 'marketplace_static', path='store/js/marketplace.js') }}"></script>
 {% endblock %}
 
 {% block content %}
diff --git a/app/modules/marketplace/templates/marketplace/store/onboarding.html b/app/modules/marketplace/templates/marketplace/store/onboarding.html
index d0efa7cc..49c445d4 100644
--- a/app/modules/marketplace/templates/marketplace/store/onboarding.html
+++ b/app/modules/marketplace/templates/marketplace/store/onboarding.html
@@ -6,7 +6,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Welcome to Orion - Setup Your Account</title>
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
     <link rel="stylesheet" href="{{ url_for('static', path='store/css/tailwind.output.css') }}" />
     <style>
diff --git a/app/modules/orders/templates/orders/store/invoices.html b/app/modules/orders/templates/orders/store/invoices.html
index 45b2fdee..03e2e6fe 100644
--- a/app/modules/orders/templates/orders/store/invoices.html
+++ b/app/modules/orders/templates/orders/store/invoices.html
@@ -10,7 +10,7 @@
 {% block alpine_data %}storeInvoices(){% endblock %}
 
 {% block extra_scripts %}
-<script defer src="/static/modules/billing/store/js/invoices.js"></script>
+<script defer src="{{ static_v(request, 'billing_static', path='store/js/invoices.js') }}"></script>
 {% endblock %}
 
 {% block content %}
diff --git a/app/modules/tenancy/templates/tenancy/admin/login.html b/app/modules/tenancy/templates/tenancy/admin/login.html
index 45d5b19a..ec771b17 100644
--- a/app/modules/tenancy/templates/tenancy/admin/login.html
+++ b/app/modules/tenancy/templates/tenancy/admin/login.html
@@ -6,7 +6,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Admin Login - Multi-Tenant Platform</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
     <link rel="stylesheet" href="{{ url_for('static', path='admin/css/tailwind.output.css') }}" />
     <!-- Flag Icons CSS (for language selector) with local fallback -->
diff --git a/app/modules/tenancy/templates/tenancy/admin/select-platform.html b/app/modules/tenancy/templates/tenancy/admin/select-platform.html
index d38aa9dd..ccd4ba66 100644
--- a/app/modules/tenancy/templates/tenancy/admin/select-platform.html
+++ b/app/modules/tenancy/templates/tenancy/admin/select-platform.html
@@ -6,7 +6,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Select Platform - Admin Panel</title>
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
     <link rel="stylesheet" href="{{ url_for('static', path='admin/css/tailwind.output.css') }}" />
     <style>[x-cloak] { display: none !important; }</style>
diff --git a/app/modules/tenancy/templates/tenancy/merchant/login.html b/app/modules/tenancy/templates/tenancy/merchant/login.html
index 7e3e974c..90b298df 100644
--- a/app/modules/tenancy/templates/tenancy/merchant/login.html
+++ b/app/modules/tenancy/templates/tenancy/merchant/login.html
@@ -7,7 +7,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Merchant Login - Orion</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
     <link rel="stylesheet" href="{{ url_for('static', path='merchant/css/tailwind.output.css') }}" />
     <!-- Flag Icons CSS (for language selector) with local fallback -->
diff --git a/app/modules/tenancy/templates/tenancy/store/invitation-accept.html b/app/modules/tenancy/templates/tenancy/store/invitation-accept.html
index fb938a82..63a5ac73 100644
--- a/app/modules/tenancy/templates/tenancy/store/invitation-accept.html
+++ b/app/modules/tenancy/templates/tenancy/store/invitation-accept.html
@@ -6,7 +6,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Accept Invitation - {{ invitation.store_name if invitation else 'Store' }}</title>
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
     <link rel="stylesheet" href="{{ url_for('static', path='store/css/tailwind.output.css') }}" />
     <style>
diff --git a/app/modules/tenancy/templates/tenancy/store/login.html b/app/modules/tenancy/templates/tenancy/store/login.html
index 8549e14e..0def3de6 100644
--- a/app/modules/tenancy/templates/tenancy/store/login.html
+++ b/app/modules/tenancy/templates/tenancy/store/login.html
@@ -6,7 +6,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Store Login - Multi-Tenant Platform</title>
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
     <link rel="stylesheet" href="{{ url_for('static', path='store/css/tailwind.output.css') }}" />
     <style>
diff --git a/app/templates/admin/base.html b/app/templates/admin/base.html
index 142baf43..f1afe564 100644
--- a/app/templates/admin/base.html
+++ b/app/templates/admin/base.html
@@ -7,7 +7,7 @@
     <title>{% block title %}Admin Panel{% endblock %} - Multi-Tenant Platform</title>
 
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     <!-- Tailwind CSS v4 (built locally via standalone CLI) -->
diff --git a/app/templates/merchant/base.html b/app/templates/merchant/base.html
index 7d7abfec..3e4dbf4d 100644
--- a/app/templates/merchant/base.html
+++ b/app/templates/merchant/base.html
@@ -7,7 +7,7 @@
     <title>{% block title %}Merchant Portal{% endblock %} - Orion</title>
 
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     <!-- Tailwind CSS v4 (built locally via standalone CLI) -->
diff --git a/app/templates/platform/base.html b/app/templates/platform/base.html
index 5aab7c03..768fd95b 100644
--- a/app/templates/platform/base.html
+++ b/app/templates/platform/base.html
@@ -37,7 +37,7 @@
     </style>
 
     {# Fonts: Local fallback + Google Fonts #}
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     {# Tailwind CSS v4 (built locally via standalone CLI) #}
diff --git a/app/templates/shared/macros/richtext.html b/app/templates/shared/macros/richtext.html
index 4bbd3dae..99e1ab4b 100644
--- a/app/templates/shared/macros/richtext.html
+++ b/app/templates/shared/macros/richtext.html
@@ -35,7 +35,7 @@
 <link
     rel="stylesheet"
     href="https://cdn.jsdelivr.net/npm/quill@2.0.2/dist/quill.snow.css"
-    onerror="this.onerror=null; this.href='/static/shared/css/store/quill.snow.css';"
+    onerror="this.onerror=null; this.href='{{ static_v(request, 'static', path='shared/css/store/quill.snow.css') }}';"
 />
 <!-- Quill Dark Mode Overrides -->
 <style>
diff --git a/app/templates/store/base.html b/app/templates/store/base.html
index fdc3d007..39d1d25d 100644
--- a/app/templates/store/base.html
+++ b/app/templates/store/base.html
@@ -8,7 +8,7 @@
     <title>{% block title %}Store Panel{% endblock %} - {{ store.name if store else 'Multi-Tenant Platform' }}</title>
 
     <!-- Fonts: Local fallback + Google Fonts -->
-    <link href="/static/shared/fonts/inter.css" rel="stylesheet" />
+    <link href="{{ static_v(request, 'static', path='shared/fonts/inter.css') }}" rel="stylesheet" />
     <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700;800&display=swap" rel="stylesheet" />
 
     <!-- Tailwind CSS v4 (built locally via standalone CLI) -->
diff --git a/scripts/validate/validate_architecture.py b/scripts/validate/validate_architecture.py
index ac670560..5203a763 100755
--- a/scripts/validate/validate_architecture.py
+++ b/scripts/validate/validate_architecture.py
@@ -1798,7 +1798,8 @@ class ArchitectureValidator:
                 return  # Only report once per file
 
     _STATIC_V_PATTERN = re.compile(
-        r"""url_for\(\s*['"]\w+_static['"]\s*,\s*path=['"][^'"]+\.(?:js|css)['"]\s*\)""",
+        r"""url_for\(\s*['"]\w+_static['"]\s*,\s*path=['"][^'"]+\.(?:js|css)['"]\s*\)"""
+        r"""|(?:src|href)=['"]/static/[^'"]+\.(?:js|css)['"]""",
         re.IGNORECASE,
     )