refactor(arch): eliminate all cross-module model imports in service layer
Some checks failed
CI / ruff (push) Successful in 9s
CI / docs (push) Has been cancelled
CI / deploy (push) Has been cancelled
CI / validate (push) Has been cancelled
CI / dependency-scanning (push) Has been cancelled
CI / pytest (push) Has been cancelled

Enforce MOD-025/MOD-026 rules: zero top-level cross-module model imports
remain in any service file. All 66 files migrated using deferred import
patterns (method-body, _get_model() helpers, instance-cached self._Model)
and new cross-module service methods in tenancy. Documentation updated
with Pattern 6 (deferred imports), migration plan marked complete, and
violations status reflects 84→0 service-layer violations.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-27 06:13:15 +01:00
parent e3a52f6536
commit 86e85a98b8
66 changed files with 2242 additions and 1295 deletions

View File

@@ -6,6 +6,8 @@ Business logic for store theme management.
Handles theme CRUD operations, preset application, and validation.
"""
from __future__ import annotations
import logging
import re
@@ -29,7 +31,6 @@ from app.modules.cms.services.theme_presets import (
get_preset_preview,
)
from app.modules.tenancy.exceptions import StoreNotFoundException
from app.modules.tenancy.models import Store
logger = logging.getLogger(__name__)
@@ -67,9 +68,9 @@ class StoreThemeService:
Raises:
StoreNotFoundException: If store not found
"""
store = (
db.query(Store).filter(Store.store_code == store_code.upper()).first()
)
from app.modules.tenancy.services.store_service import store_service
store = store_service.get_store_by_code(db, store_code)
if not store:
self.logger.warning(f"Store not found: {store_code}")