refactor: remove backward compatibility code for pre-launch baseline

Clean up accumulated backward-compat shims, deprecated wrappers, unused
aliases, and legacy code across the codebase. Since the platform is not
live yet, this establishes a clean baseline.

Changes:
- Delete deprecated middleware/context.py (RequestContext, get_request_context)
- Remove unused factory get_store_email_settings_service()
- Remove deprecated pagination_full macro, /admin/platform-homepage route
- Remove ConversationResponse, InvoiceSettings* unprefixed aliases
- Simplify celery_config.py (remove empty LEGACY_TASK_MODULES)
- Standardize billing exceptions: *Error aliases → *Exception names
- Consolidate duplicate TierNotFoundError/FeatureNotFoundError classes
- Remove deprecated is_admin_request() from Store/PlatformContextManager
- Remove is_platform_default field, MediaUploadResponse legacy flat fields
- Remove MediaItemResponse.url alias, update JS to use file_url
- Update all affected tests and documentation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

middleware/context.py

@@ -1,100 +0,0 @@
-# middleware/context.py
-"""
-DEPRECATED: This module is deprecated in favor of middleware/frontend_type.py
-
-The RequestContext enum and ContextMiddleware have been replaced by:
-- FrontendType enum (app/modules/enums.py)
-- FrontendTypeMiddleware (middleware/frontend_type.py)
-- FrontendDetector (app/core/frontend_detector.py)
-
-This file is kept for backwards compatibility during the migration period.
-All new code should use FrontendType and FrontendTypeMiddleware instead.
-
-Migration guide:
-- RequestContext.API -> Check with FrontendDetector.is_api_request()
-- RequestContext.ADMIN -> FrontendType.ADMIN
-- RequestContext.STORE_DASHBOARD -> FrontendType.STORE
-- RequestContext.STOREFRONT -> FrontendType.STOREFRONT
-- RequestContext.FALLBACK -> FrontendType.PLATFORM (or handle API separately)
-
-- get_request_context(request) -> get_frontend_type(request)
-- request.state.context_type -> request.state.frontend_type
-"""
-
-import logging
-import warnings
-from enum import Enum
-
-from fastapi import Request
-
-from app.modules.enums import FrontendType
-from middleware.frontend_type import get_frontend_type
-
-logger = logging.getLogger(__name__)
-
-
-class RequestContext(str, Enum):
-    """
-    DEPRECATED: Use FrontendType enum instead.
-
-    Request context types for the application.
-    This enum is kept for backwards compatibility.
-
-    Migration:
-    - API -> Use FrontendDetector.is_api_request() + FrontendType
-    - ADMIN -> FrontendType.ADMIN
-    - STORE_DASHBOARD -> FrontendType.STORE
-    - STOREFRONT -> FrontendType.STOREFRONT
-    - FALLBACK -> FrontendType.PLATFORM
-    """
-
-    API = "api"
-    ADMIN = "admin"
-    STORE_DASHBOARD = "store"
-    STOREFRONT = "storefront"
-    FALLBACK = "fallback"
-
-
-def get_request_context(request: Request) -> RequestContext:
-    """
-    DEPRECATED: Use get_frontend_type() from middleware.frontend_type instead.
-
-    Helper function to get current request context.
-    This function maps FrontendType to RequestContext for backwards compatibility.
-
-    Args:
-        request: FastAPI request object
-
-    Returns:
-        RequestContext enum value (defaults to FALLBACK if not set)
-    """
-    warnings.warn(
-        "get_request_context() is deprecated. Use get_frontend_type() from "
-        "middleware.frontend_type instead.",
-        DeprecationWarning,
-        stacklevel=2,
-    )
-
-    # Get the new frontend_type
-    frontend_type = get_frontend_type(request)
-
-    # Map FrontendType to RequestContext for backwards compatibility
-    mapping = {
-        FrontendType.ADMIN: RequestContext.ADMIN,
-        FrontendType.STORE: RequestContext.STORE_DASHBOARD,
-        FrontendType.STOREFRONT: RequestContext.STOREFRONT,
-        FrontendType.PLATFORM: RequestContext.FALLBACK,
-    }
-
-    # Check if it's an API request
-    if request.url.path.startswith("/api/"):
-        return RequestContext.API
-
-    return mapping.get(frontend_type, RequestContext.FALLBACK)
-
-
-# ContextManager and ContextMiddleware are removed.
-# They have been replaced by FrontendDetector and FrontendTypeMiddleware.
-# Import from the new locations:
-#   from app.core.frontend_detector import FrontendDetector
-#   from middleware.frontend_type import FrontendTypeMiddleware, get_frontend_type

middleware/platform_context.py

@@ -257,18 +257,6 @@ class PlatformContextManager:
         # For domain-based or default, path remains unchanged
         return request.url.path
 
-    @staticmethod
-    def is_admin_request(request: Request) -> bool:
-        """
-        Check if request is for admin interface.
-
-        DEPRECATED: Use FrontendDetector.is_admin() instead.
-        Kept for backwards compatibility.
-        """
-        host = request.headers.get("host", "")
-        path = request.url.path
-        return FrontendDetector.is_admin(host, path)
-
     @staticmethod
     def is_static_file_request(request: Request) -> bool:
         """Check if request is for static files."""
@@ -478,16 +466,6 @@ class PlatformContextMiddleware:
             return True
         return "favicon.ico" in path_lower
 
-    def _is_admin_request(self, path: str, host: str) -> bool:
-        """
-        Check if request is for admin interface.
-
-        DEPRECATED: Use FrontendDetector.is_admin() instead.
-        Kept for backwards compatibility.
-        """
-        return FrontendDetector.is_admin(host, path)
-
-
 def get_current_platform(request: Request) -> Platform | None:
     """Helper function to get current platform from request state."""
     return getattr(request.state, "platform", None)

middleware/store_context.py

@@ -222,18 +222,6 @@ class StoreContextManager:
 
         return request.url.path
 
-    @staticmethod
-    def is_admin_request(request: Request) -> bool:
-        """
-        Check if request is for admin interface.
-
-        DEPRECATED: Use FrontendDetector.is_admin() instead.
-        Kept for backwards compatibility.
-        """
-        host = request.headers.get("host", "")
-        path = request.url.path
-        return FrontendDetector.is_admin(host, path)
-
     @staticmethod
     def is_api_request(request: Request) -> bool:
         """Check if request is for API endpoints."""
@@ -430,7 +418,7 @@ class StoreContextMiddleware(BaseHTTPMiddleware):
         """
         # Skip store detection for admin, static files, and system requests
         if (
-            StoreContextManager.is_admin_request(request)
+            FrontendDetector.is_admin(request.headers.get("host", ""), request.url.path)
             or StoreContextManager.is_static_file_request(request)
             or request.url.path in ["/", "/health", "/docs", "/redoc", "/openapi.json"]
         ):