feat: add module definition completeness validation and permissions

Add new validation rules MOD-020 to MOD-023 for module definition
completeness and standardize permissions across all modules.

Changes:
- Add MOD-020: Module definitions must have required attributes
- Add MOD-021: Modules with menus should have features
- Add MOD-022: Feature modules should have permissions
- Add MOD-023: Modules with routers should use get_*_with_routers pattern

Module permissions added:
- analytics: view, export, manage_dashboards
- billing: view_tiers, manage_tiers, view_subscriptions, manage_subscriptions, view_invoices
- cart: view, manage
- checkout: view_settings, manage_settings
- cms: view_pages, manage_pages, view_media, manage_media, manage_themes
- loyalty: view_programs, manage_programs, view_rewards, manage_rewards
- marketplace: view_integration, manage_integration, sync_products
- messaging: view_messages, send_messages, manage_templates
- payments: view_gateways, manage_gateways, view_transactions

Module improvements:
- Complete cart module with features and permissions
- Complete checkout module with features and permissions
- Add features to catalog module
- Add version to cms module
- Fix loyalty platform_router attachment
- Add path definitions to payments module
- Remove empty scheduled_tasks from dev_tools module

Documentation:
- Update module-system.md with new validation rules
- Update architecture-rules.md with MOD-020 to MOD-023

Tests:
- Add unit tests for module definition completeness
- Add tests for permission structure validation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

app/modules/cms/definition.py

@@ -12,7 +12,7 @@ This is a self-contained module with:
 - Templates: app.modules.cms.templates (namespaced as cms/)
 """
 
-from app.modules.base import MenuItemDefinition, MenuSectionDefinition, ModuleDefinition
+from app.modules.base import MenuItemDefinition, MenuSectionDefinition, ModuleDefinition, PermissionDefinition
 from app.modules.enums import FrontendType
 
 
@@ -35,6 +35,7 @@ cms_module = ModuleDefinition(
     code="cms",
     name="Content Management",
     description="Content pages, media library, and vendor themes.",
+    version="1.0.0",
     features=[
         "cms_basic",  # Basic page editing
         "cms_custom_pages",  # Custom page creation
@@ -43,6 +44,39 @@ cms_module = ModuleDefinition(
         "cms_seo",  # SEO tools
         "media_library",  # Media file management
     ],
+    # Module-driven permissions
+    permissions=[
+        PermissionDefinition(
+            id="cms.view_pages",
+            label_key="cms.permissions.view_pages",
+            description_key="cms.permissions.view_pages_desc",
+            category="cms",
+        ),
+        PermissionDefinition(
+            id="cms.manage_pages",
+            label_key="cms.permissions.manage_pages",
+            description_key="cms.permissions.manage_pages_desc",
+            category="cms",
+        ),
+        PermissionDefinition(
+            id="cms.view_media",
+            label_key="cms.permissions.view_media",
+            description_key="cms.permissions.view_media_desc",
+            category="cms",
+        ),
+        PermissionDefinition(
+            id="cms.manage_media",
+            label_key="cms.permissions.manage_media",
+            description_key="cms.permissions.manage_media_desc",
+            category="cms",
+        ),
+        PermissionDefinition(
+            id="cms.manage_themes",
+            label_key="cms.permissions.manage_themes",
+            description_key="cms.permissions.manage_themes_desc",
+            category="cms",
+        ),
+    ],
     menu_items={
         FrontendType.ADMIN: [
             "content-pages",  # Platform content pages