Exception handling enhancement

app/api/v1/stats.py

@@ -1,16 +1,17 @@
 # app/api/v1/stats.py
-"""Summary description ....
+"""
+Statistics endpoints - simplified with service-level exception handling.
 
 This module provides classes and functions for:
-- ....
-- ....
-- ....
+- Comprehensive system statistics
+- Marketplace-specific analytics
+- Performance metrics and data insights
 """
 
 import logging
 from typing import List
 
-from fastapi import APIRouter, Depends, HTTPException
+from fastapi import APIRouter, Depends
 from sqlalchemy.orm import Session
 
 from app.api.deps import get_current_user
@@ -23,27 +24,22 @@ router = APIRouter()
 logger = logging.getLogger(__name__)
 
 
-# Enhanced Statistics with Marketplace Support
 @router.get("/stats", response_model=StatsResponse)
 def get_stats(
     db: Session = Depends(get_db), current_user: User = Depends(get_current_user)
 ):
     """Get comprehensive statistics with marketplace data (Protected)."""
-    try:
-        stats_data = stats_service.get_comprehensive_stats(db=db)
+    stats_data = stats_service.get_comprehensive_stats(db=db)
 
-        return StatsResponse(
-            total_products=stats_data["total_products"],
-            unique_brands=stats_data["unique_brands"],
-            unique_categories=stats_data["unique_categories"],
-            unique_marketplaces=stats_data["unique_marketplaces"],
-            unique_shops=stats_data["unique_shops"],
-            total_stock_entries=stats_data["total_stock_entries"],
-            total_inventory_quantity=stats_data["total_inventory_quantity"],
-        )
-    except Exception as e:
-        logger.error(f"Error getting comprehensive stats: {str(e)}")
-        raise HTTPException(status_code=500, detail="Internal server error")
+    return StatsResponse(
+        total_products=stats_data["total_products"],
+        unique_brands=stats_data["unique_brands"],
+        unique_categories=stats_data["unique_categories"],
+        unique_marketplaces=stats_data["unique_marketplaces"],
+        unique_shops=stats_data["unique_shops"],
+        total_stock_entries=stats_data["total_stock_entries"],
+        total_inventory_quantity=stats_data["total_inventory_quantity"],
+    )
 
 
 @router.get("/stats/marketplace", response_model=List[MarketplaceStatsResponse])
@@ -51,18 +47,65 @@ def get_marketplace_stats(
     db: Session = Depends(get_db), current_user: User = Depends(get_current_user)
 ):
     """Get statistics broken down by marketplace (Protected)."""
-    try:
-        marketplace_stats = stats_service.get_marketplace_breakdown_stats(db=db)
+    marketplace_stats = stats_service.get_marketplace_breakdown_stats(db=db)
 
-        return [
-            MarketplaceStatsResponse(
-                marketplace=stat["marketplace"],
-                total_products=stat["total_products"],
-                unique_shops=stat["unique_shops"],
-                unique_brands=stat["unique_brands"],
-            )
-            for stat in marketplace_stats
-        ]
-    except Exception as e:
-        logger.error(f"Error getting marketplace stats: {str(e)}")
-        raise HTTPException(status_code=500, detail="Internal server error")
+# app/api/v1/stats.py
+"""
+Statistics endpoints - simplified with service-level exception handling.
+
+This module provides classes and functions for:
+- Comprehensive system statistics
+- Marketplace-specific analytics
+- Performance metrics and data insights
+"""
+
+import logging
+from typing import List
+
+from fastapi import APIRouter, Depends
+from sqlalchemy.orm import Session
+
+from app.api.deps import get_current_user
+from app.core.database import get_db
+from app.services.stats_service import stats_service
+from models.schemas.stats import MarketplaceStatsResponse, StatsResponse
+from models.database.user import User
+
+router = APIRouter()
+logger = logging.getLogger(__name__)
+
+
+@router.get("/stats", response_model=StatsResponse)
+def get_stats(
+    db: Session = Depends(get_db), current_user: User = Depends(get_current_user)
+):
+    """Get comprehensive statistics with marketplace data (Protected)."""
+    stats_data = stats_service.get_comprehensive_stats(db=db)
+
+    return StatsResponse(
+        total_products=stats_data["total_products"],
+        unique_brands=stats_data["unique_brands"],
+        unique_categories=stats_data["unique_categories"],
+        unique_marketplaces=stats_data["unique_marketplaces"],
+        unique_shops=stats_data["unique_shops"],
+        total_stock_entries=stats_data["total_stock_entries"],
+        total_inventory_quantity=stats_data["total_inventory_quantity"],
+    )
+
+
+@router.get("/stats/marketplace", response_model=List[MarketplaceStatsResponse])
+def get_marketplace_stats(
+    db: Session = Depends(get_db), current_user: User = Depends(get_current_user)
+):
+    """Get statistics broken down by marketplace (Protected)."""
+    marketplace_stats = stats_service.get_marketplace_breakdown_stats(db=db)
+
+    return [
+        MarketplaceStatsResponse(
+            marketplace=stat["marketplace"],
+            total_products=stat["total_products"],
+            unique_shops=stat["unique_shops"],
+            unique_brands=stat["unique_brands"],
+        )
+        for stat in marketplace_stats
+    ]