refactor: remove all backward compatibility code across 70 files
Some checks failed
CI / ruff (push) Successful in 11s
CI / validate (push) Has been cancelled
CI / dependency-scanning (push) Has been cancelled
CI / docs (push) Has been cancelled
CI / deploy (push) Has been cancelled
CI / pytest (push) Has started running

Clean up 28 backward compatibility instances identified in the codebase.
The app is not live, so all shims are replaced with the target architecture:

- Remove legacy Inventory.location column (use bin_location exclusively)
- Remove dashboard _extract_metric_value helper (use flat metrics dict)
- Remove legacy stat field duplicates (total_stores, total_imports, etc.)
- Remove 13 re-export shims and class aliases across modules
- Remove module-enabling JSON fallback (use PlatformModule junction table)
- Remove menu_to_legacy_format() conversion (return dataclasses directly)
- Remove title/description from MarketplaceProductBase schema
- Clean billing convenience method docstrings
- Clean test fixtures and backward-compat comments
- Add PlatformModule seeding to init_production.py

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-15 13:20:29 +01:00
parent b0db8133a0
commit aad18c27ab
70 changed files with 501 additions and 841 deletions

View File

@@ -70,7 +70,7 @@ class OrderInventoryService:
)
.first()
)
return inventory.location if inventory else None
return inventory.bin_location if inventory else None
def _is_placeholder_product(self, order_item: OrderItem) -> bool:
"""Check if the order item uses a placeholder product."""
@@ -98,7 +98,7 @@ class OrderInventoryService:
quantity_change=quantity_change,
quantity_after=inventory.quantity if inventory else 0,
reserved_after=inventory.reserved_quantity if inventory else 0,
location=inventory.location if inventory else None,
location=inventory.bin_location if inventory else None,
warehouse=inventory.warehouse if inventory else None,
order_id=order.id,
order_number=order.order_number,
@@ -229,7 +229,7 @@ class OrderInventoryService:
.first()
)
if inventory:
location = inventory.location
location = inventory.bin_location
if not location:
if skip_missing:
@@ -358,7 +358,7 @@ class OrderInventoryService:
.first()
)
if inventory:
location = inventory.location
location = inventory.bin_location
if not location:
if skip_missing:
@@ -467,7 +467,7 @@ class OrderInventoryService:
try:
reserve_data = InventoryReserve(
product_id=item.product_id,
location=inventory.location,
location=inventory.bin_location,
quantity=item.quantity,
)
updated_inventory = inventory_service.release_reservation(