refactor: remove all backward compatibility code across 70 files
Some checks failed
CI / ruff (push) Successful in 11s
CI / validate (push) Has been cancelled
CI / dependency-scanning (push) Has been cancelled
CI / docs (push) Has been cancelled
CI / deploy (push) Has been cancelled
CI / pytest (push) Has started running

Clean up 28 backward compatibility instances identified in the codebase.
The app is not live, so all shims are replaced with the target architecture:

- Remove legacy Inventory.location column (use bin_location exclusively)
- Remove dashboard _extract_metric_value helper (use flat metrics dict)
- Remove legacy stat field duplicates (total_stores, total_imports, etc.)
- Remove 13 re-export shims and class aliases across modules
- Remove module-enabling JSON fallback (use PlatformModule junction table)
- Remove menu_to_legacy_format() conversion (return dataclasses directly)
- Remove title/description from MarketplaceProductBase schema
- Clean billing convenience method docstrings
- Clean test fixtures and backward-compat comments
- Add PlatformModule seeding to init_production.py

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-15 13:20:29 +01:00
parent b0db8133a0
commit aad18c27ab
70 changed files with 501 additions and 841 deletions

View File

@@ -203,17 +203,17 @@ class TestAdminService:
"""Test getting store statistics"""
stats = stats_service.get_store_statistics(db)
assert "total_stores" in stats
assert "active_stores" in stats
assert "verified_stores" in stats
assert "total" in stats
assert "verified" in stats
assert "pending" in stats
assert "inactive" in stats
assert "verification_rate" in stats
assert isinstance(stats["total_stores"], int)
assert isinstance(stats["active_stores"], int)
assert isinstance(stats["verified_stores"], int)
assert isinstance(stats["total"], int)
assert isinstance(stats["verified"], int)
assert isinstance(stats["verification_rate"], int | float)
assert stats["total_stores"] >= 1
assert stats["total"] >= 1
# Error Handling Tests
def test_get_all_users_database_error(self, db_with_error, test_admin):
@@ -259,9 +259,9 @@ class TestAdminService:
"""Test store statistics when no stores exist"""
stats = stats_service.get_store_statistics(empty_db)
assert stats["total_stores"] == 0
assert stats["active_stores"] == 0
assert stats["verified_stores"] == 0
assert stats["total"] == 0
assert stats["verified"] == 0
assert stats["inactive"] == 0
assert stats["verification_rate"] == 0