From b31fd41423f2b810aa2eddbefb41203a485784e7 Mon Sep 17 00:00:00 2001 From: Samir Boulahtit Date: Sat, 6 Dec 2025 19:41:01 +0100 Subject: [PATCH] fix: align auth_service with transaction management pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change register_user() to use db.flush() instead of db.commit() and remove db.rollback() to follow the established architecture: - Services use flush() for database operations - Endpoints handle transaction commit - Exception handlers manage rollback This resolves SVC-006 architecture violation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- app/services/auth_service.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/services/auth_service.py b/app/services/auth_service.py index 2e16a87f..413eb86b 100644 --- a/app/services/auth_service.py +++ b/app/services/auth_service.py @@ -74,8 +74,7 @@ class AuthService: ) db.add(new_user) - db.commit() - db.refresh(new_user) + db.flush() logger.info(f"New user registered: {new_user.username}") return new_user @@ -83,7 +82,6 @@ class AuthService: except UserAlreadyExistsException: raise # Re-raise custom exceptions except Exception as e: - db.rollback() logger.error(f"Error registering user: {str(e)}") raise ValidationException("Registration failed")