feat: implement persistent cart with database storage and proper exception handling
Implemented a complete shopping cart system with database persistence, replacing the previous stub implementation. The cart now properly stores items across sessions and follows the project's architecture patterns. Database Changes: - Add cart_items table with vendor_id, session_id, product_id, quantity, price_at_add - Create unique constraint to prevent duplicate items per session - Add indexes for session lookups and old cart cleanup - Run migration a2064e1dfcd4 to create cart_items table New Models & Schemas: - models/database/cart.py: CartItem SQLAlchemy model with relationships - models/schema/cart.py: Pydantic schemas for requests/responses * AddToCartRequest, UpdateCartItemRequest * CartResponse, CartItemResponse, CartOperationResponse, ClearCartResponse Exception Handling: - app/exceptions/cart.py: Cart-specific exceptions following project patterns * CartItemNotFoundException - item not found in cart * InsufficientInventoryForCartException - not enough inventory for cart operation * InvalidCartQuantityException - invalid quantity validation * CartValidationException - general cart validation * EmptyCartException - operations on empty cart * ProductNotAvailableForCartException - product unavailable - Updated app/exceptions/__init__.py to export cart exceptions Service Layer: - Implement cart_service.get_cart() - fetch cart from database with totals - Implement cart_service.add_to_cart() - create or update cart items with inventory checks - Implement cart_service.update_cart_item() - update quantity with validation - Implement cart_service.remove_from_cart() - delete cart item - Implement cart_service.clear_cart() - remove all items for session - Replace generic exceptions with cart-specific ones - Fix InsufficientInventoryException usage (was using wrong parameters) API Layer: - Update app/api/v1/shop/cart.py to use Pydantic schemas - Add response_model declarations to all endpoints - Add return type hints for type safety - Convert service dict responses to Pydantic models Features: - Cart items persist in database across server restarts - Inventory validation before adding/updating items - Price captured at time of adding to cart - Duplicate items update quantity instead of creating new entries - Full CRUD operations with proper error handling - Type-safe API with auto-generated OpenAPI documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -17,10 +17,14 @@ from sqlalchemy import and_
|
||||
|
||||
from models.database.product import Product
|
||||
from models.database.vendor import Vendor
|
||||
from models.database.cart import CartItem
|
||||
from app.exceptions import (
|
||||
ProductNotFoundException,
|
||||
ValidationException,
|
||||
InsufficientInventoryException
|
||||
CartItemNotFoundException,
|
||||
CartValidationException,
|
||||
InsufficientInventoryForCartException,
|
||||
InvalidCartQuantityException,
|
||||
ProductNotAvailableForCartException,
|
||||
)
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
@@ -38,19 +42,69 @@ class CartService:
|
||||
"""
|
||||
Get cart contents for a session.
|
||||
|
||||
Note: This is a simple in-memory implementation.
|
||||
In production, you'd store carts in Redis or database.
|
||||
Args:
|
||||
db: Database session
|
||||
vendor_id: Vendor ID
|
||||
session_id: Session ID
|
||||
|
||||
Returns:
|
||||
Cart data with items and totals
|
||||
"""
|
||||
# For now, return empty cart structure
|
||||
# TODO: Implement persistent cart storage
|
||||
return {
|
||||
logger.info(
|
||||
f"[CART_SERVICE] get_cart called",
|
||||
extra={
|
||||
"vendor_id": vendor_id,
|
||||
"session_id": session_id,
|
||||
}
|
||||
)
|
||||
|
||||
# Fetch cart items from database
|
||||
cart_items = db.query(CartItem).filter(
|
||||
and_(
|
||||
CartItem.vendor_id == vendor_id,
|
||||
CartItem.session_id == session_id
|
||||
)
|
||||
).all()
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] Found {len(cart_items)} items in database",
|
||||
extra={"item_count": len(cart_items)}
|
||||
)
|
||||
|
||||
# Build response
|
||||
items = []
|
||||
subtotal = 0.0
|
||||
|
||||
for cart_item in cart_items:
|
||||
product = cart_item.product
|
||||
line_total = cart_item.line_total
|
||||
|
||||
items.append({
|
||||
"product_id": product.id,
|
||||
"product_name": product.name,
|
||||
"quantity": cart_item.quantity,
|
||||
"price": cart_item.price_at_add,
|
||||
"line_total": line_total,
|
||||
"image_url": product.image_link if hasattr(product, 'image_link') else None,
|
||||
})
|
||||
|
||||
subtotal += line_total
|
||||
|
||||
cart_data = {
|
||||
"vendor_id": vendor_id,
|
||||
"session_id": session_id,
|
||||
"items": [],
|
||||
"subtotal": 0.0,
|
||||
"total": 0.0
|
||||
"items": items,
|
||||
"subtotal": subtotal,
|
||||
"total": subtotal # Could add tax/shipping later
|
||||
}
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] get_cart returning: {len(cart_data['items'])} items, total: {cart_data['total']}",
|
||||
extra={"cart": cart_data}
|
||||
)
|
||||
|
||||
return cart_data
|
||||
|
||||
def add_to_cart(
|
||||
self,
|
||||
db: Session,
|
||||
@@ -76,6 +130,16 @@ class CartService:
|
||||
ProductNotFoundException: If product not found
|
||||
InsufficientInventoryException: If not enough inventory
|
||||
"""
|
||||
logger.info(
|
||||
f"[CART_SERVICE] add_to_cart called",
|
||||
extra={
|
||||
"vendor_id": vendor_id,
|
||||
"session_id": session_id,
|
||||
"product_id": product_id,
|
||||
"quantity": quantity
|
||||
}
|
||||
)
|
||||
|
||||
# Verify product exists and belongs to vendor
|
||||
product = db.query(Product).filter(
|
||||
and_(
|
||||
@@ -85,64 +149,195 @@ class CartService:
|
||||
)
|
||||
).first()
|
||||
|
||||
if not product:
|
||||
logger.error(
|
||||
f"[CART_SERVICE] Product not found",
|
||||
extra={"product_id": product_id, "vendor_id": vendor_id}
|
||||
)
|
||||
raise ProductNotFoundException(product_id=product_id, vendor_id=vendor_id)
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] Product found: {product.name}",
|
||||
extra={
|
||||
"product_id": product_id,
|
||||
"product_name": product.name,
|
||||
"available_inventory": product.available_inventory
|
||||
}
|
||||
)
|
||||
|
||||
# Get current price (use sale_price if available, otherwise regular price)
|
||||
current_price = product.sale_price if product.sale_price else product.price
|
||||
|
||||
# Check if item already exists in cart
|
||||
existing_item = db.query(CartItem).filter(
|
||||
and_(
|
||||
CartItem.vendor_id == vendor_id,
|
||||
CartItem.session_id == session_id,
|
||||
CartItem.product_id == product_id
|
||||
)
|
||||
).first()
|
||||
|
||||
if existing_item:
|
||||
# Update quantity
|
||||
new_quantity = existing_item.quantity + quantity
|
||||
|
||||
# Check inventory for new total quantity
|
||||
if product.available_inventory < new_quantity:
|
||||
logger.warning(
|
||||
f"[CART_SERVICE] Insufficient inventory for update",
|
||||
extra={
|
||||
"product_id": product_id,
|
||||
"current_in_cart": existing_item.quantity,
|
||||
"adding": quantity,
|
||||
"requested_total": new_quantity,
|
||||
"available": product.available_inventory
|
||||
}
|
||||
)
|
||||
raise InsufficientInventoryForCartException(
|
||||
product_id=product_id,
|
||||
product_name=product.name,
|
||||
requested=new_quantity,
|
||||
available=product.available_inventory
|
||||
)
|
||||
|
||||
existing_item.quantity = new_quantity
|
||||
db.commit()
|
||||
db.refresh(existing_item)
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] Updated existing cart item",
|
||||
extra={
|
||||
"cart_item_id": existing_item.id,
|
||||
"new_quantity": new_quantity
|
||||
}
|
||||
)
|
||||
|
||||
return {
|
||||
"message": "Product quantity updated in cart",
|
||||
"product_id": product_id,
|
||||
"quantity": new_quantity
|
||||
}
|
||||
else:
|
||||
# Check inventory for new item
|
||||
if product.available_inventory < quantity:
|
||||
logger.warning(
|
||||
f"[CART_SERVICE] Insufficient inventory",
|
||||
extra={
|
||||
"product_id": product_id,
|
||||
"requested": quantity,
|
||||
"available": product.available_inventory
|
||||
}
|
||||
)
|
||||
raise InsufficientInventoryForCartException(
|
||||
product_id=product_id,
|
||||
product_name=product.name,
|
||||
requested=quantity,
|
||||
available=product.available_inventory
|
||||
)
|
||||
|
||||
# Create new cart item
|
||||
cart_item = CartItem(
|
||||
vendor_id=vendor_id,
|
||||
session_id=session_id,
|
||||
product_id=product_id,
|
||||
quantity=quantity,
|
||||
price_at_add=current_price
|
||||
)
|
||||
db.add(cart_item)
|
||||
db.commit()
|
||||
db.refresh(cart_item)
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] Created new cart item",
|
||||
extra={
|
||||
"cart_item_id": cart_item.id,
|
||||
"quantity": quantity,
|
||||
"price": current_price
|
||||
}
|
||||
)
|
||||
|
||||
return {
|
||||
"message": "Product added to cart",
|
||||
"product_id": product_id,
|
||||
"quantity": quantity
|
||||
}
|
||||
|
||||
def update_cart_item(
|
||||
self,
|
||||
db: Session,
|
||||
vendor_id: int,
|
||||
session_id: str,
|
||||
product_id: int,
|
||||
quantity: int
|
||||
) -> Dict:
|
||||
"""
|
||||
Update quantity of item in cart.
|
||||
|
||||
Args:
|
||||
db: Database session
|
||||
vendor_id: Vendor ID
|
||||
session_id: Session ID
|
||||
product_id: Product ID
|
||||
quantity: New quantity (must be >= 1)
|
||||
|
||||
Returns:
|
||||
Success message
|
||||
|
||||
Raises:
|
||||
ValidationException: If quantity < 1
|
||||
ProductNotFoundException: If product not found
|
||||
InsufficientInventoryException: If not enough inventory
|
||||
"""
|
||||
if quantity < 1:
|
||||
raise InvalidCartQuantityException(quantity=quantity, min_quantity=1)
|
||||
|
||||
# Find cart item
|
||||
cart_item = db.query(CartItem).filter(
|
||||
and_(
|
||||
CartItem.vendor_id == vendor_id,
|
||||
CartItem.session_id == session_id,
|
||||
CartItem.product_id == product_id
|
||||
)
|
||||
).first()
|
||||
|
||||
if not cart_item:
|
||||
raise CartItemNotFoundException(product_id=product_id, session_id=session_id)
|
||||
|
||||
# Verify product still exists and is active
|
||||
product = db.query(Product).filter(
|
||||
and_(
|
||||
Product.id == product_id,
|
||||
Product.vendor_id == vendor_id,
|
||||
Product.is_active == True
|
||||
)
|
||||
).first()
|
||||
|
||||
if not product:
|
||||
raise ProductNotFoundException(str(product_id))
|
||||
|
||||
# Check inventory
|
||||
if product.available_inventory < quantity:
|
||||
raise InsufficientInventoryException(
|
||||
raise InsufficientInventoryForCartException(
|
||||
product_id=product_id,
|
||||
product_name=product.name,
|
||||
requested=quantity,
|
||||
available=product.available_inventory
|
||||
)
|
||||
|
||||
# TODO: Add to persistent cart storage
|
||||
# For now, return success response
|
||||
# Update quantity
|
||||
cart_item.quantity = quantity
|
||||
db.commit()
|
||||
db.refresh(cart_item)
|
||||
|
||||
logger.info(
|
||||
f"Added product {product_id} (qty: {quantity}) to cart "
|
||||
f"for session {session_id}"
|
||||
f"[CART_SERVICE] Updated cart item quantity",
|
||||
extra={
|
||||
"cart_item_id": cart_item.id,
|
||||
"product_id": product_id,
|
||||
"new_quantity": quantity
|
||||
}
|
||||
)
|
||||
|
||||
return {
|
||||
"message": "Product added to cart",
|
||||
"product_id": product_id,
|
||||
"quantity": quantity
|
||||
}
|
||||
|
||||
def update_cart_item(
|
||||
self,
|
||||
db: Session,
|
||||
vendor_id: int,
|
||||
session_id: str,
|
||||
product_id: int,
|
||||
quantity: int
|
||||
) -> Dict:
|
||||
"""Update quantity of item in cart."""
|
||||
if quantity < 1:
|
||||
raise ValidationException("Quantity must be at least 1")
|
||||
|
||||
# Verify product
|
||||
product = db.query(Product).filter(
|
||||
and_(
|
||||
Product.id == product_id,
|
||||
Product.vendor_id == vendor_id
|
||||
)
|
||||
).first()
|
||||
|
||||
if not product:
|
||||
raise ProductNotFoundException(str(product_id))
|
||||
|
||||
# Check inventory
|
||||
if product.available_inventory < quantity:
|
||||
raise InsufficientInventoryException(
|
||||
product_id=product_id,
|
||||
requested=quantity,
|
||||
available=product.available_inventory
|
||||
)
|
||||
|
||||
# TODO: Update persistent cart
|
||||
logger.info(f"Updated cart item {product_id} quantity to {quantity}")
|
||||
|
||||
return {
|
||||
"message": "Cart updated",
|
||||
"product_id": product_id,
|
||||
@@ -156,9 +351,44 @@ class CartService:
|
||||
session_id: str,
|
||||
product_id: int
|
||||
) -> Dict:
|
||||
"""Remove item from cart."""
|
||||
# TODO: Remove from persistent cart
|
||||
logger.info(f"Removed product {product_id} from cart {session_id}")
|
||||
"""
|
||||
Remove item from cart.
|
||||
|
||||
Args:
|
||||
db: Database session
|
||||
vendor_id: Vendor ID
|
||||
session_id: Session ID
|
||||
product_id: Product ID
|
||||
|
||||
Returns:
|
||||
Success message
|
||||
|
||||
Raises:
|
||||
ProductNotFoundException: If product not in cart
|
||||
"""
|
||||
# Find and delete cart item
|
||||
cart_item = db.query(CartItem).filter(
|
||||
and_(
|
||||
CartItem.vendor_id == vendor_id,
|
||||
CartItem.session_id == session_id,
|
||||
CartItem.product_id == product_id
|
||||
)
|
||||
).first()
|
||||
|
||||
if not cart_item:
|
||||
raise CartItemNotFoundException(product_id=product_id, session_id=session_id)
|
||||
|
||||
db.delete(cart_item)
|
||||
db.commit()
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] Removed item from cart",
|
||||
extra={
|
||||
"cart_item_id": cart_item.id,
|
||||
"product_id": product_id,
|
||||
"session_id": session_id
|
||||
}
|
||||
)
|
||||
|
||||
return {
|
||||
"message": "Item removed from cart",
|
||||
@@ -171,12 +401,39 @@ class CartService:
|
||||
vendor_id: int,
|
||||
session_id: str
|
||||
) -> Dict:
|
||||
"""Clear all items from cart."""
|
||||
# TODO: Clear persistent cart
|
||||
logger.info(f"Cleared cart for session {session_id}")
|
||||
"""
|
||||
Clear all items from cart.
|
||||
|
||||
Args:
|
||||
db: Database session
|
||||
vendor_id: Vendor ID
|
||||
session_id: Session ID
|
||||
|
||||
Returns:
|
||||
Success message with count of items removed
|
||||
"""
|
||||
# Delete all cart items for this session
|
||||
deleted_count = db.query(CartItem).filter(
|
||||
and_(
|
||||
CartItem.vendor_id == vendor_id,
|
||||
CartItem.session_id == session_id
|
||||
)
|
||||
).delete()
|
||||
|
||||
db.commit()
|
||||
|
||||
logger.info(
|
||||
f"[CART_SERVICE] Cleared cart",
|
||||
extra={
|
||||
"session_id": session_id,
|
||||
"vendor_id": vendor_id,
|
||||
"items_removed": deleted_count
|
||||
}
|
||||
)
|
||||
|
||||
return {
|
||||
"message": "Cart cleared"
|
||||
"message": "Cart cleared",
|
||||
"items_removed": deleted_count
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user