feat: complete modular platform architecture (Phases 1-5)
Phase 1 - Vendor Router Integration: - Wire up vendor module routers in app/api/v1/vendor/__init__.py - Use lazy imports via __getattr__ to avoid circular dependencies Phase 2 - Extract Remaining Modules: - Create 6 new module directories: customers, cms, analytics, messaging, dev_tools, monitoring - Each module has definition.py and route wrappers - Update registry to import from extracted modules Phase 3 - Database Table Migration: - Add PlatformModule junction table for auditable module tracking - Add migration zc2m3n4o5p6q7_add_platform_modules_table.py - Add modules relationship to Platform model - Update ModuleService with JSON-to-junction-table migration Phase 4 - Module-Specific Configuration UI: - Add /api/v1/admin/module-config/* endpoints - Add module-config.html template and JS Phase 5 - Integration Tests: - Add tests/fixtures/module_fixtures.py - Add tests/integration/api/v1/admin/test_modules.py - Add tests/integration/api/v1/modules/test_module_access.py Architecture fixes: - Fix JS-003 errors: use ...data() directly in Alpine components - Fix JS-005 warnings: add init() guards to prevent duplicate init - Fix API-001 errors: add MenuActionResponse Pydantic model - Add FE-008 noqa for dynamic number input in template Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
25
app/modules/monitoring/__init__.py
Normal file
25
app/modules/monitoring/__init__.py
Normal file
@@ -0,0 +1,25 @@
|
||||
# app/modules/monitoring/__init__.py
|
||||
"""
|
||||
Monitoring Module - Platform monitoring and system health.
|
||||
|
||||
This module provides:
|
||||
- Application logs
|
||||
- Background tasks monitoring
|
||||
- Import job tracking
|
||||
- Platform health metrics
|
||||
- Testing hub
|
||||
- Code quality tools
|
||||
|
||||
Routes:
|
||||
- Admin: /api/v1/admin/logs/*, /api/v1/admin/background-tasks/*,
|
||||
/api/v1/admin/tests/*, /api/v1/admin/code-quality/*
|
||||
- Vendor: None
|
||||
|
||||
Menu Items:
|
||||
- Admin: imports, background-tasks, logs, platform-health, testing, code-quality
|
||||
- Vendor: None
|
||||
"""
|
||||
|
||||
from app.modules.monitoring.definition import monitoring_module
|
||||
|
||||
__all__ = ["monitoring_module"]
|
||||
59
app/modules/monitoring/definition.py
Normal file
59
app/modules/monitoring/definition.py
Normal file
@@ -0,0 +1,59 @@
|
||||
# app/modules/monitoring/definition.py
|
||||
"""
|
||||
Monitoring module definition.
|
||||
|
||||
Defines the monitoring module including its features, menu items,
|
||||
and route configurations.
|
||||
"""
|
||||
|
||||
from app.modules.base import ModuleDefinition
|
||||
from models.database.admin_menu_config import FrontendType
|
||||
|
||||
|
||||
def _get_admin_router():
|
||||
"""Lazy import of admin router to avoid circular imports."""
|
||||
from app.modules.monitoring.routes.admin import admin_router
|
||||
|
||||
return admin_router
|
||||
|
||||
|
||||
# Monitoring module definition
|
||||
monitoring_module = ModuleDefinition(
|
||||
code="monitoring",
|
||||
name="Platform Monitoring",
|
||||
description="Logs, background tasks, imports, and system health.",
|
||||
features=[
|
||||
"application_logs", # Log viewing
|
||||
"background_tasks", # Task monitoring
|
||||
"import_jobs", # Import job tracking
|
||||
"capacity_monitoring", # System capacity
|
||||
"testing_hub", # Test runner
|
||||
"code_quality", # Code quality tools
|
||||
],
|
||||
menu_items={
|
||||
FrontendType.ADMIN: [
|
||||
"imports", # Import jobs
|
||||
"background-tasks", # Background tasks
|
||||
"logs", # Application logs
|
||||
"platform-health", # Platform health
|
||||
"testing", # Testing hub
|
||||
"code-quality", # Code quality
|
||||
],
|
||||
FrontendType.VENDOR: [], # No vendor menu items
|
||||
},
|
||||
is_core=False,
|
||||
)
|
||||
|
||||
|
||||
def get_monitoring_module_with_routers() -> ModuleDefinition:
|
||||
"""
|
||||
Get monitoring module with routers attached.
|
||||
|
||||
This function attaches the routers lazily to avoid circular imports
|
||||
during module initialization.
|
||||
"""
|
||||
monitoring_module.admin_router = _get_admin_router()
|
||||
return monitoring_module
|
||||
|
||||
|
||||
__all__ = ["monitoring_module", "get_monitoring_module_with_routers"]
|
||||
26
app/modules/monitoring/routes/__init__.py
Normal file
26
app/modules/monitoring/routes/__init__.py
Normal file
@@ -0,0 +1,26 @@
|
||||
# app/modules/monitoring/routes/__init__.py
|
||||
"""
|
||||
Monitoring module route registration.
|
||||
|
||||
This module provides functions to register monitoring routes
|
||||
with module-based access control.
|
||||
|
||||
NOTE: Routers are NOT auto-imported to avoid circular dependencies.
|
||||
Import directly from admin.py as needed:
|
||||
from app.modules.monitoring.routes.admin import admin_router
|
||||
|
||||
Note: Monitoring module has no vendor routes.
|
||||
"""
|
||||
|
||||
# Routers are imported on-demand to avoid circular dependencies
|
||||
# Do NOT add auto-imports here
|
||||
|
||||
__all__ = ["admin_router"]
|
||||
|
||||
|
||||
def __getattr__(name: str):
|
||||
"""Lazy import routers to avoid circular dependencies."""
|
||||
if name == "admin_router":
|
||||
from app.modules.monitoring.routes.admin import admin_router
|
||||
return admin_router
|
||||
raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
|
||||
53
app/modules/monitoring/routes/admin.py
Normal file
53
app/modules/monitoring/routes/admin.py
Normal file
@@ -0,0 +1,53 @@
|
||||
# app/modules/monitoring/routes/admin.py
|
||||
"""
|
||||
Monitoring module admin routes.
|
||||
|
||||
This module wraps the existing admin monitoring routes and adds
|
||||
module-based access control. Routes are re-exported from the
|
||||
original location with the module access dependency.
|
||||
|
||||
Includes:
|
||||
- /logs/* - Application logs
|
||||
- /background-tasks/* - Background task monitoring
|
||||
- /tests/* - Test runner
|
||||
- /code-quality/* - Code quality tools
|
||||
"""
|
||||
|
||||
from fastapi import APIRouter, Depends
|
||||
|
||||
from app.api.deps import require_module_access
|
||||
|
||||
# Import original routers (direct import to avoid circular dependency)
|
||||
from app.api.v1.admin.logs import router as logs_original_router
|
||||
from app.api.v1.admin.background_tasks import router as tasks_original_router
|
||||
from app.api.v1.admin.tests import router as tests_original_router
|
||||
from app.api.v1.admin.code_quality import router as code_quality_original_router
|
||||
|
||||
# Create module-aware router for logs
|
||||
admin_router = APIRouter(
|
||||
prefix="/monitoring",
|
||||
dependencies=[Depends(require_module_access("monitoring"))],
|
||||
)
|
||||
|
||||
# Create sub-routers for each component
|
||||
logs_router = APIRouter(prefix="/logs")
|
||||
for route in logs_original_router.routes:
|
||||
logs_router.routes.append(route)
|
||||
|
||||
tasks_router = APIRouter(prefix="/background-tasks")
|
||||
for route in tasks_original_router.routes:
|
||||
tasks_router.routes.append(route)
|
||||
|
||||
tests_router = APIRouter(prefix="/tests")
|
||||
for route in tests_original_router.routes:
|
||||
tests_router.routes.append(route)
|
||||
|
||||
code_quality_router = APIRouter(prefix="/code-quality")
|
||||
for route in code_quality_original_router.routes:
|
||||
code_quality_router.routes.append(route)
|
||||
|
||||
# Include all sub-routers
|
||||
admin_router.include_router(logs_router)
|
||||
admin_router.include_router(tasks_router)
|
||||
admin_router.include_router(tests_router)
|
||||
admin_router.include_router(code_quality_router)
|
||||
Reference in New Issue
Block a user