sboulahtit/orion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: properly check email send result in admin test endpoint

Browse Source 
send_raw() returns EmailLog, not boolean - check status=="sent" and
return error_message on failure instead of always reporting success.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Samir Boulahtit
2026-01-05 22:55:14 +01:00
parent e1c0c117c2
commit c41cbd30dc
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/api/v1/admin/settings.py
View File

@@ -659,7 +659,7 @@ def send_test_email(
email_service = EmailService(db) email_service = EmailService(db)
# Send test email using platform configuration # Send test email using platform configuration
success = email_service.send_raw( email_log = email_service.send_raw(
to_email=request.to_email, to_email=request.to_email,
to_name=None, to_name=None,
subject="Wizamart Platform - Test Email", subject="Wizamart Platform - Test Email",
@@ -684,7 +684,8 @@ def send_test_email(
is_platform_email=True, is_platform_email=True,
) )
if success: # Check if email was actually sent (send_raw returns EmailLog, not boolean)
if email_log.status == "sent":
# Log action # Log action
admin_audit_service.log_action( admin_audit_service.log_action(
db=db, db=db,
@@ -703,7 +704,7 @@ def send_test_email(
else: else:
return TestEmailResponse( return TestEmailResponse(
success=False, success=False,
message="Failed to send test email. Check server logs for details.", message=email_log.error_message or "Failed to send test email. Check server logs for details.",
) )
except Exception as e: except Exception as e: