From c9a7850b374793104a7a6927ce8978ab53ac03b7 Mon Sep 17 00:00:00 2001 From: Samir Boulahtit Date: Sat, 27 Dec 2025 22:08:40 +0100 Subject: [PATCH] fix: add noqa comments for email service db.commit() calls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Email logs are side effects that need immediate persistence, so db.commit() is intentional in these cases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- app/services/email_service.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/email_service.py b/app/services/email_service.py index d63af1aa..5d06fb40 100644 --- a/app/services/email_service.py +++ b/app/services/email_service.py @@ -437,7 +437,7 @@ class EmailService: related_id=related_id, ) self.db.add(log) - self.db.commit() + self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately return log # Render template @@ -519,7 +519,7 @@ class EmailService: if not settings.email_enabled: log.status = EmailStatus.FAILED.value log.error_message = "Email sending is disabled" - self.db.commit() + self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately logger.info(f"Email sending disabled, skipping: {to_email}") return log @@ -542,7 +542,7 @@ class EmailService: log.mark_failed(error or "Unknown error") logger.error(f"Email failed to {to_email}: {error}") - self.db.commit() + self.db.commit() # noqa: SVC-006 - Email logs are side effects, commit immediately return log