From c9fe717184028fba7e269367932f22c5c39fb7ce Mon Sep 17 00:00:00 2001
From: Samir Boulahtit <samir.boulahtit@wizard.lu>
Date: Fri, 29 May 2026 22:41:15 +0200
Subject: [PATCH] fix(login-i18n): translate the 3 hardcoded JS toasts in
 customer login
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Three more hardcoded English strings in customers/storefront/login.html
were still bypassing i18n because they were emitted from Alpine
showAlert() calls in <script>:

- "Account created successfully! Please sign in." (post-register toast)
- "Login successful! Redirecting..." (post-login toast)
- "Invalid email or password" (login-error fallback)

Same pattern as the earlier forgot/reset-password sweep: defined
window.__customerLoginI18n with `tojson` server-rendered values, read
them once at function entry as `const i18n = ...`, and swapped each
hardcoded string for an i18n property.

Two new auth.* keys × 4 locales (registration_success_signin,
login_success_redirecting). The third reuses the existing
auth.invalid_credentials.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../templates/customers/storefront/login.html    | 16 +++++++++++++---
 static/locales/de.json                           |  2 ++
 static/locales/en.json                           |  2 ++
 static/locales/fr.json                           |  2 ++
 static/locales/lb.json                           |  2 ++
 5 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/app/modules/customers/templates/customers/storefront/login.html b/app/modules/customers/templates/customers/storefront/login.html
index fc3d69fb..58fe20ca 100644
--- a/app/modules/customers/templates/customers/storefront/login.html
+++ b/app/modules/customers/templates/customers/storefront/login.html
@@ -187,6 +187,15 @@
     <!-- Alpine.js v3 -->
     <script defer src="https://cdn.jsdelivr.net/npm/alpinejs@3.14.0/dist/cdn.min.js"></script>
 
+    {# Translated client-side strings — kept in sync with auth.* keys above #}
+    <script>
+        window.__customerLoginI18n = {
+            registrationSuccess: {{ _('auth.registration_success_signin')|tojson }},
+            loginSuccess: {{ _('auth.login_success_redirecting')|tojson }},
+            invalidCredentials: {{ _('auth.invalid_credentials')|tojson }},
+        };
+    </script>
+
     <!-- Login Logic -->
     <script>
         function languageSelector(currentLang, enabledLanguages) {
@@ -206,6 +215,7 @@
         }
 
         function customerLogin() {
+            const i18n = window.__customerLoginI18n || {};
             return {
                 // Data
                 credentials: {
@@ -234,7 +244,7 @@
                 checkRegistrationSuccess() {
                     const urlParams = new URLSearchParams(window.location.search);
                     if (urlParams.get('registered') === 'true') {
-                        this.showAlert('Account created successfully! Please sign in.', 'success');
+                        this.showAlert(i18n.registrationSuccess, 'success');
                     }
                 },
 
@@ -293,7 +303,7 @@
                         localStorage.setItem('customer_token', data.access_token);
                         localStorage.setItem('customer_user', JSON.stringify(data.user));
 
-                        this.showAlert('Login successful! Redirecting...', 'success');
+                        this.showAlert(i18n.loginSuccess, 'success');
 
                         // Redirect to account page or return URL.
                         // Accepts `?next=` (apiClient's 401-handler convention)
@@ -306,7 +316,7 @@
 
                     } catch (error) {
                         console.error('Login error:', error);
-                        this.showAlert(error.message || 'Invalid email or password');
+                        this.showAlert(error.message || i18n.invalidCredentials);
                     } finally {
                         this.loading = false;
                     }
diff --git a/static/locales/de.json b/static/locales/de.json
index 464eda0e..0bc2df92 100644
--- a/static/locales/de.json
+++ b/static/locales/de.json
@@ -142,6 +142,8 @@
     "try_again": "versuchen Sie es erneut",
     "remember_password": "Passwort wieder eingefallen?",
     "login_subtitle": "Willkommen zurück in Ihrem Konto",
+    "registration_success_signin": "Konto erfolgreich erstellt! Bitte anmelden.",
+    "login_success_redirecting": "Anmeldung erfolgreich! Weiterleitung...",
     "reset_password_subtitle": "Neues Passwort erstellen",
     "reset_your_password": "Passwort zurücksetzen",
     "reset_password_form_desc": "Geben Sie unten Ihr neues Passwort ein. Es muss mindestens 8 Zeichen lang sein.",
diff --git a/static/locales/en.json b/static/locales/en.json
index b5e225bc..edb80dd4 100644
--- a/static/locales/en.json
+++ b/static/locales/en.json
@@ -142,6 +142,8 @@
     "try_again": "try again",
     "remember_password": "Remember your password?",
     "login_subtitle": "Welcome back to your account",
+    "registration_success_signin": "Account created successfully! Please sign in.",
+    "login_success_redirecting": "Login successful! Redirecting...",
     "reset_password_subtitle": "Create new password",
     "reset_your_password": "Reset Your Password",
     "reset_password_form_desc": "Enter your new password below. Password must be at least 8 characters.",
diff --git a/static/locales/fr.json b/static/locales/fr.json
index f79fa07c..ee7921f4 100644
--- a/static/locales/fr.json
+++ b/static/locales/fr.json
@@ -142,6 +142,8 @@
     "try_again": "réessayez",
     "remember_password": "Vous vous souvenez de votre mot de passe ?",
     "login_subtitle": "Heureux de vous revoir",
+    "registration_success_signin": "Compte créé avec succès ! Veuillez vous connecter.",
+    "login_success_redirecting": "Connexion réussie ! Redirection...",
     "reset_password_subtitle": "Créer un nouveau mot de passe",
     "reset_your_password": "Réinitialisez votre mot de passe",
     "reset_password_form_desc": "Saisissez votre nouveau mot de passe ci-dessous. Il doit comporter au moins 8 caractères.",
diff --git a/static/locales/lb.json b/static/locales/lb.json
index d74f2562..baa03362 100644
--- a/static/locales/lb.json
+++ b/static/locales/lb.json
@@ -142,6 +142,8 @@
     "try_again": "probéiert et nach eng Kéier",
     "remember_password": "Passwuert erëm agefall?",
     "login_subtitle": "Wëllkomm zréck an Ärem Kont",
+    "registration_success_signin": "Kont erfollegräich erstallt! Loggt Iech w.e.g. an.",
+    "login_success_redirecting": "Login erfollegräich! Weiderleeden...",
     "reset_password_subtitle": "Neit Passwuert erstellen",
     "reset_your_password": "Ärt Passwuert zrécksetzen",
     "reset_password_form_desc": "Gitt hei drënner Ärt neit Passwuert an. Et muss mindestens 8 Zeechen laang sinn.",