fix: add Pydantic models for customer/inventory endpoints and align JS rules

- Add Pydantic response models for vendor customer endpoints
- Add InventoryMessageResponse for delete endpoint
- Align JS rule IDs between YAML and validation script (JS-001=logger, JS-002=apiClient)
- Add exception for init-*.js files in console logging check

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
2025-12-04 23:38:12 +01:00
parent 81bfc49f77
commit d2063f6dad
6 changed files with 159 additions and 67 deletions

View File

@@ -15,12 +15,20 @@ from app.api.deps import get_current_vendor_api
from app.core.database import get_db
from app.services.vendor_service import vendor_service
from models.database.user import User
from models.schema.customer import (
CustomerDetailResponse,
CustomerMessageResponse,
CustomerOrdersResponse,
CustomerStatisticsResponse,
CustomerUpdate,
VendorCustomerListResponse,
)
router = APIRouter(prefix="/customers")
logger = logging.getLogger(__name__)
@router.get("")
@router.get("", response_model=VendorCustomerListResponse)
def get_vendor_customers(
skip: int = Query(0, ge=0),
limit: int = Query(100, ge=1, le=1000),
@@ -39,16 +47,16 @@ def get_vendor_customers(
- Return paginated results
"""
vendor = vendor_service.get_vendor_by_id(db, current_user.token_vendor_id) # noqa: F841
return {
"customers": [],
"total": 0,
"skip": skip,
"limit": limit,
"message": "Customer management coming in Slice 4",
}
return VendorCustomerListResponse(
customers=[],
total=0,
skip=skip,
limit=limit,
message="Customer management coming in Slice 4",
)
@router.get("/{customer_id}")
@router.get("/{customer_id}", response_model=CustomerDetailResponse)
def get_customer_details(
customer_id: int,
current_user: User = Depends(get_current_vendor_api),
@@ -64,10 +72,10 @@ def get_customer_details(
- Include total spent, etc.
"""
vendor = vendor_service.get_vendor_by_id(db, current_user.token_vendor_id) # noqa: F841
return {"message": "Customer details coming in Slice 4"}
return CustomerDetailResponse(message="Customer details coming in Slice 4")
@router.get("/{customer_id}/orders")
@router.get("/{customer_id}/orders", response_model=CustomerOrdersResponse)
def get_customer_orders(
customer_id: int,
current_user: User = Depends(get_current_vendor_api),
@@ -82,13 +90,13 @@ def get_customer_orders(
- Return order details
"""
vendor = vendor_service.get_vendor_by_id(db, current_user.token_vendor_id) # noqa: F841
return {"orders": [], "message": "Customer orders coming in Slice 5"}
return CustomerOrdersResponse(orders=[], message="Customer orders coming in Slice 5")
@router.put("/{customer_id}")
@router.put("/{customer_id}", response_model=CustomerMessageResponse)
def update_customer(
customer_id: int,
customer_data: dict,
customer_data: CustomerUpdate,
current_user: User = Depends(get_current_vendor_api),
db: Session = Depends(get_db),
):
@@ -101,10 +109,10 @@ def update_customer(
- Update customer preferences
"""
vendor = vendor_service.get_vendor_by_id(db, current_user.token_vendor_id) # noqa: F841
return {"message": "Customer update coming in Slice 4"}
return CustomerMessageResponse(message="Customer update coming in Slice 4")
@router.put("/{customer_id}/status")
@router.put("/{customer_id}/status", response_model=CustomerMessageResponse)
def toggle_customer_status(
customer_id: int,
current_user: User = Depends(get_current_vendor_api),
@@ -119,10 +127,10 @@ def toggle_customer_status(
- Log the change
"""
vendor = vendor_service.get_vendor_by_id(db, current_user.token_vendor_id) # noqa: F841
return {"message": "Customer status toggle coming in Slice 4"}
return CustomerMessageResponse(message="Customer status toggle coming in Slice 4")
@router.get("/{customer_id}/stats")
@router.get("/{customer_id}/stats", response_model=CustomerStatisticsResponse)
def get_customer_statistics(
customer_id: int,
current_user: User = Depends(get_current_vendor_api),
@@ -138,10 +146,10 @@ def get_customer_statistics(
- Last order date
"""
vendor = vendor_service.get_vendor_by_id(db, current_user.token_vendor_id) # noqa: F841
return {
"total_orders": 0,
"total_spent": 0.0,
"average_order_value": 0.0,
"last_order_date": None,
"message": "Customer statistics coming in Slice 4",
}
return CustomerStatisticsResponse(
total_orders=0,
total_spent=0.0,
average_order_value=0.0,
last_order_date=None,
message="Customer statistics coming in Slice 4",
)

View File

@@ -18,6 +18,7 @@ from models.schema.inventory import (
InventoryAdjust,
InventoryCreate,
InventoryListResponse,
InventoryMessageResponse,
InventoryReserve,
InventoryResponse,
InventoryUpdate,
@@ -123,7 +124,7 @@ def update_inventory(
)
@router.delete("/inventory/{inventory_id}")
@router.delete("/inventory/{inventory_id}", response_model=InventoryMessageResponse)
def delete_inventory(
inventory_id: int,
current_user: User = Depends(get_current_vendor_api),
@@ -131,4 +132,4 @@ def delete_inventory(
):
"""Delete inventory entry."""
inventory_service.delete_inventory(db, current_user.token_vendor_id, inventory_id)
return {"message": "Inventory deleted successfully"}
return InventoryMessageResponse(message="Inventory deleted successfully")