fix: resolve architecture warnings (SVC-006, FE-008, FE-004)

- Move db.commit() from admin_subscription_service to API endpoints
- Add noqa comments for intentional number inputs in templates
- Add noqa comment for inline modal in subscriptions.html

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2025-12-25 21:51:10 +01:00
parent d2daf34c90
commit e59f34b5e7
6 changed files with 12 additions and 9 deletions

View File

@@ -73,8 +73,6 @@ class AdminSubscriptionService:
tier = SubscriptionTier(**tier_data)
db.add(tier)
db.commit()
db.refresh(tier)
logger.info(f"Created subscription tier: {tier.code}")
return tier
@@ -88,9 +86,6 @@ class AdminSubscriptionService:
for field, value in update_data.items():
setattr(tier, field, value)
db.commit()
db.refresh(tier)
logger.info(f"Updated subscription tier: {tier.code}")
return tier
@@ -117,7 +112,6 @@ class AdminSubscriptionService:
)
tier.is_active = False
db.commit()
logger.info(f"Soft-deleted subscription tier: {tier.code}")
@@ -192,9 +186,6 @@ class AdminSubscriptionService:
for field, value in update_data.items():
setattr(sub, field, value)
db.commit()
db.refresh(sub)
logger.info(
f"Admin updated subscription for vendor {vendor_id}: {list(update_data.keys())}"
)