fix(lint): auto-fix ruff violations and tune lint rules

- Auto-fixed 4,496 lint issues (import sorting, modern syntax, etc.)
- Added ignore rules for patterns intentional in this codebase:
  E402 (late imports), E712 (SQLAlchemy filters), B904 (raise from),
  SIM108/SIM105/SIM117 (readability preferences)
- Added per-file ignores for tests and scripts
- Excluded broken scripts/rename_terminology.py (has curly quotes)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

app/modules/inventory/services/__init__.py

@@ -5,18 +5,18 @@ Inventory module services.
 This module contains the canonical implementations of inventory-related services.
 """
 
+from app.modules.inventory.services.inventory_import_service import (
+    ImportResult,
+    InventoryImportService,
+    inventory_import_service,
+)
 from app.modules.inventory.services.inventory_service import (
-    inventory_service,
     InventoryService,
+    inventory_service,
 )
 from app.modules.inventory.services.inventory_transaction_service import (
-    inventory_transaction_service,
     InventoryTransactionService,
-)
-from app.modules.inventory.services.inventory_import_service import (
-    inventory_import_service,
-    InventoryImportService,
-    ImportResult,
+    inventory_transaction_service,
 )
 
 __all__ = [

app/modules/inventory/services/inventory_features.py

@@ -13,7 +13,6 @@ from typing import TYPE_CHECKING
 
 from app.modules.contracts.features import (
     FeatureDeclaration,
-    FeatureProviderProtocol,
     FeatureScope,
     FeatureType,
     FeatureUsage,

app/modules/inventory/services/inventory_import_service.py

@@ -23,8 +23,8 @@ from dataclasses import dataclass, field
 
 from sqlalchemy.orm import Session
 
-from app.modules.inventory.models.inventory import Inventory
 from app.modules.catalog.models import Product
+from app.modules.inventory.models.inventory import Inventory
 
 logger = logging.getLogger(__name__)
 
@@ -227,7 +227,7 @@ class InventoryImportService:
             ImportResult with summary and errors
         """
         try:
-            with open(file_path, "r", encoding="utf-8") as f:
+            with open(file_path, encoding="utf-8") as f:
                 content = f.read()
         except Exception as e:
             return ImportResult(success=False, errors=[f"Failed to read file: {e}"])

app/modules/inventory/services/inventory_metrics.py

@@ -15,9 +15,8 @@ from sqlalchemy import func
 from sqlalchemy.orm import Session
 
 from app.modules.contracts.metrics import (
-    MetricValue,
     MetricsContext,
-    MetricsProviderProtocol,
+    MetricValue,
 )
 
 if TYPE_CHECKING:

app/modules/inventory/services/inventory_service.py

@@ -6,14 +6,14 @@ from sqlalchemy import func
 from sqlalchemy.orm import Session
 
 from app.exceptions import ValidationException
+from app.modules.catalog.exceptions import ProductNotFoundException
+from app.modules.catalog.models import Product
 from app.modules.inventory.exceptions import (
     InsufficientInventoryException,
     InvalidQuantityException,
     InventoryNotFoundException,
     InventoryValidationException,
 )
-from app.modules.catalog.exceptions import ProductNotFoundException
-from app.modules.tenancy.exceptions import StoreNotFoundException
 from app.modules.inventory.models.inventory import Inventory
 from app.modules.inventory.schemas.inventory import (
     AdminInventoryItem,
@@ -30,7 +30,7 @@ from app.modules.inventory.schemas.inventory import (
     InventoryUpdate,
     ProductInventorySummary,
 )
-from app.modules.catalog.models import Product
+from app.modules.tenancy.exceptions import StoreNotFoundException
 from app.modules.tenancy.models import Store
 
 logger = logging.getLogger(__name__)
@@ -217,7 +217,7 @@ class InventoryService:
         """
         try:
             # Validate product
-            product = self._get_store_product(db, store_id, reserve_data.product_id)
+            self._get_store_product(db, store_id, reserve_data.product_id)
 
             # Validate location and quantity
             location = self._validate_location(reserve_data.location)
@@ -279,7 +279,7 @@ class InventoryService:
         """
         try:
             # Validate product
-            product = self._get_store_product(db, store_id, reserve_data.product_id)
+            self._get_store_product(db, store_id, reserve_data.product_id)
 
             location = self._validate_location(reserve_data.location)
             self._validate_quantity(reserve_data.quantity, allow_zero=False)
@@ -338,7 +338,7 @@ class InventoryService:
             Updated Inventory object
         """
         try:
-            product = self._get_store_product(db, store_id, reserve_data.product_id)
+            self._get_store_product(db, store_id, reserve_data.product_id)
             location = self._validate_location(reserve_data.location)
             self._validate_quantity(reserve_data.quantity, allow_zero=False)
 

app/modules/inventory/services/inventory_transaction_service.py

@@ -8,15 +8,16 @@ This service handles transaction READS for reporting and auditing.
 """
 
 import logging
+
 from sqlalchemy import func
 from sqlalchemy.orm import Session
 
 from app.modules.catalog.exceptions import ProductNotFoundException
-from app.modules.orders.exceptions import OrderNotFoundException
+from app.modules.catalog.models import Product
 from app.modules.inventory.models.inventory import Inventory
 from app.modules.inventory.models.inventory_transaction import InventoryTransaction
+from app.modules.orders.exceptions import OrderNotFoundException
 from app.modules.orders.models import Order
-from app.modules.catalog.models import Product
 
 logger = logging.getLogger(__name__)
 
@@ -411,7 +412,7 @@ class InventoryTransactionService:
         total = db.query(sql_func.count(InventoryTransaction.id)).scalar() or 0
 
         # Transactions today
-        from datetime import UTC, datetime, timedelta
+        from datetime import UTC, datetime
 
         today_start = datetime.now(UTC).replace(hour=0, minute=0, second=0, microsecond=0)
         today_count = (