fix(lint): auto-fix ruff violations and tune lint rules

- Auto-fixed 4,496 lint issues (import sorting, modern syntax, etc.)
- Added ignore rules for patterns intentional in this codebase:
  E402 (late imports), E712 (SQLAlchemy filters), B904 (raise from),
  SIM108/SIM105/SIM117 (readability preferences)
- Added per-file ignores for tests and scripts
- Excluded broken scripts/rename_terminology.py (has curly quotes)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

tests/fixtures/admin_platform_fixtures.py

@@ -9,9 +9,7 @@ import uuid
 
 import pytest
 
-from app.modules.tenancy.models import AdminPlatform
-from app.modules.tenancy.models import Platform
-from app.modules.tenancy.models import User
+from app.modules.tenancy.models import AdminPlatform, Platform, User
 
 
 @pytest.fixture

tests/fixtures/auth_fixtures.py

@@ -10,8 +10,8 @@ import uuid
 
 import pytest
 
-from middleware.auth import AuthManager
 from app.modules.tenancy.models import User
+from middleware.auth import AuthManager
 
 
 @pytest.fixture(scope="session")

tests/fixtures/customer_fixtures.py

@@ -6,6 +6,8 @@ Note: Fixtures should NOT use db.expunge() as it breaks lazy loading.
 See tests/conftest.py for details on fixture best practices.
 """
 
+from datetime import UTC
+
 import pytest
 
 from app.modules.customers.models.customer import Customer, CustomerAddress
@@ -104,7 +106,7 @@ def test_customer_multiple_addresses(db, test_store, test_customer):
 @pytest.fixture
 def test_order(db, test_store, test_customer, test_customer_address):
     """Create a test order with customer/address snapshots."""
-    from datetime import datetime, timezone
+    from datetime import datetime
 
     order = Order(
         store_id=test_store.id,
@@ -115,7 +117,7 @@ def test_order(db, test_store, test_customer, test_customer_address):
         subtotal=99.99,
         total_amount=99.99,
         currency="EUR",
-        order_date=datetime.now(timezone.utc),
+        order_date=datetime.now(UTC),
         # Customer snapshot
         customer_first_name=test_customer.first_name,
         customer_last_name=test_customer.last_name,

tests/fixtures/message_fixtures.py

@@ -6,6 +6,8 @@ Note: Fixtures should NOT use db.expunge() as it breaks lazy loading.
 See tests/conftest.py for details on fixture best practices.
 """
 
+from datetime import UTC
+
 import pytest
 
 from app.modules.messaging.models import (
@@ -171,14 +173,14 @@ def test_message_with_attachment(db, test_conversation_admin_store, test_admin):
 @pytest.fixture
 def closed_conversation(db, test_admin, test_store_user, test_store):
     """Create a closed conversation."""
-    from datetime import datetime, timezone
+    from datetime import datetime
 
     conversation = Conversation(
         conversation_type=ConversationType.ADMIN_STORE,
         subject="Closed Conversation",
         store_id=test_store.id,
         is_closed=True,
-        closed_at=datetime.now(timezone.utc),
+        closed_at=datetime.now(UTC),
         closed_by_type=ParticipantType.ADMIN,
         closed_by_id=test_admin.id,
     )
@@ -314,14 +316,14 @@ def store_api_conversation(db, test_admin, test_store_user, test_store_with_stor
 @pytest.fixture
 def store_api_closed_conversation(db, test_admin, test_store_user, test_store_with_store_user):
     """Create a closed conversation for store API tests."""
-    from datetime import datetime, timezone
+    from datetime import datetime
 
     conversation = Conversation(
         conversation_type=ConversationType.ADMIN_STORE,
         subject="Store API Closed Conversation",
         store_id=test_store_with_store_user.id,
         is_closed=True,
-        closed_at=datetime.now(timezone.utc),
+        closed_at=datetime.now(UTC),
         closed_by_type=ParticipantType.ADMIN,
         closed_by_id=test_admin.id,
     )

tests/fixtures/module_fixtures.py

@@ -7,12 +7,11 @@ and access control.
 """
 
 import uuid
-from datetime import datetime, timezone
+from datetime import UTC, datetime
 
 import pytest
 
-from app.modules.tenancy.models import Platform
-from app.modules.tenancy.models import PlatformModule
+from app.modules.tenancy.models import Platform, PlatformModule
 
 
 @pytest.fixture
@@ -39,7 +38,7 @@ def platform_with_modules(db, test_super_admin):
             platform_id=platform.id,
             module_code=module_code,
             is_enabled=True,
-            enabled_at=datetime.now(timezone.utc),
+            enabled_at=datetime.now(UTC),
             enabled_by_user_id=test_super_admin.id,
             config={},
         )
@@ -50,7 +49,7 @@ def platform_with_modules(db, test_super_admin):
         platform_id=platform.id,
         module_code="marketplace",
         is_enabled=False,
-        disabled_at=datetime.now(timezone.utc),
+        disabled_at=datetime.now(UTC),
         disabled_by_user_id=test_super_admin.id,
         config={},
     )
@@ -83,7 +82,7 @@ def platform_with_config(db, test_super_admin):
         platform_id=platform.id,
         module_code="billing",
         is_enabled=True,
-        enabled_at=datetime.now(timezone.utc),
+        enabled_at=datetime.now(UTC),
         enabled_by_user_id=test_super_admin.id,
         config={
             "stripe_mode": "test",
@@ -98,7 +97,7 @@ def platform_with_config(db, test_super_admin):
         platform_id=platform.id,
         module_code="inventory",
         is_enabled=True,
-        enabled_at=datetime.now(timezone.utc),
+        enabled_at=datetime.now(UTC),
         enabled_by_user_id=test_super_admin.id,
         config={
             "low_stock_threshold": 5,
@@ -146,9 +145,9 @@ def module_factory(db, test_super_admin):
             platform_id=platform_id,
             module_code=module_code,
             is_enabled=is_enabled,
-            enabled_at=datetime.now(timezone.utc) if is_enabled else None,
+            enabled_at=datetime.now(UTC) if is_enabled else None,
             enabled_by_user_id=test_super_admin.id if is_enabled else None,
-            disabled_at=None if is_enabled else datetime.now(timezone.utc),
+            disabled_at=None if is_enabled else datetime.now(UTC),
             disabled_by_user_id=None if is_enabled else test_super_admin.id,
             config=config or {},
         )

tests/fixtures/store_fixtures.py

@@ -10,10 +10,9 @@ import uuid
 
 import pytest
 
-from app.modules.tenancy.models import Merchant
-from app.modules.inventory.models import Inventory
 from app.modules.catalog.models import Product
-from app.modules.tenancy.models import Store
+from app.modules.inventory.models import Inventory
+from app.modules.tenancy.models import Merchant, Store
 
 
 @pytest.fixture

tests/integration/api/v1/admin/test_email_settings.py

@@ -5,7 +5,6 @@ import pytest
 
 from app.modules.tenancy.models import AdminSetting
 
-
 # =============================================================================
 # GET EMAIL STATUS TESTS
 # =============================================================================

tests/integration/api/v1/store/test_messages.py

@@ -7,8 +7,6 @@ Tests the /api/v1/store/messages/* endpoints.
 
 import pytest
 
-from app.modules.messaging.models import ConversationType, ParticipantType
-
 
 @pytest.mark.integration
 @pytest.mark.api

tests/integration/api/v1/store/test_onboarding.py

@@ -14,7 +14,11 @@ Tests cover:
 
 import pytest
 
-from app.modules.marketplace.models import OnboardingStatus, OnboardingStep, StoreOnboarding
+from app.modules.marketplace.models import (
+    OnboardingStatus,
+    OnboardingStep,
+    StoreOnboarding,
+)
 
 
 @pytest.mark.integration

tests/integration/middleware/conftest.py

@@ -18,20 +18,20 @@ import pytest
 from fastapi.testclient import TestClient
 
 from app.core.database import get_db
-from main import app
-from app.modules.tenancy.models import Merchant
-from app.modules.tenancy.models import Store
-from app.modules.tenancy.models import StoreDomain
 from app.modules.cms.models import StoreTheme
+from app.modules.tenancy.models import Merchant, Store, StoreDomain
+from main import app
 
 # Register test routes for middleware tests
 from tests.integration.middleware.middleware_test_routes import (
     admin_router,
     api_router,
-    router as test_router,
     shop_router,
     store_router,
 )
+from tests.integration.middleware.middleware_test_routes import (
+    router as test_router,
+)
 
 # Include the test routers in the app (only once)
 if not any(r.path.startswith("/middleware-test") for r in app.routes if hasattr(r, "path")):

tests/integration/middleware/test_merchant_domain_flow.py

@@ -15,7 +15,7 @@ from datetime import UTC, datetime
 
 import pytest
 
-from app.modules.tenancy.models import Merchant, Store, StoreDomain
+from app.modules.tenancy.models import Store, StoreDomain
 from app.modules.tenancy.models.merchant_domain import MerchantDomain
 
 

tests/unit/middleware/test_logging.py

@@ -67,7 +67,7 @@ class TestLoggingMiddleware:
         call_next = AsyncMock(return_value=response)
 
         with patch("middleware.logging.logger") as mock_logger:
-            result = await middleware.dispatch(request, call_next)
+            await middleware.dispatch(request, call_next)
 
             # Verify response was logged
             assert mock_logger.info.call_count >= 2  # Request + Response
@@ -91,7 +91,7 @@ class TestLoggingMiddleware:
         call_next = AsyncMock(return_value=response)
 
         with patch("middleware.logging.logger"):
-            result = await middleware.dispatch(request, call_next)
+            await middleware.dispatch(request, call_next)
 
         assert "X-Process-Time" in response.headers
         # Should be a numeric string
@@ -187,7 +187,7 @@ class TestLoggingEdgeCases:
         call_next = AsyncMock(return_value=response)
 
         with patch("middleware.logging.logger"):
-            result = await middleware.dispatch(request, call_next)
+            await middleware.dispatch(request, call_next)
 
         # Should still have process time, even if very small
         assert "X-Process-Time" in response.headers

tests/unit/middleware/test_merchant_domain_resolution.py

@@ -11,16 +11,14 @@ Tests cover:
 
 import uuid
 from datetime import UTC, datetime
-from unittest.mock import Mock
 
 import pytest
 
-from app.modules.tenancy.models import Platform, Store, StoreDomain
+from app.modules.tenancy.models import Store, StoreDomain
 from app.modules.tenancy.models.merchant_domain import MerchantDomain
 from middleware.platform_context import PlatformContextManager
 from middleware.store_context import StoreContextManager
 
-
 # =============================================================================
 # PLATFORM CONTEXT - MERCHANT DOMAIN RESOLUTION
 # =============================================================================

tests/unit/modules/test_module_definitions.py

@@ -11,8 +11,8 @@ Tests cover:
 
 import pytest
 
+from app.modules.base import PermissionDefinition
 from app.modules.registry import MODULES
-from app.modules.base import ModuleDefinition, PermissionDefinition
 
 
 @pytest.mark.unit
@@ -156,7 +156,7 @@ class TestModuleRouterPattern:
         """Test that modules can have router attributes attached."""
         # After calling get_*_with_routers(), modules should have router attrs
         # This test just verifies the attribute exists (may be None)
-        for code, module in MODULES.items():
+        for _code, module in MODULES.items():
             # These are optional attributes set by get_*_with_routers()
             # Just verify they can be accessed without error
             _ = getattr(module, "admin_router", None)

tests/unit/services/test_admin_notification_service.py

@@ -15,8 +15,6 @@ from app.modules.messaging.services.admin_notification_service import (
     Priority,
     Severity,
 )
-from app.modules.messaging.models import AdminNotification
-from app.modules.tenancy.models import PlatformAlert
 
 
 @pytest.fixture
@@ -260,7 +258,7 @@ class TestAdminNotificationServiceQuery:
 
     def test_get_notifications_filter_read(self, db, notification_service, test_admin):
         """Test filtering by read status."""
-        n1 = notification_service.create_notification(
+        notification_service.create_notification(
             db=db,
             notification_type=NotificationType.SYSTEM_ALERT,
             title="Unread",
@@ -602,13 +600,13 @@ class TestPlatformAlertServiceQuery:
     def test_get_statistics(self, db, alert_service, test_admin):
         """Test getting alert statistics."""
         # Create some alerts
-        alert1 = alert_service.create_alert(
+        alert_service.create_alert(
             db=db,
             alert_type=AlertType.SYSTEM,
             severity=Severity.WARNING,
             title="Active Warning",
         )
-        alert2 = alert_service.create_alert(
+        alert_service.create_alert(
             db=db,
             alert_type=AlertType.SECURITY,
             severity=Severity.CRITICAL,

tests/unit/services/test_admin_service.py

@@ -2,17 +2,17 @@
 import pytest
 
 from app.exceptions import ValidationException
+from app.modules.analytics.services.stats_service import stats_service
 from app.modules.tenancy.exceptions import (
     AdminOperationException,
     CannotModifySelfException,
-    UserNotFoundException,
-    UserStatusChangeException,
     StoreAlreadyExistsException,
     StoreNotFoundException,
+    UserNotFoundException,
+    UserStatusChangeException,
 )
-from app.modules.tenancy.services.admin_service import AdminService
-from app.modules.analytics.services.stats_service import stats_service
 from app.modules.tenancy.schemas.store import StoreCreate
+from app.modules.tenancy.services.admin_service import AdminService
 
 
 @pytest.mark.unit
@@ -193,7 +193,7 @@ class TestAdminService:
         assert isinstance(stats["total_users"], int)
         assert isinstance(stats["active_users"], int)
         assert isinstance(stats["inactive_users"], int)
-        assert isinstance(stats["activation_rate"], (int, float))
+        assert isinstance(stats["activation_rate"], int | float)
 
         assert stats["total_users"] >= 2  # test_user + test_admin
         assert stats["active_users"] + stats["inactive_users"] == stats["total_users"]
@@ -210,7 +210,7 @@ class TestAdminService:
         assert isinstance(stats["total_stores"], int)
         assert isinstance(stats["active_stores"], int)
         assert isinstance(stats["verified_stores"], int)
-        assert isinstance(stats["verification_rate"], (int, float))
+        assert isinstance(stats["verification_rate"], int | float)
 
         assert stats["total_stores"] >= 1
 

tests/unit/services/test_auth_service.py

@@ -3,11 +3,11 @@
 
 import pytest
 
+from app.modules.core.services.auth_service import AuthService
 from app.modules.tenancy.exceptions import (
     InvalidCredentialsException,
     UserNotActiveException,
 )
-from app.modules.core.services.auth_service import AuthService
 from models.schema.auth import UserLogin
 
 

tests/unit/services/test_inventory_service.py

@@ -5,14 +5,13 @@ import uuid
 
 import pytest
 
+from app.modules.catalog.exceptions import ProductNotFoundException
 from app.modules.inventory.exceptions import (
     InsufficientInventoryException,
     InvalidQuantityException,
     InventoryNotFoundException,
     InventoryValidationException,
 )
-from app.modules.catalog.exceptions import ProductNotFoundException
-from app.modules.inventory.services.inventory_service import InventoryService
 from app.modules.inventory.models import Inventory
 from app.modules.inventory.schemas import (
     InventoryAdjust,
@@ -20,6 +19,7 @@ from app.modules.inventory.schemas import (
     InventoryReserve,
     InventoryUpdate,
 )
+from app.modules.inventory.services.inventory_service import InventoryService
 
 
 @pytest.mark.unit
@@ -363,9 +363,11 @@ class TestInventoryService:
     def test_get_product_inventory_no_inventory(self, db, test_product, test_store):
         """Test getting inventory for product with no inventory entries."""
         # Create a new product without inventory
-        from app.modules.marketplace.models import MarketplaceProduct
-        from app.modules.marketplace.models import MarketplaceProductTranslation
         from app.modules.catalog.models import Product
+        from app.modules.marketplace.models import (
+            MarketplaceProduct,
+            MarketplaceProductTranslation,
+        )
 
         unique_id = str(uuid.uuid4())[:8]
         mp = MarketplaceProduct(

tests/unit/services/test_marketplace_service.py

@@ -10,10 +10,12 @@ from app.modules.marketplace.exceptions import (
     ImportJobNotFoundException,
     ImportJobNotOwnedException,
 )
-from app.modules.tenancy.exceptions import UnauthorizedStoreAccessException
-from app.modules.marketplace.services.marketplace_import_job_service import MarketplaceImportJobService
 from app.modules.marketplace.models import MarketplaceImportJob
 from app.modules.marketplace.schemas import MarketplaceImportJobRequest
+from app.modules.marketplace.services.marketplace_import_job_service import (
+    MarketplaceImportJobService,
+)
+from app.modules.tenancy.exceptions import UnauthorizedStoreAccessException
 
 
 @pytest.mark.unit
@@ -300,7 +302,7 @@ class TestMarketplaceImportJobService:
         self, db, test_store, test_user
     ):
         """Test converting model with all fields populated."""
-        unique_id = str(uuid.uuid4())[:8]
+        str(uuid.uuid4())[:8]
         from datetime import datetime
 
         job = MarketplaceImportJob(

tests/unit/services/test_order_item_exception_service.py

@@ -3,15 +3,15 @@
 
 import pytest
 
+from app.modules.catalog.exceptions import ProductNotFoundException
 from app.modules.orders.exceptions import (
     ExceptionAlreadyResolvedException,
-    InvalidProductForExceptionException,
     OrderItemExceptionNotFoundException,
 )
-from app.modules.catalog.exceptions import ProductNotFoundException
-from app.modules.orders.services.order_item_exception_service import OrderItemExceptionService
 from app.modules.orders.models import OrderItem
-from app.modules.orders.models import OrderItemException
+from app.modules.orders.services.order_item_exception_service import (
+    OrderItemExceptionService,
+)
 
 
 @pytest.fixture

tests/unit/services/test_order_service.py

@@ -12,22 +12,17 @@ Tests cover:
 """
 
 from datetime import UTC, datetime
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
 
 import pytest
 
-from app.exceptions import ValidationException
-from app.modules.customers.exceptions import CustomerNotFoundException
 from app.modules.orders.exceptions import OrderNotFoundException
+from app.modules.orders.models import Order
 from app.modules.orders.services.order_service import (
     PLACEHOLDER_GTIN,
-    PLACEHOLDER_MARKETPLACE_ID,
     OrderService,
     order_service,
 )
-from app.modules.customers.models.customer import Customer
-from app.modules.orders.models import Order, OrderItem
-
 
 # Default address fields required by Order model
 DEFAULT_ADDRESS = {

tests/unit/services/test_platform_service.py

@@ -5,11 +5,12 @@ import uuid
 
 import pytest
 
-from app.modules.tenancy.exceptions import PlatformNotFoundException
-from app.modules.tenancy.services.platform_service import platform_service, PlatformStats
-from app.modules.tenancy.models import Platform, StorePlatform
 from app.modules.cms.models import ContentPage
-
+from app.modules.tenancy.exceptions import PlatformNotFoundException
+from app.modules.tenancy.models import Platform, StorePlatform
+from app.modules.tenancy.services.platform_service import (
+    platform_service,
+)
 
 # =============================================================================
 # FIXTURES

tests/unit/services/test_stats_service.py

@@ -7,13 +7,16 @@ from unittest.mock import patch
 import pytest
 from sqlalchemy.exc import SQLAlchemyError
 
-from app.modules.tenancy.exceptions import AdminOperationException, StoreNotFoundException
 from app.modules.analytics.services.stats_service import StatsService
 from app.modules.inventory.models import Inventory
 from app.modules.marketplace.models import (
     MarketplaceProduct,
     MarketplaceProductTranslation,
 )
+from app.modules.tenancy.exceptions import (
+    AdminOperationException,
+    StoreNotFoundException,
+)
 
 
 def create_marketplace_product_with_translation(

tests/unit/services/test_store_email_settings_service.py

@@ -1,19 +1,21 @@
 # tests/unit/services/test_store_email_settings_service.py
 """Unit tests for StoreEmailSettingsService."""
 
+from datetime import UTC, datetime
+from unittest.mock import MagicMock, patch
+
 import pytest
-from datetime import datetime, timezone
-from unittest.mock import patch, MagicMock
 
 from app.exceptions import (
     AuthorizationException,
     ResourceNotFoundException,
     ValidationException,
 )
-from app.modules.cms.services.store_email_settings_service import store_email_settings_service
-from app.modules.messaging.models import StoreEmailSettings
 from app.modules.billing.models import TierCode
-
+from app.modules.cms.services.store_email_settings_service import (
+    store_email_settings_service,
+)
+from app.modules.messaging.models import StoreEmailSettings
 
 # =============================================================================
 # FIXTURES
@@ -58,7 +60,7 @@ def test_verified_email_settings(db, test_store):
         smtp_use_tls=True,
         is_configured=True,
         is_verified=True,
-        last_verified_at=datetime.now(timezone.utc),
+        last_verified_at=datetime.now(UTC),
     )
     db.add(settings)
     db.commit()

tests/unit/utils/test_csv_processor.py

@@ -8,8 +8,8 @@ import pytest
 import requests
 import requests.exceptions
 
-from app.utils.csv_processor import CSVProcessor
 from app.modules.marketplace.models import MarketplaceProduct
+from app.utils.csv_processor import CSVProcessor
 
 
 @pytest.mark.unit

tests/unit/utils/test_i18n.py

@@ -30,8 +30,8 @@ from app.utils.i18n import (
     is_rtl_language,
     load_translations,
     parse_accept_language,
-    resolve_storefront_language,
     resolve_store_dashboard_language,
+    resolve_storefront_language,
     t,
     translate,
 )

tests/unit/utils/test_vat.py

@@ -3,12 +3,9 @@
 
 from decimal import Decimal
 
-import pytest
-
 from app.utils.vat import (
     EU_VAT_RATES,
     VATRegime,
-    VATResult,
     calculate_vat_amount,
     determine_vat_regime,
     get_vat_rate_for_country,