Samir Boulahtit
d7a0ff8818
This commit completes the migration to a fully module-driven architecture: ## Models Migration - Moved all domain models from models/database/ to their respective modules: - tenancy: User, Admin, Vendor, Company, Platform, VendorDomain, etc. - cms: MediaFile, VendorTheme - messaging: Email, VendorEmailSettings, VendorEmailTemplate - core: AdminMenuConfig - models/database/ now only contains Base and TimestampMixin (infrastructure) ## Schemas Migration - Moved all domain schemas from models/schema/ to their respective modules: - tenancy: company, vendor, admin, team, vendor_domain - cms: media, image, vendor_theme - messaging: email - models/schema/ now only contains base.py and auth.py (infrastructure) ## Routes Migration - Moved admin routes from app/api/v1/admin/ to modules: - menu_config.py -> core module - modules.py -> tenancy module - module_config.py -> tenancy module - app/api/v1/admin/ now only aggregates auto-discovered module routes ## Menu System - Implemented module-driven menu system with MenuDiscoveryService - Extended FrontendType enum: PLATFORM, ADMIN, VENDOR, STOREFRONT - Added MenuItemDefinition and MenuSectionDefinition dataclasses - Each module now defines its own menu items in definition.py - MenuService integrates with MenuDiscoveryService for template rendering ## Documentation - Updated docs/architecture/models-structure.md - Updated docs/architecture/menu-management.md - Updated architecture validation rules for new exceptions ## Architecture Validation - Updated MOD-019 rule to allow base.py in models/schema/ - Created core module exceptions.py and schemas/ directory - All validation errors resolved (only warnings remain) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
125 lines
4.3 KiB
Python
125 lines
4.3 KiB
Python
# tests/unit/services/test_auth_service.py
|
|
"""Unit tests for AuthService - login and password hashing."""
|
|
|
|
import pytest
|
|
|
|
from app.modules.tenancy.exceptions import (
|
|
InvalidCredentialsException,
|
|
UserNotActiveException,
|
|
)
|
|
from app.modules.core.services.auth_service import AuthService
|
|
from models.schema.auth import UserLogin
|
|
|
|
|
|
@pytest.mark.unit
|
|
@pytest.mark.auth
|
|
class TestAuthService:
|
|
"""Test suite for AuthService."""
|
|
|
|
def setup_method(self):
|
|
"""Setup method."""
|
|
self.service = AuthService()
|
|
|
|
def test_login_user_success(self, db, test_user):
|
|
"""Test successful user login."""
|
|
user_credentials = UserLogin(
|
|
email_or_username=test_user.username, password="testpass123"
|
|
)
|
|
|
|
result = self.service.login_user(db, user_credentials)
|
|
|
|
assert "token_data" in result
|
|
assert "user" in result
|
|
assert result["user"].id == test_user.id
|
|
assert result["user"].username == test_user.username
|
|
assert "access_token" in result["token_data"]
|
|
assert "token_type" in result["token_data"]
|
|
assert "expires_in" in result["token_data"]
|
|
|
|
def test_login_user_with_email(self, db, test_user):
|
|
"""Test login with email instead of username."""
|
|
user_credentials = UserLogin(
|
|
email_or_username=test_user.email, password="testpass123"
|
|
)
|
|
|
|
result = self.service.login_user(db, user_credentials)
|
|
|
|
assert result["user"].id == test_user.id
|
|
assert "access_token" in result["token_data"]
|
|
|
|
def test_login_user_wrong_username(self, db):
|
|
"""Test login fails with wrong username."""
|
|
user_credentials = UserLogin(
|
|
email_or_username="nonexistentuser", password="testpass123"
|
|
)
|
|
|
|
with pytest.raises(InvalidCredentialsException) as exc_info:
|
|
self.service.login_user(db, user_credentials)
|
|
|
|
exception = exc_info.value
|
|
assert exception.error_code == "INVALID_CREDENTIALS"
|
|
assert exception.status_code == 401
|
|
assert "Incorrect username or password" in exception.message
|
|
|
|
def test_login_user_wrong_password(self, db, test_user):
|
|
"""Test login fails with wrong password."""
|
|
user_credentials = UserLogin(
|
|
email_or_username=test_user.username, password="wrongpassword"
|
|
)
|
|
|
|
with pytest.raises(InvalidCredentialsException) as exc_info:
|
|
self.service.login_user(db, user_credentials)
|
|
|
|
exception = exc_info.value
|
|
assert exception.error_code == "INVALID_CREDENTIALS"
|
|
assert exception.status_code == 401
|
|
assert "Incorrect username or password" in exception.message
|
|
|
|
def test_login_user_inactive_user(self, db, test_user):
|
|
"""Test login fails for inactive user."""
|
|
from app.modules.tenancy.models import User
|
|
|
|
# Re-query user and deactivate
|
|
user = db.query(User).filter(User.id == test_user.id).first()
|
|
user.is_active = False
|
|
db.commit()
|
|
|
|
user_credentials = UserLogin(
|
|
email_or_username=test_user.username, password="testpass123"
|
|
)
|
|
|
|
with pytest.raises(UserNotActiveException) as exc_info:
|
|
self.service.login_user(db, user_credentials)
|
|
|
|
exception = exc_info.value
|
|
assert exception.error_code == "USER_NOT_ACTIVE"
|
|
assert exception.status_code == 403
|
|
assert "User account is not active" in exception.message
|
|
|
|
# Reactivate for cleanup
|
|
user.is_active = True
|
|
db.commit()
|
|
|
|
def test_hash_password(self):
|
|
"""Test password hashing."""
|
|
password = "testpassword123"
|
|
hashed = self.service.hash_password(password)
|
|
|
|
assert hashed != password
|
|
assert len(hashed) > len(password)
|
|
assert hashed.startswith("$") # bcrypt hash format
|
|
|
|
def test_hash_password_different_results(self):
|
|
"""Test that hashing same password produces different hashes (salt)."""
|
|
password = "testpassword123"
|
|
hash1 = self.service.hash_password(password)
|
|
hash2 = self.service.hash_password(password)
|
|
|
|
assert hash1 != hash2 # Should be different due to salt
|
|
|
|
def test_get_vendor_by_code_not_found(self, db):
|
|
"""Test getting vendor by non-existent code returns None."""
|
|
vendor = self.service.get_vendor_by_code(db, "NONEXISTENT")
|
|
|
|
assert vendor is None
|