Files
orion/alembic/env.py
Samir Boulahtit c100d839f1 feat: implement persistent cart with database storage and proper exception handling
Implemented a complete shopping cart system with database persistence,
replacing the previous stub implementation. The cart now properly stores
items across sessions and follows the project's architecture patterns.

Database Changes:
- Add cart_items table with vendor_id, session_id, product_id, quantity, price_at_add
- Create unique constraint to prevent duplicate items per session
- Add indexes for session lookups and old cart cleanup
- Run migration a2064e1dfcd4 to create cart_items table

New Models & Schemas:
- models/database/cart.py: CartItem SQLAlchemy model with relationships
- models/schema/cart.py: Pydantic schemas for requests/responses
  * AddToCartRequest, UpdateCartItemRequest
  * CartResponse, CartItemResponse, CartOperationResponse, ClearCartResponse

Exception Handling:
- app/exceptions/cart.py: Cart-specific exceptions following project patterns
  * CartItemNotFoundException - item not found in cart
  * InsufficientInventoryForCartException - not enough inventory for cart operation
  * InvalidCartQuantityException - invalid quantity validation
  * CartValidationException - general cart validation
  * EmptyCartException - operations on empty cart
  * ProductNotAvailableForCartException - product unavailable
- Updated app/exceptions/__init__.py to export cart exceptions

Service Layer:
- Implement cart_service.get_cart() - fetch cart from database with totals
- Implement cart_service.add_to_cart() - create or update cart items with inventory checks
- Implement cart_service.update_cart_item() - update quantity with validation
- Implement cart_service.remove_from_cart() - delete cart item
- Implement cart_service.clear_cart() - remove all items for session
- Replace generic exceptions with cart-specific ones
- Fix InsufficientInventoryException usage (was using wrong parameters)

API Layer:
- Update app/api/v1/shop/cart.py to use Pydantic schemas
- Add response_model declarations to all endpoints
- Add return type hints for type safety
- Convert service dict responses to Pydantic models

Features:
- Cart items persist in database across server restarts
- Inventory validation before adding/updating items
- Price captured at time of adding to cart
- Duplicate items update quantity instead of creating new entries
- Full CRUD operations with proper error handling
- Type-safe API with auto-generated OpenAPI documentation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-23 20:17:16 +01:00

268 lines
8.4 KiB
Python

# alembic/env.py
"""
Alembic migration environment configuration.
This file is responsible for:
1. Importing ALL database models so Alembic can detect schema changes
2. Configuring the database connection
3. Running migrations in online/offline mode
CRITICAL: Every model in models/database/__init__.py must be imported here!
"""
import os
import sys
from logging.config import fileConfig
from sqlalchemy import engine_from_config, pool
from alembic import context
# Add your project directory to the Python path
sys.path.append(os.path.dirname(os.path.dirname(__file__)))
from app.core.config import settings
from models.database.base import Base
# ============================================================================
# IMPORT ALL DATABASE MODELS
# ============================================================================
# CRITICAL: Every model must be imported here so Alembic can detect tables!
# If a model is not imported, Alembic will not create/update its table.
#
# Models list must match: models/database/__init__.py
# ============================================================================
print("[ALEMBIC] Importing database models...")
print("=" * 70)
# ----------------------------------------------------------------------------
# ADMIN MODELS
# ----------------------------------------------------------------------------
try:
from models.database.admin import (
AdminAuditLog,
AdminNotification,
AdminSetting,
PlatformAlert,
AdminSession
)
print(" ✓ Admin models imported (5 models)")
print(" - AdminAuditLog")
print(" - AdminNotification")
print(" - AdminSetting")
print(" - PlatformAlert")
print(" - AdminSession")
except ImportError as e:
print(f" ✗ Admin models failed: {e}")
# ----------------------------------------------------------------------------
# USER MODEL
# ----------------------------------------------------------------------------
try:
from models.database.user import User
print(" ✓ User model imported")
except ImportError as e:
print(f" ✗ User model failed: {e}")
# ----------------------------------------------------------------------------
# VENDOR MODELS
# ----------------------------------------------------------------------------
try:
from models.database.vendor import Vendor, VendorUser, Role
print(" ✓ Vendor models imported (3 models)")
print(" - Vendor")
print(" - VendorUser")
print(" - Role")
except ImportError as e:
print(f" ✗ Vendor models failed: {e}")
try:
from models.database.vendor_domain import VendorDomain
print(" ✓ VendorDomain model imported")
except ImportError as e:
print(f" ✗ VendorDomain model failed: {e}")
try:
from models.database.vendor_theme import VendorTheme
print(" ✓ VendorTheme model imported")
except ImportError as e:
print(f" ✗ VendorTheme model failed: {e}")
# ----------------------------------------------------------------------------
# CONTENT PAGE MODEL (CMS)
# ----------------------------------------------------------------------------
try:
from models.database.content_page import ContentPage
print(" ✓ ContentPage model imported")
except ImportError as e:
print(f" ✗ ContentPage model failed: {e}")
# ----------------------------------------------------------------------------
# PRODUCT MODELS
# ----------------------------------------------------------------------------
try:
from models.database.product import Product
print(" ✓ Product model imported")
except ImportError as e:
print(f" ✗ Product model failed: {e}")
try:
from models.database.marketplace_product import MarketplaceProduct
print(" ✓ MarketplaceProduct model imported")
except ImportError as e:
print(f" ✗ MarketplaceProduct model failed: {e}")
# ----------------------------------------------------------------------------
# INVENTORY MODEL
# ----------------------------------------------------------------------------
try:
from models.database.inventory import Inventory
print(" ✓ Inventory model imported")
except ImportError as e:
print(f" ✗ Inventory model failed: {e}")
# ----------------------------------------------------------------------------
# MARKETPLACE IMPORT
# ----------------------------------------------------------------------------
try:
from models.database.marketplace_import_job import MarketplaceImportJob
print(" ✓ MarketplaceImportJob model imported")
except ImportError as e:
print(f" ✗ MarketplaceImportJob model failed: {e}")
# ----------------------------------------------------------------------------
# CUSTOMER MODELS
# ----------------------------------------------------------------------------
try:
from models.database.customer import Customer, CustomerAddress
print(" ✓ Customer models imported (2 models)")
print(" - Customer")
print(" - CustomerAddress")
except ImportError as e:
print(f" ✗ Customer models failed: {e}")
# ----------------------------------------------------------------------------
# CART MODELS
# ----------------------------------------------------------------------------
try:
from models.database.cart import CartItem
print(" ✓ Cart models imported (1 model)")
print(" - CartItem")
except ImportError as e:
print(f" ✗ Cart models failed: {e}")
# ----------------------------------------------------------------------------
# ORDER MODELS
# ----------------------------------------------------------------------------
try:
from models.database.order import Order, OrderItem
print(" ✓ Order models imported (2 models)")
print(" - Order")
print(" - OrderItem")
except ImportError as e:
print(f" ✗ Order models failed: {e}")
# ============================================================================
# SUMMARY
# ============================================================================
print("=" * 70)
print(f"[ALEMBIC] Model import completed")
print(f"[ALEMBIC] Tables detected in metadata:")
print("=" * 70)
if Base.metadata.tables:
for i, table_name in enumerate(sorted(Base.metadata.tables.keys()), 1):
print(f" {i:2d}. {table_name}")
print("=" * 70)
print(f"[ALEMBIC] Total tables: {len(Base.metadata.tables)}")
else:
print(" ⚠️ WARNING: No tables found in metadata!")
print(" This usually means models are not being imported correctly.")
print("=" * 70)
print()
# ============================================================================
# ALEMBIC CONFIGURATION
# ============================================================================
# Alembic Config object
config = context.config
# Override sqlalchemy.url with our settings
config.set_main_option("sqlalchemy.url", settings.database_url)
if config.config_file_name is not None:
fileConfig(config.config_file_name)
# Set target metadata from Base
target_metadata = Base.metadata
def run_migrations_offline() -> None:
"""
Run migrations in 'offline' mode.
This configures the context with just a URL and not an Engine,
though an Engine is acceptable here as well. By skipping the Engine
creation we don't even need a DBAPI to be available.
Calls to context.execute() here emit the given string to the script output.
"""
url = config.get_main_option("sqlalchemy.url")
context.configure(
url=url,
target_metadata=target_metadata,
literal_binds=True,
dialect_opts={"paramstyle": "named"},
)
with context.begin_transaction():
context.run_migrations()
def run_migrations_online() -> None:
"""
Run migrations in 'online' mode.
In this scenario we need to create an Engine and associate a connection
with the context.
"""
connectable = engine_from_config(
config.get_section(config.config_ini_section, {}),
prefix="sqlalchemy.",
poolclass=pool.NullPool,
)
with connectable.connect() as connection:
context.configure(
connection=connection,
target_metadata=target_metadata
)
with context.begin_transaction():
context.run_migrations()
# ============================================================================
# MAIN EXECUTION
# ============================================================================
if context.is_offline_mode():
run_migrations_offline()
else:
run_migrations_online()