The require_module_access dependency was using path-based detection to determine admin vs vendor authentication, which failed for API routes (/api/v1/admin/*) because it only checked for /admin/*. Changes: - Make frontend_type parameter mandatory (was optional with fallback) - Remove path-based detection logic from require_module_access - Update all 33 module route files to pass explicit FrontendType: - 15 admin routes use FrontendType.ADMIN - 18 vendor routes use FrontendType.VENDOR This ensures authentication method is explicitly declared at route definition time, making it independent of URL structure and future-proof for API version changes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
28 lines
1000 B
Python
28 lines
1000 B
Python
# app/modules/messaging/routes/api/admin.py
|
|
"""
|
|
Messaging module admin API routes.
|
|
|
|
Aggregates all admin messaging routes:
|
|
- /messages/* - Conversation and message management
|
|
- /notifications/* - Admin notifications and platform alerts
|
|
- /email-templates/* - Email template management
|
|
"""
|
|
|
|
from fastapi import APIRouter, Depends
|
|
|
|
from app.api.deps import require_module_access
|
|
from app.modules.enums import FrontendType
|
|
|
|
from .admin_messages import admin_messages_router
|
|
from .admin_notifications import admin_notifications_router
|
|
from .admin_email_templates import admin_email_templates_router
|
|
|
|
admin_router = APIRouter(
|
|
dependencies=[Depends(require_module_access("messaging", FrontendType.ADMIN))],
|
|
)
|
|
|
|
# Aggregate all messaging admin routes
|
|
admin_router.include_router(admin_messages_router, tags=["admin-messages"])
|
|
admin_router.include_router(admin_notifications_router, tags=["admin-notifications"])
|
|
admin_router.include_router(admin_email_templates_router, tags=["admin-email-templates"])
|