Files
orion/tests/unit/services/test_team_service.py
Samir Boulahtit d7a0ff8818 refactor: complete module-driven architecture migration
This commit completes the migration to a fully module-driven architecture:

## Models Migration
- Moved all domain models from models/database/ to their respective modules:
  - tenancy: User, Admin, Vendor, Company, Platform, VendorDomain, etc.
  - cms: MediaFile, VendorTheme
  - messaging: Email, VendorEmailSettings, VendorEmailTemplate
  - core: AdminMenuConfig
- models/database/ now only contains Base and TimestampMixin (infrastructure)

## Schemas Migration
- Moved all domain schemas from models/schema/ to their respective modules:
  - tenancy: company, vendor, admin, team, vendor_domain
  - cms: media, image, vendor_theme
  - messaging: email
- models/schema/ now only contains base.py and auth.py (infrastructure)

## Routes Migration
- Moved admin routes from app/api/v1/admin/ to modules:
  - menu_config.py -> core module
  - modules.py -> tenancy module
  - module_config.py -> tenancy module
- app/api/v1/admin/ now only aggregates auto-discovered module routes

## Menu System
- Implemented module-driven menu system with MenuDiscoveryService
- Extended FrontendType enum: PLATFORM, ADMIN, VENDOR, STOREFRONT
- Added MenuItemDefinition and MenuSectionDefinition dataclasses
- Each module now defines its own menu items in definition.py
- MenuService integrates with MenuDiscoveryService for template rendering

## Documentation
- Updated docs/architecture/models-structure.md
- Updated docs/architecture/menu-management.md
- Updated architecture validation rules for new exceptions

## Architecture Validation
- Updated MOD-019 rule to allow base.py in models/schema/
- Created core module exceptions.py and schemas/ directory
- All validation errors resolved (only warnings remain)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:02:56 +01:00

201 lines
6.2 KiB
Python

# tests/unit/services/test_team_service.py
"""
Unit tests for TeamService.
Tests cover:
- Get team members
- Invite team member
- Update team member
- Remove team member
- Get vendor roles
"""
from datetime import UTC, datetime
from unittest.mock import MagicMock
import pytest
from app.exceptions import ValidationException
from app.modules.tenancy.services.team_service import TeamService, team_service
from app.modules.tenancy.models import Role, VendorUser
@pytest.mark.unit
@pytest.mark.service
class TestTeamServiceGetMembers:
"""Test get_team_members functionality"""
def test_get_team_members_empty(self, db, test_vendor, test_user):
"""Test get_team_members returns empty list when no members"""
service = TeamService()
result = service.get_team_members(db, test_vendor.id, test_user)
assert isinstance(result, list)
def test_get_team_members_with_data(self, db, test_vendor_with_vendor_user, test_user):
"""Test get_team_members returns member data or raises"""
service = TeamService()
try:
result = service.get_team_members(
db, test_vendor_with_vendor_user.id, test_user
)
assert isinstance(result, list)
if len(result) > 0:
member = result[0]
assert "id" in member
assert "email" in member
except ValidationException:
# This is expected if the vendor user has no role
pass
@pytest.mark.unit
@pytest.mark.service
class TestTeamServiceInvite:
"""Test invite_team_member functionality"""
def test_invite_team_member_placeholder(self, db, test_vendor, test_user):
"""Test invite_team_member returns placeholder response"""
service = TeamService()
result = service.invite_team_member(
db,
test_vendor.id,
{"email": "newmember@example.com", "role": "member"},
test_user,
)
assert "message" in result
assert result["email"] == "newmember@example.com"
@pytest.mark.unit
@pytest.mark.service
class TestTeamServiceUpdate:
"""Test update_team_member functionality"""
def test_update_team_member_not_found(self, db, test_vendor, test_user):
"""Test update_team_member raises for non-existent member"""
service = TeamService()
with pytest.raises(ValidationException) as exc_info:
service.update_team_member(
db,
test_vendor.id,
99999, # Non-existent user
{"role_id": 1},
test_user,
)
assert "failed" in str(exc_info.value).lower()
def test_update_team_member_success(
self, db, test_vendor_with_vendor_user, test_vendor_user, test_user
):
"""Test update_team_member updates member"""
service = TeamService()
# Get the vendor_user record
vendor_user = (
db.query(VendorUser)
.filter(VendorUser.vendor_id == test_vendor_with_vendor_user.id)
.first()
)
if vendor_user:
result = service.update_team_member(
db,
test_vendor_with_vendor_user.id,
vendor_user.user_id,
{"is_active": True},
test_user,
)
db.commit()
assert result["message"] == "Team member updated successfully"
assert result["user_id"] == vendor_user.user_id
@pytest.mark.unit
@pytest.mark.service
class TestTeamServiceRemove:
"""Test remove_team_member functionality"""
def test_remove_team_member_not_found(self, db, test_vendor, test_user):
"""Test remove_team_member raises for non-existent member"""
service = TeamService()
with pytest.raises(ValidationException) as exc_info:
service.remove_team_member(
db,
test_vendor.id,
99999, # Non-existent user
test_user,
)
assert "failed" in str(exc_info.value).lower()
def test_remove_team_member_success(
self, db, test_vendor_with_vendor_user, test_vendor_user, test_user
):
"""Test remove_team_member soft deletes member"""
service = TeamService()
# Get the vendor_user record
vendor_user = (
db.query(VendorUser)
.filter(VendorUser.vendor_id == test_vendor_with_vendor_user.id)
.first()
)
if vendor_user:
result = service.remove_team_member(
db,
test_vendor_with_vendor_user.id,
vendor_user.user_id,
test_user,
)
db.commit()
assert result is True
# Verify soft delete
db.refresh(vendor_user)
assert vendor_user.is_active is False
@pytest.mark.unit
@pytest.mark.service
class TestTeamServiceRoles:
"""Test get_vendor_roles functionality"""
def test_get_vendor_roles_empty(self, db, test_vendor):
"""Test get_vendor_roles returns empty list when no roles"""
service = TeamService()
result = service.get_vendor_roles(db, test_vendor.id)
assert isinstance(result, list)
def test_get_vendor_roles_with_data(self, db, test_vendor_with_vendor_user):
"""Test get_vendor_roles returns role data"""
# Create a role for the vendor
role = Role(
vendor_id=test_vendor_with_vendor_user.id,
name="Test Role",
permissions=["view_orders", "edit_products"],
)
db.add(role)
db.commit()
service = TeamService()
result = service.get_vendor_roles(db, test_vendor_with_vendor_user.id)
assert len(result) >= 1
role_data = next((r for r in result if r["name"] == "Test Role"), None)
if role_data:
assert role_data["permissions"] == ["view_orders", "edit_products"]
@pytest.mark.unit
@pytest.mark.service
class TestTeamServiceSingleton:
"""Test singleton instance"""
def test_singleton_exists(self):
"""Test team_service singleton exists"""
assert team_service is not None
assert isinstance(team_service, TeamService)